From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15447 invoked by alias); 2 Apr 2013 21:15:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15420 invoked by uid 89); 2 Apr 2013 21:15:24 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail-vc0-f171.google.com (HELO mail-vc0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Apr 2013 21:15:22 +0000 Received: by mail-vc0-f171.google.com with SMTP id ha11so938522vcb.16 for ; Tue, 02 Apr 2013 14:15:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding :x-gm-message-state; bh=EAHQwkhKaCPHhRrWqgfmyVIlCoy+MCrqA5vFZ54kpag=; b=Krne6TuiSTtqjx/X3jC0/DqA0E+gd5BMUFHrvbKwZce5UYDccwQtSljvR9Nydc7rAZ jLV1WlSFCvNsvF7QQCTvjTf2bNHXnV3tAPpWmi/WjmONDce+UGyAyawr90DoFRd4gc0s 2BJt+fg4hnJNVDv4PHQPM2t7Punc0Ia11uQkYSX0SFVWdykIeNg/JYjCDB1eNV0HYJPP drP9dhzbz9tBaglLS+QNlGkESip1eAr/O2CusaEIJEDQk+vyJZO8/Ae3askqp9Gvki2o n1rQIXUezgMX2Mhn3mpzYW3EdbuSAPuEG3GhHF0Tmc/bc8TgSNnBwC8T/i8XSPQScNa1 HpXA== MIME-Version: 1.0 X-Received: by 10.220.71.200 with SMTP id i8mr105657vcj.44.1364937320245; Tue, 02 Apr 2013 14:15:20 -0700 (PDT) Received: by 10.220.85.68 with HTTP; Tue, 2 Apr 2013 14:15:20 -0700 (PDT) In-Reply-To: <5155B1A9.3030503@codesourcery.com> References: <1364462710-16702-1-git-send-email-yao@codesourcery.com> <51545E43.1020703@redhat.com> <5155B1A9.3030503@codesourcery.com> Date: Wed, 03 Apr 2013 13:44:00 -0000 Message-ID: Subject: Re: [PATCH] Add completer to commands 'target {core/tfile/exec}' From: Doug Evans To: Yao Qi Cc: Pedro Alves , gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQkP2oLolIeDz5HHXaIFaxEl3+xOGrbpdqLpgBTt8/vVRbJrcusu107R/7EU73oWHkJkrADSo6QsRPdPXSzAbIuyy8Qpt3gXj+MTWhwHoCO5HIy9/AJI5YmarLT/qoy/P9lcAnSrtkjc/jGRvxpYNb2MQIZkI7Ep64hZ5TZ5VsV76mWpk9rzF3mZfwnb7nOvkP6SefUvrNoBWbAHGlEvT34IIBAPcA== X-SW-Source: 2013-04/txt/msg00066.txt.bz2 On Fri, Mar 29, 2013 at 8:22 AM, Yao Qi wrote: > On 03/28/2013 11:14 PM, Pedro Alves wrote: >>> (add_target_with_completer): ... it. New. Call set_cmd_completer= if >>> > parameter completer is not NULL. >> s/it./this./. "New." looks stale here. Did you mean "New parameter"? >> > > "New" is not needed here. Removed. Patch below is committed. Thanks > for the review. > > -- > Yao (=E9=BD=90=E5=B0=A7) > > gdb: > > 2013-03-29 Yao Qi > > * corelow.c: Include "completer.h". > (_initialize_corelow): Call add_target_with_completer with > argument 'filename_completer'. > * tracepoint.c: Likewise. > * exec.c (_initialize_exec): Likewise. > * target.c (add_target): Rename to ... > (add_target_with_completer): ... this. Call set_cmd_completer > if parameter completer is not NULL. > (add_target): New. > * target.h: Include "command.h". > (add_target_with_completer): Declare it. > > gdb/testsuite: > > 2013-03-29 Yao Qi > > * gdb.base/completion.exp: Test completion of commands > "target core", "target tfile" and "target exec". > * gdb.trace/tfile.exp: Test completion of command > "target tfile". > [...] > diff --git a/gdb/testsuite/gdb.trace/tfile.exp b/gdb/testsuite/gdb.trace/= tfile.exp > index e8a778d..3b720cc 100644 > --- a/gdb/testsuite/gdb.trace/tfile.exp > +++ b/gdb/testsuite/gdb.trace/tfile.exp > @@ -128,3 +128,8 @@ gdb_test \ > gdb_test "interpreter-exec mi \"-trace-status\"" \ > "\\^done,supported=3D\"file\",trace-file=3D\".*basic.tf\",running=3D= \"0\",stop-reason=3D\"request\",frames=3D\"${decimal}\",frames-created=3D\"= ${decimal}\",buffer-size=3D\"${decimal}\",buffer-free=3D\"${decimal}\",disc= onnected=3D\".*\",circular=3D\".*\",user-name=3D\"\",notes=3D\"\",start-tim= e=3D\".*\",stop-time=3D\".*\"" \ > "-trace-status" > + > +# Test completion works well. > + > +gdb_test "target tfile basic\t" "Assuming tracepoint.*" \ > + "complete-command 'target tfile'" Hi. This test is failing for me because I have another file that begins with "basic". Can you change this to use "tfile-basic" instead of "basic?