From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21509 invoked by alias); 9 Apr 2012 18:26:49 -0000 Received: (qmail 21501 invoked by uid 22791); 9 Apr 2012 18:26:48 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Apr 2012 18:26:29 +0000 Received: by vbbey12 with SMTP id ey12so3014864vbb.0 for ; Mon, 09 Apr 2012 11:26:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=nmMfcPjK6a2m7ByU4FurnghLTFSz+tc+KXn5E+RqEwg=; b=PJrLkFE8LZ2zjxVnvEg857zotEVpotMiycJWttAFg1T50wVUqkfgmuPv+gvD5AyGQo MGvDJWdoIyFGdGSFG61yQLrlE9fx0ncpdABNaKj8L4sltGsJXlbYiyNr3HMfkIjRkwdV KyHkoVR7fe+KINqYQaDazV/q1Sgujg1qQtQ38kQEftXD7T147KDjpi69IMkiW+VQWL8E RxlctWSEFGN1Pn4wmPRfpYNVRK6vs+k573i2z/4pvAasnb7HPPqbMURzV+bK0HITaaNW 6LoACjgt5a028301BncDwLnGOk5rGNQHXdC0ydg1ACtkXmiDA0gs53KqeajM7Vb9jr6t NOtQ== Received: by 10.52.98.200 with SMTP id ek8mr3372070vdb.36.1333995989298; Mon, 09 Apr 2012 11:26:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.98.200 with SMTP id ek8mr3372062vdb.36.1333995989109; Mon, 09 Apr 2012 11:26:29 -0700 (PDT) Received: by 10.220.73.14 with HTTP; Mon, 9 Apr 2012 11:26:28 -0700 (PDT) In-Reply-To: <87mx6k93f4.fsf@fleche.redhat.com> References: <20120409174612.1F60824618E@ruffy.mtv.corp.google.com> <87mx6k93f4.fsf@fleche.redhat.com> Date: Mon, 09 Apr 2012 18:26:00 -0000 Message-ID: Subject: Re: [patch] find_partial_die cleanups From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQnTe2IMGO8XNzlEQBzFIPeSuPpz9yTsVUlwBXTLDE4lUsaItrRANMXS0T5T3GfEwtGwZE2KbQmg7U6vEQ03LVegFXvi/ujmiXLCDro49d7hVh/cDJLZ1SdcHZn1IV+hHOjU6Vddwb/GjPI9bthh2FDI9oYAmw== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00158.txt.bz2 On Mon, Apr 9, 2012 at 11:16 AM, Tom Tromey wrote: > Doug> + =A0 error (_("Dwarf Error: Type Unit at offset 0x%lx contains" > Doug> + =A0 =A0 =A0 =A0 =A0 =A0" external reference to offset 0x%lx [in m= odule %s].\n"), > Doug> + =A0 =A0 =A0 =A0 =A0(long) cu->header.offset.sect_off, (long) offs= et.sect_off, > Doug> + =A0 =A0 =A0 =A0 =A0bfd_get_filename (objfile->obfd)); > > Why an error and not a complaint? > > I ask because errors have a pretty drastic effect on debuginfo reading. "Right on queue." :-) Indeed. And I would have used a complaint but the callers aren't expecting a NULL return and since there is ample precedent, I went with error. I'm happy to go throught all the callers and bubble up the consequences, but my first pass at this gave me pause. > Doug> + =A0 =A0 =A0struct dwarf2_section_info* sec; > > Wrong "*" placement. Heh, righto.