From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88970 invoked by alias); 10 Nov 2016 17:53:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88957 invoked by uid 89); 10 Nov 2016 17:53:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Nov 2016 17:53:48 +0000 Received: by mail-wm0-f45.google.com with SMTP id g23so55966841wme.1 for ; Thu, 10 Nov 2016 09:53:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=51oyirQEIq3/oX4N/vlwU5VzhjgFNjlqnrus8hl1vl8=; b=kjV9d5pHofv/42/x0bKsV7GlKYgDHi1rvlBLbyM7IjUJrjncJZHl4IH+HyoUM2GwIf TdYaVPZZ4W1WB70C5V3UGKrfU8SO9duIvSD+V3Kf0FPTbfFzAxKgPmo5QqvDhzDVZ/ig UCmTOWVPIC9JxMIKcLgdznvl5ZzDBc+GjgJBThd/tkJRVsaJqG5iwtVINIKGvUT5TjjN w3xozXAi/7UXHoYDbMWYg0HV2OAPfGoYi42InyDNfKtwgOfWcCnVwI/Fuee/5qtDDH3R 5cBWJqmOyu9fa7L/pM3AcwbZ9jyD0W9+pvRrJPIMSIW7uX8RFAFadzGpk7RbwzYV1qpz Po9w== X-Gm-Message-State: ABUngvfLkrQiGhg3enIhDGVaoqXbU23PjDT9+vlJ8nimLWKR4VkUxVmJ9YEazRSrSpYMKUKZDf/gTHEOuf92zy2C X-Received: by 10.28.129.81 with SMTP id c78mr7005446wmd.94.1478800426300; Thu, 10 Nov 2016 09:53:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.152.70 with HTTP; Thu, 10 Nov 2016 09:53:05 -0800 (PST) In-Reply-To: <1478789679-30957-2-git-send-email-yao.qi@linaro.org> References: <1478789679-30957-1-git-send-email-yao.qi@linaro.org> <1478789679-30957-2-git-send-email-yao.qi@linaro.org> From: Doug Evans Date: Thu, 10 Nov 2016 17:53:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] Remove apply_val_pretty_printer parameter valaddr To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00250.txt.bz2 On Thu, Nov 10, 2016 at 6:54 AM, Yao Qi wrote: > This patch removes the parameter valaddr of > extension_language_ops::apply_val_pretty_printer and remove const from > "struct value *val". valaddr can be got in each extension language's > implementation of apply_val_pretty_printer. > > gdb: > > 2016-11-10 Yao Qi > > * cp-valprint.c (cp_print_value): Remove local base_valaddr. > * extension-priv.h (struct extension_language_ops) > : Remove the second parameter. > Remove const from "struct value *". Callers updated. > * extension.c (apply_ext_lang_val_pretty_printer): Update > comments. Remove parameter valaddr. Remove const from > "struct value *". > * extension.h (apply_ext_lang_val_pretty_printer): Update > declaration. > * guile/guile-internal.h (gdbscm_apply_val_pretty_printer): > Update declaration. > * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): > Remove parameter valaddr. Remove const from "struct value *". > * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): > Likewise. > * python/python-internal.h (gdbpy_apply_val_pretty_printer): > Update declaration. LGTM