From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1899 invoked by alias); 12 Jul 2012 21:33:28 -0000 Received: (qmail 1890 invoked by uid 22791); 12 Jul 2012 21:33:28 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jul 2012 21:33:15 +0000 Received: by vcbfl10 with SMTP id fl10so2301842vcb.0 for ; Thu, 12 Jul 2012 14:33:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=gmns/IixZ+FO+NVXAtLqeUkWOOxfaSqitrEfpTb0Cg4=; b=C4CA1vnucPH4OvYxWvHZYh95t5fwju/t6nBx2F4Y+GBqmpPVmvDblFuQIoIJ98PmSF XMEaFEVkmlM2fNgTkJZ4a26xNk+VhMl1g+pJpsiRUsoDD8lzUoIxYDwUguCAFCuZ7Fpb tLmeCEWWR/wv8OetH4H2Jr6qkxyp7tsoJlMaXgqPxFLkfcRACRsoXsjkf/iuZu30A0z6 TeVdaAckU2gJOkLBVRzU4sOB4WsUpSu4757N7/nDhA4W8mUOGtoSFAV/TGz+rJqToA0Q DgJ6zcWEexU0h321Lo6T+ae5zQDuk6k4mePgvgDUZxSaMBYRvgufsMY0tck02nB04sjH ODjQ== Received: by 10.52.22.33 with SMTP id a1mr19307427vdf.104.1342128794474; Thu, 12 Jul 2012 14:33:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.22.33 with SMTP id a1mr19307412vdf.104.1342128794089; Thu, 12 Jul 2012 14:33:14 -0700 (PDT) Received: by 10.52.157.4 with HTTP; Thu, 12 Jul 2012 14:33:14 -0700 (PDT) In-Reply-To: <87629vip17.fsf@fleche.redhat.com> References: <20120710003324.100001E13A1@ruffy2.mtv.corp.google.com> <87629vip17.fsf@fleche.redhat.com> Date: Thu, 12 Jul 2012 21:33:00 -0000 Message-ID: Subject: Re: [RFA] symtab.c: Set "first" to zero. From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf3079bdb003b7c804c4a8b6ec X-System-Of-Record: true X-Gm-Message-State: ALoCoQnq0n14ijTOnJ96AcylvLyfeWxeNUR6YFnUV5cP7FTzv7rPsb2J36K7GnOPjCyyBJuUBFwlGcMitODiL48JhdYuGYS0xqJwjDcpHwoCFW21Cm/rDZMA341jAc4wpPO3XgFSlnXWbKXRnfIrynepKYLiAa7sEfvfD2K5W1R8Zejph/Mele3F/CBJS5X40SL5iC6Qq378 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00170.txt.bz2 --20cf3079bdb003b7c804c4a8b6ec Content-Type: text/plain; charset=ISO-8859-1 Content-length: 565 On Tue, Jul 10, 2012 at 9:01 AM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > > Doug> 2012-07-09 Doug Evans > Doug> * symtab.c (maybe_add_partial_symtab_filename): Set "first" to zero > Doug> after calling filename_seen. > Doug> (make_source_files_completion_list): Ditto. > > I wonder whether filename_seen should clear *first. > > Tom Any preference? 2012-07-12 Doug Evans * symtab.c (filename_seen): Set *first to 0. (output_source_filename): Update. --20cf3079bdb003b7c804c4a8b6ec Content-Type: text/plain; charset=US-ASCII; name="gdb-120712-filename-seen-first-2.patch.txt" Content-Disposition: attachment; filename="gdb-120712-filename-seen-first-2.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h4kctoql0 Content-length: 2611 MjAxMi0wNy0xMiAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog c3ltdGFiLmMgKGZpbGVuYW1lX3NlZW4pOiBTZXQgKmZpcnN0IHRvIDAuCgko b3V0cHV0X3NvdXJjZV9maWxlbmFtZSk6IFVwZGF0ZS4KCkluZGV4OiBzeW10 YWIuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Ny Yy9zcmMvZ2RiL3N5bXRhYi5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjMx NgpkaWZmIC11IC1wIC1yMS4zMTYgc3ltdGFiLmMKLS0tIHN5bXRhYi5jCTI5 IEp1biAyMDEyIDIyOjQ2OjQ1IC0wMDAwCTEuMzE2CisrKyBzeW10YWIuYwkx MiBKdWwgMjAxMiAyMToyOTo1MiAtMDAwMApAQCAtMzEwOCw3ICszMTA4LDcg QEAgb3BlcmF0b3JfY2hhcnMgKGNoYXIgKnAsIGNoYXIgKiplbmQpCiAvKiBJ ZiBGSUxFIGlzIG5vdCBhbHJlYWR5IGluIHRoZSB0YWJsZSBvZiBmaWxlcywg cmV0dXJuIHplcm87CiAgICBvdGhlcndpc2UgcmV0dXJuIG5vbi16ZXJvLiAg T3B0aW9uYWxseSBhZGQgRklMRSB0byB0aGUgdGFibGUgaWYgQURECiAgICBp cyBub24temVyby4gIElmICpGSVJTVCBpcyBub24temVybywgZm9yZ2V0IHRo ZSBvbGQgdGFibGUKLSAgIGNvbnRlbnRzLiAgKi8KKyAgIGNvbnRlbnRzIGFu ZCB0aGVuIHNldCAqRklSU1QgPSAwLiAgKi8KIAogc3RhdGljIGludAogZmls ZW5hbWVfc2VlbiAoY29uc3QgY2hhciAqZmlsZSwgaW50IGFkZCwgaW50ICpm aXJzdCkKQEAgLTMxMjgsNiArMzEyOCw3IEBAIGZpbGVuYW1lX3NlZW4gKGNv bnN0IGNoYXIgKmZpbGUsIGludCBhZGQKICAgICAgIGlmICh0YWIgPT0gTlVM TCkKIAl0YWIgPSAoY29uc3QgY2hhciAqKikgeG1hbGxvYyAodGFiX2FsbG9j X3NpemUgKiBzaXplb2YgKCp0YWIpKTsKICAgICAgIHRhYl9jdXJfc2l6ZSA9 IDA7CisgICAgICAqZmlyc3QgPSAwOwogICAgIH0KIAogICAvKiBJcyBGSUxF IGluIHRhYj8gICovCkBAIC0zMTU3LDYgKzMxNTgsOCBAQCBmaWxlbmFtZV9z ZWVuIChjb25zdCBjaGFyICpmaWxlLCBpbnQgYWRkCiBzdGF0aWMgdm9pZAog b3V0cHV0X3NvdXJjZV9maWxlbmFtZSAoY29uc3QgY2hhciAqbmFtZSwgaW50 ICpmaXJzdCkKIHsKKyAgaW50IGlzX2ZpcnN0ID0gKmZpcnN0OworCiAgIC8q IFNpbmNlIGEgc2luZ2xlIHNvdXJjZSBmaWxlIGNhbiByZXN1bHQgaW4gc2V2 ZXJhbCBwYXJ0aWFsIHN5bWJvbAogICAgICB0YWJsZXMsIHdlIG5lZWQgdG8g YXZvaWQgcHJpbnRpbmcgaXQgbW9yZSB0aGFuIG9uY2UuICBOb3RlOiBpZgog ICAgICBzb21lIG9mIHRoZSBwc3ltdGFicyBhcmUgcmVhZCBpbiBhbmQgc29t ZSBhcmUgbm90LCBpdCBnZXRzCkBAIC0zMTY2LDE4ICszMTY5LDE1IEBAIG91 dHB1dF9zb3VyY2VfZmlsZW5hbWUgKGNvbnN0IGNoYXIgKm5hbWUKICAgICAg c2l0dWF0aW9uLiAgSSdtIG5vdCBzdXJlIHdoZXRoZXIgdGhpcyBjYW4gYWxz byBoYXBwZW4gZm9yCiAgICAgIHN5bXRhYnM7IGl0IGRvZXNuJ3QgaHVydCB0 byBjaGVjay4gICovCiAKLSAgLyogV2FzIE5BTUUgYWxyZWFkeSBzZWVuPyAg Ki8KKyAgLyogV2FzIE5BTUUgYWxyZWFkeSBzZWVuPworICAgICBOb3RlOiBm aWxlbmFtZV9zZWVuIHJlc2V0cyAqZmlyc3QuICAqLwogICBpZiAoZmlsZW5h bWVfc2VlbiAobmFtZSwgMSwgZmlyc3QpKQogICAgIHsKICAgICAgIC8qIFll czsgZG9uJ3QgcHJpbnQgaXQgYWdhaW4uICAqLwogICAgICAgcmV0dXJuOwog ICAgIH0KLSAgLyogTm87IHByaW50IGl0IGFuZCByZXNldCAqRklSU1QuICAq LwotICBpZiAoKmZpcnN0KQotICAgIHsKLSAgICAgICpmaXJzdCA9IDA7Ci0g ICAgfQotICBlbHNlCisKKyAgaWYgKCEgaXNfZmlyc3QpCiAgICAgewogICAg ICAgcHJpbnRmX2ZpbHRlcmVkICgiLCAiKTsKICAgICB9Cg== --20cf3079bdb003b7c804c4a8b6ec--