From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20040 invoked by alias); 27 Oct 2014 19:32:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20027 invoked by uid 89); 27 Oct 2014 19:32:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f41.google.com Received: from mail-qg0-f41.google.com (HELO mail-qg0-f41.google.com) (209.85.192.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 27 Oct 2014 19:32:56 +0000 Received: by mail-qg0-f41.google.com with SMTP id q107so2313836qgd.14 for ; Mon, 27 Oct 2014 12:32:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=0HwfMqPnaOSOnbO4ofpGWdxVjhwNtSdsYc1WMh0jfAE=; b=fMrOGJI+rGRcCXcmVadGs0r3tycHgROR+I6jsrTHu2RRTtROyEIzFs29v4dcVukESz HMXd55WN9hgRqPzTupHcZ0UQAnnXnJ6i0guJRDPd3zs/0BmYgu6tFIbLzoKA0k3pDfsY Gz/epC3C1UncSy3pF4ot50Ba2JoEnZ95iqnTS7PQj5fEblLDOraRNsI4KFrcDWM1tZTQ vcpjN6Skk0iWMpbW1+YOB5PhSFGEalbSOME/pzZUirHcGgTm9Ocu6I7fIqaQoHu9yXvQ 0bgwiVXchihgb04Nj9uMaj7m3Zj3N+m0jZDzY2A5mRVVrV1ml1LfLDpfO78YOY33Wi0h 6DZg== X-Gm-Message-State: ALoCoQnywd6iI6Ibz+4RG6CuSLMJYYXqiTcNpoeokR1ta9S5ABHCQRtJOycgYAXEqXpRkQThl5yk MIME-Version: 1.0 X-Received: by 10.140.27.164 with SMTP id 33mr33702622qgx.57.1414438373883; Mon, 27 Oct 2014 12:32:53 -0700 (PDT) Received: by 10.229.250.4 with HTTP; Mon, 27 Oct 2014 12:32:53 -0700 (PDT) In-Reply-To: <542E650E.4090609@redhat.com> References: <542C936A.60507@redhat.com> <542E650E.4090609@redhat.com> Date: Mon, 27 Oct 2014 19:32:00 -0000 Message-ID: Subject: Re: [PATCH] Don't run forever in gdb.base/structs.c From: Doug Evans To: Pedro Alves Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00742.txt.bz2 On Fri, Oct 3, 2014 at 1:57 AM, Pedro Alves wrote: > On 10/02/2014 09:10 PM, Doug Evans wrote: >> On Wed, Oct 1, 2014 at 4:51 PM, Pedro Alves wrote: >>> On 10/01/2014 10:02 PM, Doug Evans wrote: >>> >>>> If gdb crashes during testing tests may be left to free-run, eating cpu. >>>> >>>> This patch fixes one of the more egregious cases since several versions >>>> of the program are built. >>>> >>>> I've got patches to fix others. >>>> Just seeing if folks want to comment on this first. >>>> >>>> IWBN to have the harness itself cleanup, and I think there's something >>>> we can do there, but that's not always robust either, and I think >>>> multiple levels of robustness would be useful. >>> >>> Agreed. >>> >>>> Since this testcase is an egregious one, and since this patch simple, >>>> I'm starting with this. >>> >>> Looks fine with me. >> >> Committed, thanks. > > Thank you. Guess this could be material for: > > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook Good idea. Done.