From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108806-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8533 invoked by alias); 3 Jan 2014 17:53:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8523 invoked by uid 89); 3 Jan 2014 17:53:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-ve0-f174.google.com
Received: from mail-ve0-f174.google.com (HELO mail-ve0-f174.google.com) (209.85.128.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 03 Jan 2014 17:53:32 +0000
Received: by mail-ve0-f174.google.com with SMTP id pa12so7950987veb.19        for <gdb-patches@sourceware.org>; Fri, 03 Jan 2014 09:53:29 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=owX9hCu9OyZ2FyoLlqvi2V23V7z06txf8ZuACuJndY8=;        b=SydX8ebpqgtaW4wG1gHaWP0b7TwTjVJoJzYbLigthxtFaE+0fWu0cePVdHe0ouGGqw         BFRicH0LANBI34trhBznvE4pspMwTepGoxjHSy90jvB3wViJJMiJ/i7Mukf4vhHrkzYS         kzjO8XJGTXTrTiXHzn+EuQEziJFATP1qACyYwMTLNz1lCGS+pOu7NuA4TfmYhRt9HZvo         xu2xgYFXTZjdf2J9UuRj/+WmDRhpwLsghBhvd/BE24LPqfY7MWzy+Q7PXK85kYMYxMO5         HQ1He/axE8NN3gdrFfUMwmf7yIm0DdkDbvVhzHsg4pfEDWTqwtxujuFjpjSPxzTvdaFS         lgjQ==
X-Gm-Message-State: ALoCoQmrRAwjprKqV3bfKHIDan3GsaKO9N2fModk2ufpA5kg9O+L7gMiU1nZ8RrVfLOuxx6oVItqLOq5x4eDuls3yp/+42ldzkVXRQQp0hvzy5RA+qJJ/lOfjTRyh9LHwiifYL3p0xaW0xIPq5Y+wPDkUqHafpGc0wnNN86Exg6s4GNigyiQA6Fe/YuH22TMYoXdmOhEsJGmj9TN1P9ukm0rZ4t/lyAPAA==
MIME-Version: 1.0
X-Received: by 10.220.90.83 with SMTP id h19mr2291331vcm.39.1388771609828; Fri, 03 Jan 2014 09:53:29 -0800 (PST)
Received: by 10.52.248.65 with HTTP; Fri, 3 Jan 2014 09:53:29 -0800 (PST)
In-Reply-To: <52C6CAB2.9020108@redhat.com>
References: <1388753936-2835-1-git-send-email-emachado@linux.vnet.ibm.com>	<52C6CAB2.9020108@redhat.com>
Date: Fri, 03 Jan 2014 17:53:00 -0000
Message-ID: <CADPb22RCi=AJeTjAEy8rBEDDus+7i3JGt6ejqcx6OnvYnEmSwA@mail.gmail.com>
Subject: Re: [PATCH] Fix copy of filename in bfd's filename field
From: Doug Evans <dje@google.com>
To: nick clifton <nickc@redhat.com>
Cc: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>, gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-01/txt/msg00008.txt.bz2

Hi Nick,

On Fri, Jan 3, 2014 at 6:35 AM, nick clifton <nickc@redhat.com> wrote:
> Hi Edjunior,
>
>
>
>> gdb/
>> 2014-01-03  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
>>
>>         * gdb_bfd.c (gdb_bfd_stash_filename): Fix copy of filename in
>> bfd's
>>         filename field using xstrdup.
>
>
>
>> @@ -69,7 +69,7 @@ gdb_bfd_stash_filename (struct bfd *abfd)
>>     strcpy (data, name);
>>
>>     /* Unwarranted chumminess with BFD.  */
>> -  abfd->filename = data;
>> +  abfd->filename = xstrdup (data);
>>   }
>>
>>   /* An object of this type is stored in each BFD's user data.  */
>
>
> It might be nice to remove the comment too. :-)
>
> Cheers
>   Nick

Seems like bfd should export an API routine that sets abfd->filename,
so that the implementation detail that it lives in malloc space is
kept within bfd.