From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24813 invoked by alias); 22 Jun 2015 14:10:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24797 invoked by uid 89); 22 Jun 2015 14:10:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f41.google.com Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 22 Jun 2015 14:10:00 +0000 Received: by oiyy130 with SMTP id y130so105153721oiy.0 for ; Mon, 22 Jun 2015 07:09:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=3woF/3NDiXEclW9JwtVOluzwgjCebWE5qE1XtSK21Wk=; b=GduxMR0Z/ACIeqXtIa+ruqauYlfqyDNS0REjlu9eU1dAyoxEHD1prlTX/3eIUpuagP WFx2w0O3OXYJk/7bheQc0jRL9LamhwWVxFiFmvNMNc7QtlgShc5Zv+82eB5kfl2qhgzs gJf+cPhQfT9RCEsDYZHgxmksFu85PJGu/T/91VDD0VbGAlaOyoePW6csHxNO0RmXyRz4 2u6EsF234cmprMvSIgV5lzwMeUsd58NxK76cQ3mzewKgXo2ZE7hXQzhPEPa157TyR7GT giGZBnOh4wR6q4z3zQPpBcvv4DGJxYEKgZrgB5jX7XjMynNo+GaVKQYpZwTnLRy3c7Pj qUaQ== X-Gm-Message-State: ALoCoQnx8kaz6Rp+fbGsc47KQuGr5lcFkrhEpU1XlKhdjPD+LscoiFu6AWTkOp2yvYD4VBFIRCrF MIME-Version: 1.0 X-Received: by 10.182.40.165 with SMTP id y5mr25200977obk.21.1434982198837; Mon, 22 Jun 2015 07:09:58 -0700 (PDT) Received: by 10.182.89.99 with HTTP; Mon, 22 Jun 2015 07:09:58 -0700 (PDT) In-Reply-To: <20150621184030.GA17734@vapier> References: <20150612091149.GC13625@vapier> <20150621184030.GA17734@vapier> Date: Mon, 22 Jun 2015 14:10:00 -0000 Message-ID: Subject: Re: [PATCH] sim: cgen: namespace custom trace functions From: Doug Evans To: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00441.txt.bz2 On Sun, Jun 21, 2015 at 1:40 PM, Mike Frysinger wrote: > On 14 Jun 2015 06:49, Doug Evans wrote: >> On Fri, Jun 12, 2015 at 2:11 AM, Mike Frysinger wrote: >> > The cgen code declares some macros/funcs using the trace_xxx prefix, but >> > the code isn't generic and only works with cgen targets. This is blocking >> > the creation of new common trace functions. >> > >> > Let's blindly add cgen_xxx prefixes to all these symbols. Some already >> > use this convention to avoid conflicts, so it makes sense to align them. >> > In the future we might want to move some to the common trace core, but >> > one thing at a time. >> > >> > I'm attaching the patch compressed because it's like 2MB in size. It's >> > all pretty mechanical -- the large files were updated using `sed`. >> > >> > Committed. >> >> Heads up, a lot of these are generated files. >> I'm happy to update the generator and regenerate these. > > sorry about that. i'm not terribly familiar with cgen, and the heavy use of > scheme makes it unlikely to improve the situation :/. looks like you posted > a patch though at this point. Feel free to ask for help. Plus for simple renamings like this it's not that hard. [If I can keep my lunch down from the Perl that's been dropped on gdb, I just can't feel bad for having asked people to learn some Scheme. :-)]