Re: [PATCH] Don't run forever in gdb.base/structs.c

Doug Evans
2014-10-27T19:32:59Z

On Fri, Oct 3, 2014 at 1:57 AM, Pedro Alves <palves@redhat.com> wrote:
> On 10/02/2014 09:10 PM, Doug Evans wrote:
>> On Wed, Oct 1, 2014 at 4:51 PM, Pedro Alves <palves@redhat.com> wrote:
>>> On 10/01/2014 10:02 PM, Doug Evans wrote:
>>>
>>>> If gdb crashes during testing tests may be left to free-run, eating cpu.
>>>>
>>>> This patch fixes one of the more egregious cases since several versions
>>>> of the program are built.
>>>>
>>>> I've got patches to fix others.
>>>> Just seeing if folks want to comment on this first.
>>>>
>>>> IWBN to have the harness itself cleanup, and I think there's something
>>>> we can do there, but that's not always robust either, and I think
>>>> multiple levels of robustness would be useful.
>>>
>>> Agreed.
>>>
>>>> Since this testcase is an egregious one, and since this patch simple,
>>>> I'm starting with this.
>>>
>>> Looks fine with me.
>>
>> Committed, thanks.
>
> Thank you. Guess this could be material for:
>
> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook

Good idea. Done.