[PATCH] Don't run forever in gdb.base/structs.c

Doug Evans
2014-10-01T21:02:41Z

Hi.

If gdb crashes during testing tests may be left to free-run, eating cpu.

This patch fixes one of the more egregious cases since several versions
of the program are built.

I've got patches to fix others.
Just seeing if folks want to comment on this first.

IWBN to have the harness itself cleanup, and I think there's something
we can do there, but that's not always robust either, and I think
multiple levels of robustness would be useful.
Since this testcase is an egregious one, and since this patch simple,
I'm starting with this.

I thought of trying to make the loop limit something less random,
but that itself introduces complications, e.g., if one wants to extend
the test. So I kept it simple.
One could instead reorganize the test, but it's not worth it,
at least not at this point.

2014-10-01 Doug Evans <dje@google.com>

* gdb.base/structs.c (main): Don't run forever.

diff --git a/gdb/testsuite/gdb.base/structs.c b/gdb/testsuite/gdb.base/structs.c
index 60772bb..d0b69a8 100644
--- a/gdb/testsuite/gdb.base/structs.c
+++ b/gdb/testsuite/gdb.base/structs.c
@@ -425,12 +425,14 @@ int main()
Fun17(foo17);
Fun18(foo18);

- /* An infinite loop that first clears all the variables and then
+ /* An (almost-)infinite loop that first clears all the variables and then
calls each function. This "hack" is to make testing random
functions easier - "advance funN" is guaranteed to have always
- been preceded by a global variable clearing zed call. */
+ been preceded by a global variable clearing zed call.
+ We don't let this run forever in case gdb crashes while testing,
+ we don't want to be left eating all cpu on the user's system. */

- while (1)
+ for (i = 0; i < 1000000; ++i)
{
zed ();
L1 = fun1();