From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5668 invoked by alias); 10 Oct 2011 05:01:25 -0000 Received: (qmail 5656 invoked by uid 22791); 10 Oct 2011 05:01:20 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Oct 2011 05:01:04 +0000 Received: from hpaq3.eem.corp.google.com (hpaq3.eem.corp.google.com [172.25.149.3]) by smtp-out.google.com with ESMTP id p9A513Ar009322 for ; Sun, 9 Oct 2011 22:01:03 -0700 Received: from qadc14 (qadc14.prod.google.com [10.224.32.142]) by hpaq3.eem.corp.google.com with ESMTP id p9A4xed2030335 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Sun, 9 Oct 2011 22:01:01 -0700 Received: by qadc14 with SMTP id c14so9939677qad.2 for ; Sun, 09 Oct 2011 22:01:01 -0700 (PDT) Received: by 10.224.181.146 with SMTP id by18mr3752979qab.3.1318222861351; Sun, 09 Oct 2011 22:01:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.181.146 with SMTP id by18mr3752963qab.3.1318222861073; Sun, 09 Oct 2011 22:01:01 -0700 (PDT) Received: by 10.224.80.149 with HTTP; Sun, 9 Oct 2011 22:01:00 -0700 (PDT) In-Reply-To: <201110071209.18376.pedro@codesourcery.com> References: <20111005182705.D744E2461D1@ruffy.mtv.corp.google.com> <201110071209.18376.pedro@codesourcery.com> Date: Mon, 10 Oct 2011 05:01:00 -0000 Message-ID: Subject: Re: [RFA] Only try to load libthread_db when we load libpthread. From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf303b3a915e7ec104aeeaad8f X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00253.txt.bz2 --20cf303b3a915e7ec104aeeaad8f Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1544 On Fri, Oct 7, 2011 at 4:09 AM, Pedro Alves wrote: > Well, at least things should work the same as before, which IMO > is good thing as it makes this change an optimization only. That's the intent. >> Blech, I forgot one bit of cleanup. >> Revised patch attached. > > Still breaks activating thread_db when debugging cores of > static executables. Used wrong sandbox for the before case, sigh. [...] > Did you try this suggestion?: > >> I think we'll no longer activate thread_db when debugging core >> files of static executables (e.g., a core of gdb.threads/staticthreads). >> It works with live debugging since we call check_for_thread_db >> from linux_child_post_attach/linux_child_post_startup_inferior. >> Maybe moving that to an inferior_created observer in >> linux-thread-db.c would work. It turns out things work today accidentally. At least I doubt it's by design. :-) My previous patch didn't work because it skipped calling check_for_thread_db when the new_objfile observer was called for vsyscall (which incidentally is called by the inferior_created observer for vsyscall, heh). [Which explains why it didn't surprise me when my before-test failed, that's a pretty unexpected way to load libthread_db.] How about this. 2011-10-09 Doug Evans * linux-thread-db.c (thread_db_new_objfile): Only try to load libthread_db when we load libpthread. (thread_db_inferior_created): New function. (_initialize_thread_db): Attach inferior_created observer. --20cf303b3a915e7ec104aeeaad8f Content-Type: text/plain; charset=US-ASCII; name="gdb-111009-libthread-db-4.patch.txt" Content-Disposition: attachment; filename="gdb-111009-libthread-db-4.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gtkzm6ne0 Content-length: 2888 MjAxMS0xMC0wOSAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog bGludXgtdGhyZWFkLWRiLmMgKHRocmVhZF9kYl9uZXdfb2JqZmlsZSk6IE9u bHkgdHJ5IHRvIGxvYWQKCWxpYnRocmVhZF9kYiB3aGVuIHdlIGxvYWQgbGli cHRocmVhZC4KCSh0aHJlYWRfZGJfaW5mZXJpb3JfY3JlYXRlZCk6IE5ldyBm dW5jdGlvbi4KCShfaW5pdGlhbGl6ZV90aHJlYWRfZGIpOiBBdHRhY2ggaW5m ZXJpb3JfY3JlYXRlZCBvYnNlcnZlci4KCkluZGV4OiBsaW51eC10aHJlYWQt ZGIuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Ny Yy9zcmMvZ2RiL2xpbnV4LXRocmVhZC1kYi5jLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjkxCmRpZmYgLXUgLXAgLXIxLjkxIGxpbnV4LXRocmVhZC1kYi5j Ci0tLSBsaW51eC10aHJlYWQtZGIuYwkxMyBTZXAgMjAxMSAxOToyNzowMSAt MDAwMAkxLjkxCisrKyBsaW51eC10aHJlYWQtZGIuYwkxMCBPY3QgMjAxMSAw Mzo1MjoyNyAtMDAwMApAQCAtMTA3NywxNiArMTA3NywzMiBAQCBjaGVja19m b3JfdGhyZWFkX2RiICh2b2lkKQogICAgIHJldHVybjsKIH0KIAorLyogVGhp cyBmdW5jdGlvbiBpcyBjYWxsZWQgdmlhIHRoZSBuZXdfb2JqZmlsZSBvYnNl cnZlci4gICovCisKIHN0YXRpYyB2b2lkCiB0aHJlYWRfZGJfbmV3X29iamZp bGUgKHN0cnVjdCBvYmpmaWxlICpvYmpmaWxlKQogewogICAvKiBUaGlzIG9i c2VydmVyIG11c3QgYWx3YXlzIGJlIGNhbGxlZCB3aXRoIGluZmVyaW9yX3B0 aWQgc2V0CiAgICAgIGNvcnJlY3RseS4gICovCiAKLSAgaWYgKG9iamZpbGUg IT0gTlVMTCkKKyAgaWYgKG9iamZpbGUgIT0gTlVMTAorICAgICAgLyogT25s eSBjaGVjayBmb3IgdGhyZWFkX2RiIGlmIHdlIGxvYWRlZCBsaWJwdGhyZWFk LgorCSBGb3IgZHluYW1pY2FsbHkgbGlua2VkIGV4ZWN1dGFibGVzLCBsaWJw dGhyZWFkIGNhbiBiZSBuZWFyIHRoZSBlbmQKKwkgb2YgdGhlIGxpc3Qgb2Yg c2hhcmVkIGxpYnJhcmllcyB0byBsb2FkLCBhbmQgaW4gYW4gYXBwIG9mIHNl dmVyYWwKKwkgdGhvdXNhbmQgc2hhcmVkIGxpYnJhcmllcywgdGhpcyBjYW4g b3RoZXJ3aXNlIGJlIHBhaW5mdWwuICAqLworICAgICAgJiYgbGlicHRocmVh ZF9uYW1lX3AgKG9iamZpbGUtPm5hbWUpKQogICAgIGNoZWNrX2Zvcl90aHJl YWRfZGIgKCk7CiB9CiAKKy8qIFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIHZp YSB0aGUgaW5mZXJpb3JfY3JlYXRlZCBvYnNlcnZlci4KKyAgIFRoaXMgaGFu ZGxlcyB0aGUgY2FzZSBvZiBkZWJ1Z2dpbmcgc3RhdGljYWxseSBsaW5rZWQg ZXhlY3V0YWJsZXMuICAqLworCitzdGF0aWMgdm9pZAordGhyZWFkX2RiX2lu ZmVyaW9yX2NyZWF0ZWQgKHN0cnVjdCB0YXJnZXRfb3BzICp0YXJnZXQsIGlu dCBmcm9tX3R0eSkKK3sKKyAgY2hlY2tfZm9yX3RocmVhZF9kYiAoKTsKK30K KwogLyogQXR0YWNoIHRvIGEgbmV3IHRocmVhZC4gIFRoaXMgZnVuY3Rpb24g aXMgY2FsbGVkIHdoZW4gd2UgcmVjZWl2ZSBhCiAgICBURF9DUkVBVEUgZXZl bnQgb3Igd2hlbiB3ZSBpdGVyYXRlIG92ZXIgYWxsIHRocmVhZHMgYW5kIGZp bmQgb25lCiAgICB0aGF0IHdhc24ndCBhbHJlYWR5IGluIG91ciBsaXN0LiAg UmV0dXJucyB0cnVlIG9uIHN1Y2Nlc3MuICAqLwpAQCAtMTg0NSw0ICsxODYx LDkgQEAgV2hlbiBub24temVybywgbGlidGhyZWFkLWRiIGRlYnVnZ2luZyBp cwogCiAgIC8qIEFkZCBvdXJzZWx2ZXMgdG8gb2JqZmlsZSBldmVudCBjaGFp bi4gICovCiAgIG9ic2VydmVyX2F0dGFjaF9uZXdfb2JqZmlsZSAodGhyZWFk X2RiX25ld19vYmpmaWxlKTsKKworICAvKiBBZGQgb3Vyc2VsdmVzIHRvIGlu ZmVyaW9yX2NyZWF0ZWQgZXZlbnQgY2hhaW4uCisgICAgIFRoaXMgaXMgbmVl ZGVkIHRvIGhhbmRsZSBkZWJ1Z2dpbmcgc3RhdGljYWxseSBsaW5rZWQgcHJv Z3JhbXMgd2hlcmUKKyAgICAgdGhlIG5ld19vYmpmaWxlIG9ic2VydmVyIHdv bid0IGdldCBjYWxsZWQgZm9yIGxpYnB0aHJlYWQuICAqLworICBvYnNlcnZl cl9hdHRhY2hfaW5mZXJpb3JfY3JlYXRlZCAodGhyZWFkX2RiX2luZmVyaW9y X2NyZWF0ZWQpOwogfQo= --20cf303b3a915e7ec104aeeaad8f--