Re: [PATCH v5 1/5] Implemement support for groups of syscalls in the xml-syscall interface.

[Doug Evans <dje@google.com>]

On Tue, May 17, 2016 at 7:34 PM, Gabriel Krisman Bertazi
<gabriel@krisman.be> wrote:
> Doug Evans <dje@google.com> writes:
>
> Hi Doug, thanks for your review.  I'm fixing the things you pointed out
> and should submit a new version tomorrow.
>
>>  > diff --git a/gdb/syscalls/gdb-syscalls.dtd
>> b/gdb/syscalls/gdb-syscalls.dtd
>>  > index 3deda12..de47d4d 100644
>>  > --- a/gdb/syscalls/gdb-syscalls.dtd
>>  > +++ b/gdb/syscalls/gdb-syscalls.dtd
>>  > @@ -11,4 +11,5 @@
>>  >  <!ELEMENT syscall         EMPTY>
>>  >  <!ATTLIST syscall
>>  >    name                    CDATA   #REQUIRED
>>  > -  number                  CDATA   #REQUIRED>
>>  > +  number                  CDATA   #REQUIRED
>>  > +  groups                  CDATA   #IMPLIED>
>>
>> I'm assuming "IMPLIED" is ok here, I don't actually know.
>
> According to the xml spec, there are two possible 'ID Attribute Default'
> values for an element: #REQUIRED and #IMPLIED. The spec says:
>
> "In an attribute declaration, #REQUIRED means that the attribute MUST
> always be provided, #IMPLIED that no default value is provided."
>
> Which makes me think that #IMPLIED is the correct value for this field.

Fine by me.
Thanks.