Re: [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME

Doug Evans
2014-01-22T04:41:49Z

On Tue, Jan 21, 2014 at 2:36 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello,
>
> While looking at this macro, I noticed that it wasn't always necessarily
> defined. That prompted me to search the current sources to make sure
> that all uses were adequately protected, which they were. But to help
> prevent future uses to be made unprotected, this patch expands the
> current macro documentation a bit.
>
> gdb/ChangeLog:
>
> * common/common-utils.h (FUNCTION_NAME): Expand the macro's
> documentation a bit.
>
> I would commit on its own, but since I am going to put the next in
> for the same macro up for review, it's just as easy to make that one
> wait as well, in case there are comments.

Yeah, I stumbled a bit on this myself.
It's not clear to me whether not defining it or defining it as NULL
(and update all current users to deal with that) is better but I went
with keeping things as they are.