Re: [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h

Doug Evans
2014-01-22T04:44:43Z

On Tue, Jan 21, 2014 at 2:36 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello,
>
> The ARI script flagged the use of the __func__ variable, which
> is normally not allowed (not defined in C90). However, this particular
> use is OK, as the reference is only made when __STDC_VERSION__ >=
> 199901L. So, add an "ARI:" comment to explicitly OK this use.
>
> gdb/ChangeLog:
>
> * common/common-utils.h: Add "ARI:" comment besides __func__
> reference.
>
> OK to commit?

Fine by me.

English nit: "... comment beside __func__ reference".

I wonder though how ARI handled gdb_assert.h (where FUNCTION_NAME
originates from).