From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: GDB 7.4 --with-python doesn't like d:/foo/bar
Date: Fri, 27 Jan 2012 19:01:00 -0000 [thread overview]
Message-ID: <CADPb22R1Fp7zjbkhyGx6jiX5V1Z-gPDeFXCmAuxAq6fE8ffyJA@mail.gmail.com> (raw)
In-Reply-To: <20120127102813.GZ31383@adacore.com>
On Fri, Jan 27, 2012 at 2:28 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> This is a standard way of Autoconf's catering to DOS and Windows
>> platforms. You can see it at work elsewhere in the configure script,
>> because it's part of AC_PROG_PATH. In fact, you can find it just a
>> few lines below the test that failed.
>
> You're right. I wasn't thinking clearly in the morning. For some
> reason, I was seeing both expressions as equivalent, when clearly
> they are not! So your proposed change is on the table instead.
Hi.
I copied over the same test that autoconf uses and committed that.
[ref: autoconf 2.64, programs.m4, _AC_PATH_PROG]
Tested with an absolute path on amd64-linux.
2012-01-27 Doug Evans <dje@google.com>
* configure.ac (with_python): Fix absolute path handling for win32.
* configure: Regenerate.
Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/configure,v
retrieving revision 1.341
diff -u -p -r1.341 configure
--- configure 20 Jan 2012 09:47:32 -0000 1.341
+++ configure 27 Jan 2012 18:20:21 -0000
@@ -10814,7 +10814,7 @@ $as_echo "$as_me: WARNING: python suppor
have_libpython=no
else
case "${with_python}" in
- /*)
+ [\\/]* | ?:[\\/]*)
if test -d ${with_python}; then
# Assume the python binary is ${with_python}/bin/python.
python_prog="${with_python}/bin/python"
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.156
diff -u -p -r1.156 configure.ac
--- configure.ac 20 Jan 2012 09:47:32 -0000 1.156
+++ configure.ac 27 Jan 2012 18:20:21 -0000
@@ -734,7 +734,7 @@ if test "${with_python}" = no; then
have_libpython=no
else
case "${with_python}" in
- /*)
+ [[\\/]]* | ?:[[\\/]]*)
if test -d ${with_python}; then
# Assume the python binary is ${with_python}/bin/python.
python_prog="${with_python}/bin/python"
next prev parent reply other threads:[~2012-01-27 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 7:31 Eli Zaretskii
2012-01-27 5:34 ` Joel Brobecker
2012-01-27 10:02 ` Eli Zaretskii
2012-01-27 11:49 ` Joel Brobecker
2012-01-27 19:01 ` Doug Evans [this message]
2012-01-27 20:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22R1Fp7zjbkhyGx6jiX5V1Z-gPDeFXCmAuxAq6fE8ffyJA@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox