Re: [patch] for mig check in GDB's configure

Joel Brobecker
2013-05-17T05:30:57Z

Hi Thomas and Yue,

> After reviewing and testing it, I now checked in your patch (very minor
> coding style and wording changes). Congratulations to your first
> contribution! :-)
>
> 2013-05-16 Yue Lu <hacklu.newborn@gmail.com>
>
> * configure.ac: Ensure MIG is available when building for GNU Hurd
> hosts.
> * configure: Regenerate.

I cannot remember if we said Yue had a copyright assignment on file,
or not. I checked the file, and couldn't locate him. Can you clarify?

This patch is small enough that it can be accepted without regardless;
but if we do, I'd like to mark it as such in the ChangeLog entry
(using "(tiny change)", as mentioned by the guide for GNU maintainers).

Thank you!

>
> Index: configure.ac
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.ac,v
> retrieving revision 1.203
> diff -u -p -r1.203 configure.ac
> --- configure.ac 10 May 2013 16:10:40 -0000 1.203
> +++ configure.ac 16 May 2013 21:50:18 -0000
> @@ -486,8 +486,15 @@ AC_CHECK_TOOL(AR, ar)
> AC_CHECK_TOOL(DLLTOOL, dlltool)
> AC_CHECK_TOOL(WINDRES, windres)
>
> -# Needed for GNU/Hurd.
> -AC_CHECK_TOOL(MIG, mig)
> +case $host_os in
> + gnu*)
> + # Needed for GNU Hurd hosts.
> + AC_CHECK_TOOL(MIG, mig)
> + if test x"$MIG" = x; then
> + AC_MSG_ERROR([MIG not found but required for $host hosts])
> + fi
> + ;;
> +esac
>
> # ---------------------- #
> # Checks for libraries. #
> Index: configure
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure,v
> retrieving revision 1.391
> diff -u -p -r1.391 configure
> --- configure 10 May 2013 16:10:40 -0000 1.391
> +++ configure 16 May 2013 21:50:20 -0000
> [...]
>
>
> GrÃ¼ÃŸe,
> Thomas

--
Joel