From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31587 invoked by alias); 11 Nov 2011 00:46:34 -0000 Received: (qmail 31576 invoked by uid 22791); 11 Nov 2011 00:46:33 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Nov 2011 00:46:20 +0000 Received: by vcbfo11 with SMTP id fo11so2231725vcb.0 for ; Thu, 10 Nov 2011 16:46:19 -0800 (PST) Received: by 10.220.153.69 with SMTP id j5mr1143868vcw.186.1320972379234; Thu, 10 Nov 2011 16:46:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.153.69 with SMTP id j5mr1143863vcw.186.1320972379115; Thu, 10 Nov 2011 16:46:19 -0800 (PST) Received: by 10.220.171.70 with HTTP; Thu, 10 Nov 2011 16:46:18 -0800 (PST) In-Reply-To: References: <20111107063715.554F5246194@ruffy.mtv.corp.google.com> Date: Fri, 11 Nov 2011 00:46:00 -0000 Message-ID: Subject: Re: [patch] Avoid computing fullname if unused. From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=f46d043c7ca66a50d404b16ad913 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00301.txt.bz2 --f46d043c7ca66a50d404b16ad913 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1736 On Mon, Nov 7, 2011 at 6:48 AM, Tom Tromey wrote: >>>>>> "Doug" =3D=3D Doug Evans writes: > > Doug> 2011-11-06 =A0Doug Evans =A0 > Doug> =A0 * dwarf2read.c (dw2_map_symbol_filenames): New parameter > Doug> =A0 `need_fullname'. > Doug> =A0 * psymtab.c (map_symbol_filenames_psymtab): Ditto. > Doug> =A0 (map_partial_symbol_filenames): Ditto. =A0All callers updated. > Doug> =A0 * psymtab.h (map_partial_symbol_filenames): Update prototype. > Doug> =A0 * symfile.h (struct quick_symbol_functions, map_symbol_filename= s): New > Doug> =A0 parameter need_fullname. > > Seems reasonable to me. > > Ideally these could be computed lazily, but that is a bit of a pain in C. > > Doug> + =A0map_partial_symbol_filenames (print_partial_file_name, NULL, > Doug> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 TRUE /*need_fulln= ame*/); > > I don't think TRUE and FALSE are really part of the gdb style. > gdb tends to just use 0/1 for this. > I'd like us to follow gcc and use 'bool', 'true', and 'false' -- but not > these all-caps spellings. TRUE,FALSE are already used in places and my thinking was it's easy to do a mass search-n-replace when the time comes. [Easier than 0,1. :-)] But I went with 0,1 - they are more prevalent. Committed. 2011-11-10 Doug Evans * dwarf2read.c (dw2_map_symbol_filenames): New parameter `need_fullname'. * psymtab.c (map_symbol_filenames_psymtab): Ditto. (map_partial_symbol_filenames): Ditto. All callers updated. * psymtab.h (map_partial_symbol_filenames): Update prototype. * symfile.h (struct quick_symbol_functions, map_symbol_filenames): = New parameter need_fullname. --f46d043c7ca66a50d404b16ad913 Content-Type: text/plain; charset=US-ASCII; name="gdb-111110-need-fullname-2.patch.txt" Content-Disposition: attachment; filename="gdb-111110-need-fullname-2.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_guugu5zn0 Content-length: 7922 MjAxMS0xMS0xMCAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog ZHdhcmYycmVhZC5jIChkdzJfbWFwX3N5bWJvbF9maWxlbmFtZXMpOiBOZXcg cGFyYW1ldGVyCglgbmVlZF9mdWxsbmFtZScuCgkqIHBzeW10YWIuYyAobWFw X3N5bWJvbF9maWxlbmFtZXNfcHN5bXRhYik6IERpdHRvLgoJKG1hcF9wYXJ0 aWFsX3N5bWJvbF9maWxlbmFtZXMpOiBEaXR0by4gIEFsbCBjYWxsZXJzIHVw ZGF0ZWQuCgkqIHBzeW10YWIuaCAobWFwX3BhcnRpYWxfc3ltYm9sX2ZpbGVu YW1lcyk6IFVwZGF0ZSBwcm90b3R5cGUuCgkqIHN5bWZpbGUuaCAoc3RydWN0 IHF1aWNrX3N5bWJvbF9mdW5jdGlvbnMsIG1hcF9zeW1ib2xfZmlsZW5hbWVz KTogTmV3CglwYXJhbWV0ZXIgbmVlZF9mdWxsbmFtZS4KCkluZGV4OiBkd2Fy ZjJyZWFkLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2 cy9zcmMvc3JjL2dkYi9kd2FyZjJyZWFkLmMsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuNTc5CmRpZmYgLXUgLXAgLXIxLjU3OSBkd2FyZjJyZWFkLmMKLS0t IGR3YXJmMnJlYWQuYwkxMCBOb3YgMjAxMSAyMDoyMToyNyAtMDAwMAkxLjU3 OQorKysgZHdhcmYycmVhZC5jCTExIE5vdiAyMDExIDAwOjE4OjE0IC0wMDAw CkBAIC0yODExLDcgKzI4MTEsNyBAQCBkdzJfZmluZF9wY19zZWN0X3N5bXRh YiAoc3RydWN0IG9iamZpbGUgCiAKIHN0YXRpYyB2b2lkCiBkdzJfbWFwX3N5 bWJvbF9maWxlbmFtZXMgKHN0cnVjdCBvYmpmaWxlICpvYmpmaWxlLCBzeW1i b2xfZmlsZW5hbWVfZnR5cGUgKmZ1biwKLQkJCSAgdm9pZCAqZGF0YSkKKwkJ CSAgdm9pZCAqZGF0YSwgaW50IG5lZWRfZnVsbG5hbWUpCiB7CiAgIGludCBp OwogCkBAIC0yODMzLDggKzI4MzMsMTIgQEAgZHcyX21hcF9zeW1ib2xfZmls ZW5hbWVzIChzdHJ1Y3Qgb2JqZmlsZQogCiAgICAgICBmb3IgKGogPSAwOyBq IDwgZmlsZV9kYXRhLT5udW1fZmlsZV9uYW1lczsgKytqKQogCXsKLQkgIGNv bnN0IGNoYXIgKnRoaXNfcmVhbF9uYW1lID0gZHcyX2dldF9yZWFsX3BhdGgg KG9iamZpbGUsIGZpbGVfZGF0YSwKLQkJCQkJCQkgIGopOworCSAgY29uc3Qg Y2hhciAqdGhpc19yZWFsX25hbWU7CisKKwkgIGlmIChuZWVkX2Z1bGxuYW1l KQorCSAgICB0aGlzX3JlYWxfbmFtZSA9IGR3Ml9nZXRfcmVhbF9wYXRoIChv YmpmaWxlLCBmaWxlX2RhdGEsIGopOworCSAgZWxzZQorCSAgICB0aGlzX3Jl YWxfbmFtZSA9IE5VTEw7CiAJICAoKmZ1bikgKGZpbGVfZGF0YS0+ZmlsZV9u YW1lc1tqXSwgdGhpc19yZWFsX25hbWUsIGRhdGEpOwogCX0KICAgICB9Cklu ZGV4OiBwc3ltdGFiLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9zcmMvc3JjL2dkYi9wc3ltdGFiLmMsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuMzIKZGlmZiAtdSAtcCAtcjEuMzIgcHN5bXRhYi5jCi0tLSBw c3ltdGFiLmMJMTAgTm92IDIwMTEgMjI6MTQ6MTYgLTAwMDAJMS4zMgorKysg cHN5bXRhYi5jCTExIE5vdiAyMDExIDAwOjE4OjE0IC0wMDAwCkBAIC0xMDgy LDcgKzEwODIsOCBAQCByZWFkX3BzeW10YWJzX3dpdGhfZmlsZW5hbWUgKHN0 cnVjdCBvYmpmCiAKIHN0YXRpYyB2b2lkCiBtYXBfc3ltYm9sX2ZpbGVuYW1l c19wc3ltdGFiIChzdHJ1Y3Qgb2JqZmlsZSAqb2JqZmlsZSwKLQkJCSAgICAg IHN5bWJvbF9maWxlbmFtZV9mdHlwZSAqZnVuLCB2b2lkICpkYXRhKQorCQkJ ICAgICAgc3ltYm9sX2ZpbGVuYW1lX2Z0eXBlICpmdW4sIHZvaWQgKmRhdGEs CisJCQkgICAgICBpbnQgbmVlZF9mdWxsbmFtZSkKIHsKICAgc3RydWN0IHBh cnRpYWxfc3ltdGFiICpwczsKIApAQCAtMTA5NCw3ICsxMDk1LDEwIEBAIG1h cF9zeW1ib2xfZmlsZW5hbWVzX3BzeW10YWIgKHN0cnVjdCBvYmoKIAljb250 aW51ZTsKIAogICAgICAgUVVJVDsKLSAgICAgIGZ1bGxuYW1lID0gcHN5bXRh Yl90b19mdWxsbmFtZSAocHMpOworICAgICAgaWYgKG5lZWRfZnVsbG5hbWUp CisJZnVsbG5hbWUgPSBwc3ltdGFiX3RvX2Z1bGxuYW1lIChwcyk7CisgICAg ICBlbHNlCisJZnVsbG5hbWUgPSBOVUxMOwogICAgICAgKCpmdW4pIChwcy0+ ZmlsZW5hbWUsIGZ1bGxuYW1lLCBkYXRhKTsKICAgICB9CiB9CkBAIC0xOTIx LDEzICsxOTI1LDE1IEBAIGV4cGFuZF9wYXJ0aWFsX3N5bWJvbF9uYW1lcyAo aW50ICgqZnVuKSAKIH0KIAogdm9pZAotbWFwX3BhcnRpYWxfc3ltYm9sX2Zp bGVuYW1lcyAoc3ltYm9sX2ZpbGVuYW1lX2Z0eXBlICpmdW4sIHZvaWQgKmRh dGEpCittYXBfcGFydGlhbF9zeW1ib2xfZmlsZW5hbWVzIChzeW1ib2xfZmls ZW5hbWVfZnR5cGUgKmZ1biwgdm9pZCAqZGF0YSwKKwkJCSAgICAgIGludCBu ZWVkX2Z1bGxuYW1lKQogewogICBzdHJ1Y3Qgb2JqZmlsZSAqb2JqZmlsZTsK IAogICBBTExfT0JKRklMRVMgKG9iamZpbGUpCiAgIHsKICAgICBpZiAob2Jq ZmlsZS0+c2YpCi0gICAgICBvYmpmaWxlLT5zZi0+cWYtPm1hcF9zeW1ib2xf ZmlsZW5hbWVzIChvYmpmaWxlLCBmdW4sIGRhdGEpOworICAgICAgb2JqZmls ZS0+c2YtPnFmLT5tYXBfc3ltYm9sX2ZpbGVuYW1lcyAob2JqZmlsZSwgZnVu LCBkYXRhLAorCQkJCQkgICAgIG5lZWRfZnVsbG5hbWUpOwogICB9CiB9Cklu ZGV4OiBwc3ltdGFiLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9zcmMvc3JjL2dkYi9wc3ltdGFiLmgsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuOApkaWZmIC11IC1wIC1yMS44IHBzeW10YWIuaAotLS0gcHN5 bXRhYi5oCTEwIEp1biAyMDExIDIxOjQ4OjA0IC0wMDAwCTEuOAorKysgcHN5 bXRhYi5oCTExIE5vdiAyMDExIDAwOjE4OjE0IC0wMDAwCkBAIC0zMyw3ICsz Myw4IEBAIGV4dGVybiBzdHJ1Y3QgYmNhY2hlICpwc3ltYm9sX2JjYWNoZV9n ZXQKIHZvaWQgZXhwYW5kX3BhcnRpYWxfc3ltYm9sX25hbWVzIChpbnQgKCpm dW4pIChjb25zdCBjaGFyICosIHZvaWQgKiksCiAJCQkJICB2b2lkICpkYXRh KTsKIAotdm9pZCBtYXBfcGFydGlhbF9zeW1ib2xfZmlsZW5hbWVzIChzeW1i b2xfZmlsZW5hbWVfZnR5cGUgKmZ1biwgdm9pZCAqZGF0YSk7Cit2b2lkIG1h cF9wYXJ0aWFsX3N5bWJvbF9maWxlbmFtZXMgKHN5bWJvbF9maWxlbmFtZV9m dHlwZSAqZnVuLCB2b2lkICpkYXRhLAorCQkJCSAgIGludCBuZWVkX2Z1bGxu YW1lKTsKIAogZXh0ZXJuIGNvbnN0IHN0cnVjdCBxdWlja19zeW1ib2xfZnVu Y3Rpb25zIHBzeW1fZnVuY3Rpb25zOwogCkluZGV4OiBzeW1maWxlLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dk Yi9zeW1maWxlLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOTYKZGlmZiAt dSAtcCAtcjEuOTYgc3ltZmlsZS5oCi0tLSBzeW1maWxlLmgJOSBPY3QgMjAx MSAxODozNzoyNyAtMDAwMAkxLjk2CisrKyBzeW1maWxlLmgJMTEgTm92IDIw MTEgMDA6MTg6MTQgLTAwMDAKQEAgLTI4OSw5ICsyODksMTEgQEAgc3RydWN0 IHF1aWNrX3N5bWJvbF9mdW5jdGlvbnMKIAogICAvKiBDYWxsIGEgY2FsbGJh Y2sgZm9yIGV2ZXJ5IGZpbGUgZGVmaW5lZCBpbiBPQkpGSUxFIHdob3NlIHN5 bXRhYiBpcwogICAgICBub3QgYWxyZWFkeSByZWFkIGluLiAgRlVOIGlzIHRo ZSBjYWxsYmFjay4gIEl0IGlzIHBhc3NlZCB0aGUgZmlsZSdzCi0gICAgIEZJ TEVOQU1FLCB0aGUgZmlsZSdzIEZVTExOQU1FLCBhbmQgdGhlIERBVEEgcGFz c2VkIHRvIHRoaXMgZnVuY3Rpb24uICAqLworICAgICBGSUxFTkFNRSwgdGhl IGZpbGUncyBGVUxMTkFNRSAoaWYgbmVlZF9mdWxsbmFtZSBpcyBub24temVy byksIGFuZAorICAgICB0aGUgREFUQSBwYXNzZWQgdG8gdGhpcyBmdW5jdGlv bi4gICovCiAgIHZvaWQgKCptYXBfc3ltYm9sX2ZpbGVuYW1lcykgKHN0cnVj dCBvYmpmaWxlICpvYmpmaWxlLAotCQkJCXN5bWJvbF9maWxlbmFtZV9mdHlw ZSAqZnVuLCB2b2lkICpkYXRhKTsKKwkJCQlzeW1ib2xfZmlsZW5hbWVfZnR5 cGUgKmZ1biwgdm9pZCAqZGF0YSwKKwkJCQlpbnQgbmVlZF9mdWxsbmFtZSk7 CiB9OwogCiAvKiBTdHJ1Y3R1cmUgdG8ga2VlcCB0cmFjayBvZiBzeW1ib2wg cmVhZGluZyBmdW5jdGlvbnMgZm9yIHZhcmlvdXMKSW5kZXg6IHN5bXRhYi5j Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3Ny Yy9nZGIvc3ltdGFiLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjg1CmRp ZmYgLXUgLXAgLXIxLjI4NSBzeW10YWIuYwotLS0gc3ltdGFiLmMJMjkgT2N0 IDIwMTEgMDc6MjY6MDcgLTAwMDAJMS4yODUKKysrIHN5bXRhYi5jCTExIE5v diAyMDExIDAwOjE4OjE0IC0wMDAwCkBAIC0yODgxLDcgKzI4ODEsOCBAQCBz b3VyY2VzX2luZm8gKGNoYXIgKmlnbm9yZSwgaW50IGZyb21fdHR5CiAJCSAg ICJ3aWxsIGJlIHJlYWQgaW4gb24gZGVtYW5kOlxuXG4iKTsKIAogICBmaXJz dCA9IDE7Ci0gIG1hcF9wYXJ0aWFsX3N5bWJvbF9maWxlbmFtZXMgKG91dHB1 dF9wYXJ0aWFsX3N5bWJvbF9maWxlbmFtZSwgJmZpcnN0KTsKKyAgbWFwX3Bh cnRpYWxfc3ltYm9sX2ZpbGVuYW1lcyAob3V0cHV0X3BhcnRpYWxfc3ltYm9s X2ZpbGVuYW1lLCAmZmlyc3QsCisJCQkJMSAvKm5lZWRfZnVsbG5hbWUqLyk7 CiAgIHByaW50Zl9maWx0ZXJlZCAoIlxuIik7CiB9CiAKQEAgLTQzMTQsNyAr NDMxNSw4IEBAIG1ha2Vfc291cmNlX2ZpbGVzX2NvbXBsZXRpb25fbGlzdCAo Y2hhciAKICAgZGF0dW0ubGlzdCA9ICZsaXN0OwogICBkYXR1bS5saXN0X3Vz ZWQgPSAmbGlzdF91c2VkOwogICBkYXR1bS5saXN0X2FsbG9jZWQgPSAmbGlz dF9hbGxvY2VkOwotICBtYXBfcGFydGlhbF9zeW1ib2xfZmlsZW5hbWVzICht YXliZV9hZGRfcGFydGlhbF9zeW10YWJfZmlsZW5hbWUsICZkYXR1bSk7Cisg IG1hcF9wYXJ0aWFsX3N5bWJvbF9maWxlbmFtZXMgKG1heWJlX2FkZF9wYXJ0 aWFsX3N5bXRhYl9maWxlbmFtZSwgJmRhdHVtLAorCQkJCTAgLypuZWVkX2Z1 bGxuYW1lKi8pOwogICBkaXNjYXJkX2NsZWFudXBzIChiYWNrX3RvKTsKIAog ICByZXR1cm4gbGlzdDsKSW5kZXg6IG1pL21pLWNtZC1maWxlLmMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9t aS9taS1jbWQtZmlsZS5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE2CmRp ZmYgLXUgLXAgLXIxLjE2IG1pLWNtZC1maWxlLmMKLS0tIG1pL21pLWNtZC1m aWxlLmMJNCBBdWcgMjAxMSAxOToxMDoxNCAtMDAwMAkxLjE2CisrKyBtaS9t aS1jbWQtZmlsZS5jCTExIE5vdiAyMDExIDAwOjE4OjE0IC0wMDAwCkBAIC0x MDksNyArMTA5LDggQEAgbWlfY21kX2ZpbGVfbGlzdF9leGVjX3NvdXJjZV9m aWxlcyAoY2hhcgogICAgIHVpX291dF9lbmQgKHVpb3V0LCB1aV9vdXRfdHlw ZV90dXBsZSk7CiAgIH0KIAotICBtYXBfcGFydGlhbF9zeW1ib2xfZmlsZW5h bWVzIChwcmludF9wYXJ0aWFsX2ZpbGVfbmFtZSwgTlVMTCk7CisgIG1hcF9w YXJ0aWFsX3N5bWJvbF9maWxlbmFtZXMgKHByaW50X3BhcnRpYWxfZmlsZV9u YW1lLCBOVUxMLAorCQkJCTEgLypuZWVkX2Z1bGxuYW1lKi8pOwogCiAgIHVp X291dF9lbmQgKHVpb3V0LCB1aV9vdXRfdHlwZV9saXN0KTsKIH0K --f46d043c7ca66a50d404b16ad913--