From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5907 invoked by alias); 18 Apr 2012 14:02:39 -0000 Received: (qmail 5888 invoked by uid 22791); 18 Apr 2012 14:02:37 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 14:02:23 +0000 Received: by vcbfk14 with SMTP id fk14so6119633vcb.0 for ; Wed, 18 Apr 2012 07:02:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=V3jpexirfiyJfn9jlrAlAXfi/W4+Ul+oHkxUtitdSY0=; b=Q5ZXxIrFLKHgJMJYrtCYpK9SIYPORmiXSUKEQMbM0ljpruYwAkHJKLFyhPKTSdy3P5 r+gUx2cti277/P4zNV3c38OvGcp78T6MAvAhhlRhc+bK/fplaPXnYvxd4WXeP7t8/V7/ w750szWSeLzC4ZjEq/iTjhsMAk7d1pRYBzec7kNkeZRlevQZhdkUcbuiBpXYEDSTv7Us FRdkzpmglaZKmiz+sbddb7naJqPW8g/mOEKHGulQsB5ZNV7OOhzEMvzGPiWkfwC2MoMW UYwweHS2DnONQTc1CikRJeGPHrySp9169dh1oYpWyhXkD27oSwB5iS/TcYgNLxZONqRY F3hw== Received: by 10.52.22.107 with SMTP id c11mr969416vdf.115.1334757742981; Wed, 18 Apr 2012 07:02:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.22.107 with SMTP id c11mr969405vdf.115.1334757742861; Wed, 18 Apr 2012 07:02:22 -0700 (PDT) Received: by 10.220.115.78 with HTTP; Wed, 18 Apr 2012 07:02:22 -0700 (PDT) In-Reply-To: <4F8E88E3.1010900@redhat.com> References: <20120416144011.GH2852@adacore.com> <4F8C3350.1030601@redhat.com> <4F8E88E3.1010900@redhat.com> Date: Wed, 18 Apr 2012 14:14:00 -0000 Message-ID: Subject: Re: [RFA] Ensure result of make_cleanup is never NULL. From: Doug Evans To: Pedro Alves Cc: Joel Brobecker , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQm3dS7yt2eC6F31s3qD4RR2lAzF092g1nt9Z/jFqs+soaSROXlKDivlyBTFoFXRoKr6MPjemCaOG7V0agWN38JqcWTqnbq4AH0DPDTxBHEFq3RfE0CyGPkPVbgI4oQ/I2diKrQLIxYI1KBcYgwYR+usPUN4aA== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00568.txt.bz2 On Wed, Apr 18, 2012 at 2:26 AM, Pedro Alves wrote: > On 04/18/2012 01:43 AM, Doug Evans wrote: > >> btw, I thought about making cleanup_sentinel const here, for a bit of >> extra robustness. > > > Won't that mean you'd need to cast the constness out in most, if > not all places that use it? --- cleanups.c= 2012-04-17 12:02:38.000000000 -0700 +++ cleanups.c 2012-04-18 06:59:46.000000000 -0700 @@ -50,10 +50,10 @@ struct cleanup [though this won't catch errors that a value of, say, ((struct cleanup *) -1) will] - displays as something useful when printed in gdb. */ -static struct cleanup cleanup_sentinel; +static const struct cleanup cleanup_sentinel; /* Handy macro to use when referring to cleanup_sentinel. */ -#define CLEANUP_SENTINEL (&cleanup_sentinel) +#define CLEANUP_SENTINEL ((struct cleanup *) &cleanup_sentinel) /* Chain of cleanup actions established with make_cleanup, to be executed if an error happens. */