From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20095 invoked by alias); 27 Jul 2013 17:57:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20077 invoked by uid 89); 27 Jul 2013 17:57:47 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-oa0-f52.google.com) (209.85.219.52) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 27 Jul 2013 17:57:46 +0000 Received: by mail-oa0-f52.google.com with SMTP id g12so9904672oah.39 for ; Sat, 27 Jul 2013 10:57:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=LL5PRS0GxrPlaIp5hpgQm6BpatQ5DbaB4i/w1xDF3Ig=; b=VfIEsJtS3uy/Kb3fdx+uavLhn0SPR4tK99sr9HHTmjlUVifpq56AXURrIUFPSkYWof 6z0C858t5o8WCFBoTqoahbuXWmgCr3rkrukkPz95TbrBk+AUTatAoow3cc9QOUS3Hhbm sckV0I4jYFkzErKhV+HDljmdUWw0oSC3n05I7rjtp98KMYxkdqxF1yeVmcMjcBJD4RiH xQ9Lph1k1uoSrmfHfBocWPiZYrH8ziRErvsU6pWXy+t2sWhq2eHD/u8ei9IVN2Kv8dZv EhG8ofz4lr6eZa0twyaW++P2TFGerCTmaV/1UIBwFr9SND5iT7gJlWJi8S3Tnw8iLXKK bCow== MIME-Version: 1.0 X-Received: by 10.50.7.1 with SMTP id f1mr344298iga.48.1374947859087; Sat, 27 Jul 2013 10:57:39 -0700 (PDT) Received: by 10.64.239.148 with HTTP; Sat, 27 Jul 2013 10:57:38 -0700 (PDT) In-Reply-To: <1374869594-16965-1-git-send-email-sergiodj@redhat.com> References: <1374869594-16965-1-git-send-email-sergiodj@redhat.com> Date: Sat, 27 Jul 2013 17:57:00 -0000 Message-ID: Subject: Re: [PATCH 0/7] Implement gdbarch_gdb_signal_{to,from}_target From: Doug Evans To: Sergio Durigan Junior Cc: GDB Patches , Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnmlc9FKn5XzXBf1WvnHpDgWjz7Fk4FmcrldVDs1HTn89OJTDpT89Gpovgxusk7N0owES2Hd/6+dYYrArfzXiB8RYJA/hRh9pXow5jIrBO9yZBFsSL7kVvkifHJj95ek3ocIC/ZABxvD3OX6hs+fhD15PkTDz7qzv3kykkTIHPkYLXXVrjs2xH5TskJJn78GSrzPAQeYUMHxntPXl7GrAGCb4FuNA== X-SW-Source: 2013-07/txt/msg00664.txt.bz2 On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior wrote: > This is the second attempt to implement gdbarch_gdb_signal_to_target, > but this time with the additional implementation of > gdbarch_gdb_signal_from_target (a MIPS-only method so far). > > The first attempt is here: > > > > The notable changes are: > > - linux-tdep.c now registers the generic converters itself, thus > eliminating the need for every target to do so. > > - Comment about SIGSWI on ARM (discussion here: > ). > > - Rewrite MIPS implementation of gdbarch_gdb_signal_from_target. > Remove "enum mips_signals". > > Hopefully everything is right now. If the patch is approved, I intend > to commit it as a whole, instead of each chunk separately. > > Thanks. Hi. I reviewed all the patches. Except for a few nits pointed out in some of the patches, the set is ok with me. As a sanity check, did you do an enable-targets=all build? [modulo I didn't audit the signal lists and values] Also, you may wish to leave it a few days in case others wish to comment. I gather there is a use for gdbarch_gdb_signal_to_target coming, so no worries there. In older times one couldn't use "signal" as a variable name to avoid a possible collision with a system header defining a macro signal. I see record-full.c uses "signal" so perhaps we no longer have to deal with that, but heads up. [fwiw, and this is just a side discussion, not meant to block the patch or anything ... This is an example of the kind of thing that I wish existed in a library anyone could use. Yeah, we're converting to/from GDB_FOO, but I can imagine it being useful to multiple tools.]