From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18268 invoked by alias); 8 Oct 2014 05:58:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18256 invoked by uid 89); 8 Oct 2014 05:58:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 08 Oct 2014 05:58:34 +0000 Received: by mail-vc0-f174.google.com with SMTP id hq12so6122551vcb.33 for ; Tue, 07 Oct 2014 22:58:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=vbQUd90jzLygTgHPoH088RrzmUBr4q1QM1txsPeiWsQ=; b=XAhPzvTTVXbRbGUyE+acNARddeRuQSTwYnwBkrkIkAdmyiFQF0s2612mWpC4G30FdE Vj/126Rcimr7pvHPo7XM9QoZyhxzzInUDP+ckZpKbINxK5BICQSZLgNxp9qoSa0jFF7n 6JNUn3ImAOqcvEBfMv75l/BH/FnDKRF8Sk9FWtL9YC1RS0GDGt6WKVXIvCrMyyht114i P9J8SxJwjRYj97EB3i4ReazNZOPnnWO4ciqrVBkjjn24ipPSONuP1fBJHoVZBWvzcowf yccpWQXVe9Sx7xIsjE7SZN4a6ATkJkIN1QQELB/jDXpMYVC8k58S8wEhNgkBCDI9v8yO eZ6w== X-Gm-Message-State: ALoCoQmPV+4qk/aq9Nu4j3v4TJxTM0OBoR4G3W8DaVAC2U/zw21cr+chTUZKSrClR62tnuLXDzjz MIME-Version: 1.0 X-Received: by 10.220.174.20 with SMTP id r20mr7907454vcz.11.1412747911824; Tue, 07 Oct 2014 22:58:31 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Tue, 7 Oct 2014 22:58:31 -0700 (PDT) In-Reply-To: <543300A0.50705@dancol.org> References: <543300A0.50705@dancol.org> Date: Wed, 08 Oct 2014 05:58:00 -0000 Message-ID: Subject: Re: Fix infinite loop in update_enumeration_type_from_children From: Doug Evans To: Daniel Colascione Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00134.txt.bz2 On Mon, Oct 6, 2014 at 4:50 PM, Daniel Colascione wrote: > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c > index 9d0ee13..d324b6d 100644 > --- a/gdb/dwarf2read.c > +++ b/gdb/dwarf2read.c > @@ -13247,12 +13247,16 @@ update_enumeration_type_from_children (struct > die_info *die, > const gdb_byte *bytes; > struct dwarf2_locexpr_baton *baton; > const char *name; > - if (child_die->tag != DW_TAG_enumerator) > + if (child_die->tag != DW_TAG_enumerator) { > + child_die = sibling_die (child_die); > continue; > + } > > attr = dwarf2_attr (child_die, DW_AT_const_value, cu); > - if (attr == NULL) > + if (attr == NULL) { > + child_die = sibling_die (child_die); > continue; > + } > > name = dwarf2_name (child_die, cu); > if (name == NULL) > Thanks for finding this. Changing the loop to a for loop is another way to go, and arguably preferable.