From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21179 invoked by alias); 6 Aug 2014 16:40:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21167 invoked by uid 89); 6 Aug 2014 16:40:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f171.google.com Received: from mail-vc0-f171.google.com (HELO mail-vc0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 06 Aug 2014 16:40:28 +0000 Received: by mail-vc0-f171.google.com with SMTP id hq11so4415982vcb.16 for ; Wed, 06 Aug 2014 09:40:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=n3Zio3BZXx30E7oPetM66Hng6lFDItVF7XQl8Hh+O2E=; b=ICpW3GJssxg8KhCen8rYyGO8MGxBP+dPPF/stEUlZkKu5ClFsVNGEDKEmr/bnJCY+d 7zOd9o0YnbkpVTCexUukFL3B1ekrkup9+un1xEKHFpitBRL1cuKAOxE12yA8QiaQwIev r0d97Y+na5SQ97maBlsQlCj5QoSYnNEiFV1rXOdOHeZ2NNUPtgbXH1J9O5Ex6lR30G9F W/+ckxXeXClMBMWXl8LvGznvxpuTShB9f6Sx43vt3ZwXyHUqCMn5IIFAhBZgOHvZN9g0 KjGOeGk8ky9fP/LkSLX82nVeq8V3F3atT22k6N5ta0ZXDG/CqM4o0+Pzo+EBUvMeWiPV NFhQ== X-Gm-Message-State: ALoCoQkhFSVLucETO/sMRybXvWGvgGe6laXUw2aOSPN7WemBt+pvXO3Dh9yE9uZ9cbv1PLuYl6gc MIME-Version: 1.0 X-Received: by 10.52.78.65 with SMTP id z1mr1887223vdw.67.1407343220077; Wed, 06 Aug 2014 09:40:20 -0700 (PDT) Received: by 10.52.136.203 with HTTP; Wed, 6 Aug 2014 09:40:19 -0700 (PDT) In-Reply-To: <20140806162940.GA14412@blade.nx> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-2-git-send-email-gbenson@redhat.com> <21474.21959.405429.703789@ruffy.mtv.corp.google.com> <20140806162940.GA14412@blade.nx> Date: Wed, 06 Aug 2014 16:40:00 -0000 Message-ID: Subject: Re: [PATCH 01/11 v5] Introduce common/errors.h From: Doug Evans To: Gary Benson Cc: gdb-patches , Pedro Alves , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00098.txt.bz2 On Wed, Aug 6, 2014 at 9:29 AM, Gary Benson wrote: > Doug Evans wrote: >> Gary Benson writes: >> > +#ifdef GDBSERVER >> > +#include "server.h" >> > +#else >> > +#include "defs.h" >> > +#endif >> > +#include "errors.h" >> >> Nit: The introductory email to this patch series didn't mention >> this instance of #ifdef GDBSERVER. Needed? > > It's removed in patch 8 of the series. > It's only here to ensure the series builds at every step. [Sometimes I wonder if we're way too anal in this regard. There's so much work to do, and we bog ourselves down with such pedantic administrivia. Sometimes there's a good reason to have a patch series buildable at each step. But I think the pendulum is tilted far too much towards the pedantic side. /$0.02] No worries though. Thanks for the pointer.