From: Doug Evans <dje@google.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Remove parameter valaddr from c print functions
Date: Thu, 10 Nov 2016 17:54:00 -0000 [thread overview]
Message-ID: <CADPb22QnOOamZA2sQCbUjzkREoEE5djFhsdUV_-qG06HdxPL9g@mail.gmail.com> (raw)
In-Reply-To: <1478789679-30957-1-git-send-email-yao.qi@linaro.org>
On Thu, Nov 10, 2016 at 6:54 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> This patch removes parameter valaddr from some c print functions.
>
> Regression tested on x86_64-linux.
>
> gdb:
>
> 2016-11-10 Yao Qi <yao.qi@linaro.org>
>
> * c-lang.h (cp_print_value_fields): Update declaration.
> * cp-valprint.c (cp_print_value): Update declaration.
> (cp_print_value_fields): Remove parameter valaddr. Callers
> updated.
> (cp_print_value): Likewise.
LGTM
next prev parent reply other threads:[~2016-11-10 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 14:54 Yao Qi
2016-11-10 14:54 ` [PATCH 2/2] Remove apply_val_pretty_printer parameter valaddr Yao Qi
2016-11-10 17:53 ` Doug Evans
2016-11-10 17:54 ` Doug Evans [this message]
2016-11-11 8:41 ` [PATCH 1/2] Remove parameter valaddr from c print functions Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22QnOOamZA2sQCbUjzkREoEE5djFhsdUV_-qG06HdxPL9g@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox