From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22152 invoked by alias); 19 May 2014 22:46:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22102 invoked by uid 89); 19 May 2014 22:46:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f170.google.com Received: from mail-vc0-f170.google.com (HELO mail-vc0-f170.google.com) (209.85.220.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 19 May 2014 22:45:59 +0000 Received: by mail-vc0-f170.google.com with SMTP id lf12so10559836vcb.1 for ; Mon, 19 May 2014 15:45:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=1VGzNB1OiARIO+yBVn4ppRQExDV66I3uZo8cUm594wo=; b=CprPjEifvLtxV8z2JF/fEVsYNxBx6qWz/McfZAgnbJY9de4/SgJVzHAHVwaenfvO+U Ki2jcWTovo/pjw61sy1cOQfGojpO6VZQqdYSpQjrL0x5TnXktrstPCp/bbcXx5BQbrYi IyD39JN/ou7fovjv7c3pBp0+z+pkbjPt3ZOcWVlJMRVlcv08njDZLn09O/NFYE9k0DdA IsQRhohwP0SEL4KuKSgjy9I1jrg3Tlo39UbkS0vJ3MVeFiH89JRzx2nfYfUYx7rOHvIi tFSH7UhgHbNdbZT94TDk/LYeSugUhHF75CHSRTQueui3t1iQiJ7OBg8c/0KDh7dCj6Ni gKwA== X-Gm-Message-State: ALoCoQkTBQL5739oQtuibhCBTMLZHWOUHIGdzQlL0Nm9U08YFCfYkoJn+0vNY4mo8ooF3fsZ2W7p MIME-Version: 1.0 X-Received: by 10.221.27.8 with SMTP id ro8mr545033vcb.30.1400539557530; Mon, 19 May 2014 15:45:57 -0700 (PDT) Received: by 10.52.28.230 with HTTP; Mon, 19 May 2014 15:45:57 -0700 (PDT) In-Reply-To: <20140518190534.GA19591@host2.jankratochvil.net> References: <20140319223004.14668.20989.stgit@host1.jankratochvil.net> <20140319223014.14668.89536.stgit@host1.jankratochvil.net> <20140518190534.GA19591@host2.jankratochvil.net> Date: Mon, 19 May 2014 22:46:00 -0000 Message-ID: Subject: Re: [PATCH v5 1/8] Move utility functions to common/ From: Doug Evans To: Jan Kratochvil Cc: Sergio Durigan Junior , gdb-patches , Aleksandar Ristovski Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00387.txt.bz2 On Sun, May 18, 2014 at 12:05 PM, Jan Kratochvil wrote: > On Mon, 24 Mar 2014 20:59:48 +0100, Sergio Durigan Junior wrote: >> On Wednesday, March 19 2014, Jan Kratochvil wrote: >> > some parts of the former patch have been reimplemented in the meantime by >> > other patches so this is only a part of the former cleanup. >> >> Can't this go in independently? I think they are nice cleanups. > > I do not think it is right without the later parts of the patchset - code > in gdb/common/ should be used by both gdb and gdbserver. Otherwise the code > could remain in gdb/ only. Hi. I don't have a strong opinion on whether this particular patch can go in right away, but I do have a comment. I think we're building gdb wrong (where by "gdb" I mean gdb+gdbserver+gdbreplay+...) if things can't go in common if they're only used by gdb. We should be building gdb out of useful building blocks, and it's just easier to hack if said building blocks are already available, without having to go through all the administrivia of moving them about or what not. If something like skip_spaces isn't used by gdbserver today, that doesn't mean it won't be tomorrow. IOW, I think of "common" as a collection of application-independent routines, not dissimilar from libiberty, but for whatever reason doesn't/can't live there instead. [btw, I'm not suggesting moving routines from common to libiberty, but I'm guessing a quick glance would find a few that should just as well live in libiberty - and be usable by more people too] Plus, I guess I have to ask, if down the road we find some routine in common only used by a particular app, do we need to move it out of common and into that app's directory? My $0.02 anyways.