From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17799 invoked by alias); 24 Aug 2012 18:49:14 -0000 Received: (qmail 17790 invoked by uid 22791); 24 Aug 2012 18:49:13 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 18:49:00 +0000 Received: by vcbfl10 with SMTP id fl10so2923550vcb.0 for ; Fri, 24 Aug 2012 11:48:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=LLbp0jq6PD3zfzThVQoXcFxtgq6V1GhVBhlh+4qvQc0=; b=ENdGR5NYmyZOx8FVIqtpTNjS3CDMudtmZhKU1kLFC8+VkRAApmdv+bM1pHISN0/Rwk Ec3pwNphencT7rZSCvJk6xPaNHJYDJB1tnENdyJtnX9XIlVEmj+9HYOeyCSrMWdvcK5Y uXtHkXx0/divh6If+RwvpngmLSaHTilkgD9Iw/3oAASayJhxSPXqfAxQ4PGIeko2X9xA ESi5CpMGSfJeM/HJRY3uxbbNZDz98B/K1ujb3DI798oPYBPFh4nQK808vcre3OOXY54a K8rmiOVVdHLxyj42/ZGIbFa15V9FjSkvNwLowP1g6TdWoV+dX4iAv8sL1qwVlprHhWbk oAzQ== Received: by 10.52.26.7 with SMTP id h7mr4725716vdg.41.1345834139774; Fri, 24 Aug 2012 11:48:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.26.7 with SMTP id h7mr4725709vdg.41.1345834139662; Fri, 24 Aug 2012 11:48:59 -0700 (PDT) Received: by 10.52.27.11 with HTTP; Fri, 24 Aug 2012 11:48:59 -0700 (PDT) In-Reply-To: <20535.52070.49473.442620@ruffy2.mtv.corp.google.com> References: <1345775139-13576-1-git-send-email-yao@codesourcery.com> <1345775139-13576-2-git-send-email-yao@codesourcery.com> <20535.52070.49473.442620@ruffy2.mtv.corp.google.com> Date: Fri, 24 Aug 2012 18:49:00 -0000 Message-ID: Subject: Re: [PATCH 1/4] new gdb_queue.h in common/. From: Doug Evans To: Yao Qi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQnOjlubUHucZwyPwD4RjIUE7hh93+rSHPmcQR5sIMbuhsokKfW8JziB1zspGEKJMUepWbfm09uGyvcEbm0es35HPOxKigEPMsvBLlRq0Cxi7Q/juA91GBP7978E29PgrqsKImfD23faqpZa/cipen9woxXzErbvfLyIhOMSc8vGi0EPEbgWXZgGW27CTpHI1kaGTg38aOkwW7EoVXMJ0652zyyxVw== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00767.txt.bz2 On Fri, Aug 24, 2012 at 11:43 AM, wrote: > Yao Qi writes: > > Hi, > > When writing the patches for 'general notification', I find queue is > > used in many places, so I think we may need a general queue. This > > queue not only have typical operations enqueue and dequeue, but also > > has some have some operations like remove and remove_all. Hi. Another thing that occurs to me is that there isn't anything gdb-specific here. We have vec.h and gdb_vecs.h. So "Consistency is good." says we should have queue.h and gdb_queues.h. [queue.h can be renamed if it collides with something, the point is that gdb doesn't appear in the name, nor in any symbol defined by it] Igdb_vecs.h is for very generic vectors, and we don't have any very generic queues yet, but that's what I'd use gdb_queues.h for. I think this is a good thing to have btw. :-) [given that we can't use c++ ...] > > > > gdb/ > > > > 2012-08-24 Yao Qi > > > > * common/gdb_queue.h: New.