From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98580-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30122 invoked by alias); 16 Feb 2013 05:30:15 -0000
Received: (qmail 30091 invoked by uid 22791); 16 Feb 2013 05:30:13 -0000
X-SWARE-Spam-Status: No, hits=-5.6 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-vb0-f46.google.com (HELO mail-vb0-f46.google.com) (209.85.212.46)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Feb 2013 05:30:05 +0000
Received: by mail-vb0-f46.google.com with SMTP id b13so2541762vby.19        for <gdb-patches@sourceware.org>; Fri, 15 Feb 2013 21:30:04 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:x-received:in-reply-to:references:date:message-id         :subject:from:to:cc:content-type:x-gm-message-state;        bh=4axJOBoOQpdc03ZyVo4v9ElGyLSAxajjPQJT3ASDGl4=;        b=C3b0IrxRHPv4haXUOMzE0CV8KQrrvWSjaGqx2T1c1ca1U8ZpNpPjguZPJVioxeqIYG         /kW5QdtmE472+TefvyKAIsdaGke/3IFBfi+i39z1rUf/zDWYDgIvo7C+NmuRC6pHOFT9         NDzNkCxSfRlUnRULDHKe+wE9DBU9OYsFIslrHmfdAbS6ukD8HNY6/zz5NhPfAllOD6uH         DlwOafUPKHGhh7HBb+3tPRr9l7B7Yau4u0Sm41g4b/WeayCzXfBl0gHN7gvnfJNVb/uo         UtVepC+yi6pXC06kJPtV3GXDZjrON6Ub7/dn6CywAb1yUqKQPAON2grhYNpMLI7K4RcE         +ZUw==
MIME-Version: 1.0
X-Received: by 10.220.219.9 with SMTP id hs9mr6407957vcb.68.1360992604041; Fri, 15 Feb 2013 21:30:04 -0800 (PST)
Received: by 10.220.210.69 with HTTP; Fri, 15 Feb 2013 21:30:03 -0800 (PST)
In-Reply-To: <CAGyQ6gzmBtx4AO=Md8_Bzj9Nqkd0iPXhLGOkBPe0Zi-DPD0cGg@mail.gmail.com>
References: <CAGyQ6gy_08hZn2Pk6pmD+AuOkH7SCsQ6732KTa7sucZ7-4prUA@mail.gmail.com>	<20753.38272.55066.651097@ruffy2.mtv.corp.google.com>	<CAGyQ6gy68LdCd_qxDX7vinMg-Pb6qnukGScOw2uzgezxKxh_TA@mail.gmail.com>	<CADPb22TGJNFg7VJkeoTB7Ctd=K2Tc490LKo_mdUVXFF2K6TV5g@mail.gmail.com>	<CAGyQ6gweW=9L4mVCkFetd+LvvpjSYzYKM78mYDu5HfG1LpVwiQ@mail.gmail.com>	<87txphmdt3.fsf@fleche.redhat.com>	<CAGyQ6gzSs617BRcreAGA5418EpXaqCaPN8ZzKjQYNx9yxDSJRA@mail.gmail.com>	<87r4kkks5g.fsf@fleche.redhat.com>	<CAGyQ6gwSnFH3OKHSpNxVmVxRRRM61c=T=euhJg6hyFL7+88ecg@mail.gmail.com>	<20763.64197.459891.627211@ruffy2.mtv.corp.google.com>	<CAGyQ6gxOqnD0tr+rR2kuYBr6ub6vN8DvGG5PxA+BO-O8VYXVqA@mail.gmail.com>	<20765.55532.700460.792597@ruffy2.mtv.corp.google.com>	<CAGyQ6gxX7r9QWY+ze9kzyjAwqCf9-kTmor2JRFAoW1mx=x47Kw@mail.gmail.com>	<CAGyQ6gzmBtx4AO=Md8_Bzj9Nqkd0iPXhLGOkBPe0Zi-DPD0cGg@mail.gmail.com>
Date: Sat, 16 Feb 2013 05:30:00 -0000
Message-ID: <CADPb22QkaCm0MNrCNShmmyRuXO6K3-wGBS6-7SXJhXB=gN2=Vg@mail.gmail.com>
Subject: Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble
From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, Tom Tromey <tromey@redhat.com>, 	Eli Zaretskii <eliz@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQn19nKpRRjEqrb4BKb6exhoYqOG2nPDbR84hvit9kFziUsWRhJllyRChpjoaG1DdyMKs4CrtF5+ocFCkxBMWsb2i7tktoi577iNMOjuAOkHoDjv2+umjN07T0e5vCjU681claS3gwM7MTL7lUJASry+HlkyCvZ0xu9AyzY3U6HpjCzOL9I1TPYqD1uYg4wGdAMwZ7L4rRtwluFy/7OB0J2P+1vCpQ==
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00430.txt.bz2

On Fri, Feb 15, 2013 at 1:00 PM, Siva Chandra <sivachandra@google.com> wrote:
> sorry again! twice today...
> patch attached this time.
>
> On Fri, Feb 15, 2013 at 12:35 PM, Siva Chandra <sivachandra@google.com> wrote:
>> Fixed all of Doug's nits. Patch attached.
>>
>> 2013-02-15  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>         Add a new method 'disassemble' to gdb.Architecture class.
>>         * python/py-arch.c (archpy_disassmble): Implementation of the
>>         new method gdb.Architecture.disassemble.
>>         (arch_object_methods): Add entry for the new method.
>>
>> doc/
>>
>>         * gdb.texinfo (Architectures In Python): Add description about
>>         the new method gdb.Architecture.disassemble.
>>
>> testsuite/
>>
>>         * gdb.python/py-arch.c: New test case
>>         * gdb.python/py-arch.exp: New tests to test
>>         gdb.Architecture.disassemble
>>         * gdb.python/Makefile.in: Add py-arch to the list of
>>         EXECUTABLES.
>>
>> Thanks,
>> Siva Chandra

Looks ok to me.
Thanks!