From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4647 invoked by alias); 17 Apr 2014 16:27:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4632 invoked by uid 89); 17 Apr 2014 16:27:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 17 Apr 2014 16:27:11 +0000 Received: by mail-vc0-f174.google.com with SMTP id ld13so756644vcb.33 for ; Thu, 17 Apr 2014 09:27:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=HHhOFe28a9G8okVV2BULzFDjzWysyIv24sG7QkSlKFg=; b=R8o4pifBy67XgaxVZq2fJbe1weByEAuLbwMfx7N4HSRVRmDUrcXgJi1wJ6M4sInJTI y+P7NslRzj+pXNAtzK/zcuFsOlapAEYeA1B53BgluX+68uKadL7Qs+M+hw+lxC8DPAYT WErRG7XL62BQdbpkVvap/8tniV8ZCd4rWyrdrdwa7A52VL9PjSEwAUQFlFyciKdh+9Ev TNYle5EPGg3+KdZmBXAmemf/BHqEIPq/zHi3iWtYldQjcy4S1IqTggTMtWD94sRdWcUt KitqEYkPDLScOpdo7aaYRfmkeWTm+YMs8baDulnPrungP6+gdVWehru9DR1vsNiTtNhj xz1w== X-Gm-Message-State: ALoCoQnJwnzSnOLx4auyLoWB4B1CDbXPCpgJ3Fwh9sRK9QULXXtZkGgegSn/22/JuiBKrKDYyBhVIuyfjMZZ000lVHTcCRomq4mmkwhB5Bf6L8G6Qngfs90LccYsUyk6uWo0P833pOhRwVNbjJcPBKfkViAYwvALeovuGx9sH1FuB+Su/bAt4Zn7dJO4b+YqF4FZPvJTEUmVbZFPTNJERZjtEPTcYysILg== MIME-Version: 1.0 X-Received: by 10.220.190.197 with SMTP id dj5mr8271134vcb.19.1397752029556; Thu, 17 Apr 2014 09:27:09 -0700 (PDT) Received: by 10.52.13.101 with HTTP; Thu, 17 Apr 2014 09:27:09 -0700 (PDT) In-Reply-To: References: <534F294D.4050907@codesourcery.com> Date: Thu, 17 Apr 2014 16:27:00 -0000 Message-ID: Subject: Re: [PATCH] Fix alignment of disassemble /r From: Doug Evans To: Daniel Gutson Cc: Yao Qi , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00369.txt.bz2 On Thu, Apr 17, 2014 at 7:37 AM, Daniel Gutson wrote: > So what if I add a new configuration variable, such as > set disassemble-raw-alignment > with "off" as default, and if set to on, pad to gdbarch_max_insn_length ? Presumably some frontends will do their own alignment. If we went with disassemble-raw-alignment, a boolean value won't help x86 much, it's either no alignment or (in general) too much whitespace. An improvement would be a value from min-insn-length to max-insn-length, but that would be problematic in a multi-arch debugging scenario. If we could agree on some minimum alignment for each variable-length ISA (5 would be fine for me for x86) then maybe a boolean value could be useful ("off" = no alignment, "on" = employ arch-specific minimum). OTOH, what if we made two passes over the instructions, with the first pass computing the maximum instruction length that is present? [And maybe only doing this for CLI.]