From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18439 invoked by alias); 6 Feb 2012 17:09:13 -0000 Received: (qmail 18430 invoked by uid 22791); 6 Feb 2012 17:09:11 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_STOCKTIP,RCVD_IN_DNSWL_LOW,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Feb 2012 17:08:58 +0000 Received: by vbip1 with SMTP id p1so4864307vbi.0 for ; Mon, 06 Feb 2012 09:08:57 -0800 (PST) Received: by 10.52.20.142 with SMTP id n14mr3465021vde.59.1328548137264; Mon, 06 Feb 2012 09:08:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.20.142 with SMTP id n14mr3465009vde.59.1328548137200; Mon, 06 Feb 2012 09:08:57 -0800 (PST) Received: by 10.220.162.7 with HTTP; Mon, 6 Feb 2012 09:08:57 -0800 (PST) In-Reply-To: <20120202225218.BB5DD1E25BF@ruffy2.mtv.corp.google.com> References: <20120202225218.BB5DD1E25BF@ruffy2.mtv.corp.google.com> Date: Mon, 06 Feb 2012 17:09:00 -0000 Message-ID: Subject: Re: [RFA 2/2] Make names in gdbtypes.h,symtab.h const char *. From: Doug Evans To: gdb-patches@sourceware.org X-System-Of-Record: true Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00058.txt.bz2 On Thu, Feb 2, 2012 at 2:52 PM, Doug Evans wrote: > Hi. > > The changes to these two files involve a teensy bit of extra > work beyond simple mechanical changes. > This patch requires the main patch in > http://sourceware.org/ml/gdb-patches/2012-02/msg00043.html > > Ok to check in? > > 2012-02-02 =A0Doug Evans =A0 > > =A0 =A0 =A0 =A0* coffread.c (patch_type): Add (char*) cast to xfree param= eter. > =A0 =A0 =A0 =A0Use xstrdup. > =A0 =A0 =A0 =A0(process_coff_symbol): Use xstrdup. > =A0 =A0 =A0 =A0* stabsread.c (stabs_method_name_from_physname): Renamed f= rom > =A0 =A0 =A0 =A0update_method_name_from_physname. =A0Change result type fr= om void > =A0 =A0 =A0 =A0to char *. =A0All callers updated. > =A0 =A0 =A0 =A0(read_member_functions): In has_destructor case, store nam= e in objfile > =A0 =A0 =A0 =A0obstack instead of malloc space. =A0In !has_stub case, fix= mem leak. + the main patch: http://sourceware.org/ml/gdb-patches/2012-02/msg00043.html Ping.