From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16712 invoked by alias); 17 Dec 2014 22:30:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16695 invoked by uid 89); 17 Dec 2014 22:30:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f175.google.com Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 17 Dec 2014 22:30:20 +0000 Received: by mail-vc0-f175.google.com with SMTP id hy10so282vcb.34 for ; Wed, 17 Dec 2014 14:30:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=CfD4bTk1PnUuMp9WxpoLnKIeRn78MsOyLW/P4PvSlbw=; b=YlQ43rxf6kcpzxGuKd1N0cIXmXdb7dCm3w54iE1JcGGXwFWZnlu5fnnx/4MbgHJnwj V9hntLmKsK5tXjQ/X7yrUZlG5ibW1o6SUMzZROa8bZhWooiMQVHKcDNGR4uM+svjmsc6 BRSgUesosJ4JL7KY9+1p+RnJwEr6Ju0xwbXX+eunQfDpXUqDJQFR0VtmQ46mPeD1U7pm ZwxnlabgQI4VcyXNjbjtL1ULEYBduYUuxIock7hA9T7qkxDNStsTf4Y5aZDLzKd2r1gZ +R4mHPucoIXTL5wlbb6FBl1/lHtNk/ZCjFyZHqamJQjLWUq21f3QC5F8QuldNd8euXCk +hsA== X-Gm-Message-State: ALoCoQkhy8Nsk4Ij5sWRHGeC/WaYc0F0i6y1gBPZN5ElBT03Sl5tKyyaL7yCRwZRPd/srApA3xzK MIME-Version: 1.0 X-Received: by 10.220.201.196 with SMTP id fb4mr27135457vcb.3.1418855418263; Wed, 17 Dec 2014 14:30:18 -0800 (PST) Received: by 10.52.114.101 with HTTP; Wed, 17 Dec 2014 14:30:18 -0800 (PST) In-Reply-To: <5491F976.50804@ericsson.com> References: <1418842893-21536-1-git-send-email-simon.marchi@ericsson.com> <5491F976.50804@ericsson.com> Date: Wed, 17 Dec 2014 22:30:00 -0000 Message-ID: Subject: Re: [PATCH] A few comment cleanups From: Doug Evans To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00504.txt.bz2 On Wed, Dec 17, 2014 at 1:45 PM, Simon Marchi wrote: > On 2014-12-17 02:37 PM, Doug Evans wrote: >> On Wed, Dec 17, 2014 at 11:01 AM, Simon Marchi >> wrote: >>> I stumbled upon a few comments that I think are outdated. >>> >>> Comment for elfread.c (elf_symfile_init): As far as history goes in git, >>> I don't see anything related to that. >>> >>> Comment for elfread.c (elf_symfile_read): References a parameter that was >>> removed in 1999. >>> >>> Comment for struct sym_fns/sym_offsets: References a parameter that was >>> changed in 1999. >>> >>> gdb/ChangeLog: >>> >>> * elfread.c (elf_symfile_init): Remove stale comment. >>> (elf_symfile_read): Same. >>> * symfile.h (struct sym_fns): Same. >> >> Hi. >> Ok with one nit, below. >> >>> --- >>> gdb/elfread.c | 13 +------------ >>> gdb/symfile.h | 6 +----- >>> 2 files changed, 2 insertions(+), 17 deletions(-) >>> >>> diff --git a/gdb/elfread.c b/gdb/elfread.c >>> index b4ec067..93e5045 100644 >>> --- a/gdb/elfread.c >>> +++ b/gdb/elfread.c >>> @@ -1236,10 +1236,6 @@ elf_read_minimal_symbols (struct objfile *objfile, int symfile_flags, >>> We have been initialized by a call to elf_symfile_init, which >>> currently does nothing. >>> >>> - SECTION_OFFSETS is a set of offsets to apply to relocate the symbols >>> - in each section. We simplify it down to a single offset for all >>> - symbols. FIXME. >>> - >>> This function only does the minimum work necessary for letting the >>> user "name" things symbolically; it does not read the entire symtab. >>> Instead, it reads the external and static symbols and puts them in partial >>> @@ -1418,14 +1414,7 @@ elf_symfile_finish (struct objfile *objfile) >>> dwarf2_free_objfile (objfile); >>> } >>> >>> -/* ELF specific initialization routine for reading symbols. >>> - >>> - It is passed a pointer to a struct sym_fns which contains, among other >>> - things, the BFD for the file whose symbols are being read, and a slot for >>> - a pointer to "private data" which we can fill with goodies. >>> - >>> - For now at least, we have nothing in particular to do, so this function is >>> - just a stub. */ >>> +/* ELF specific initialization routine for reading symbols. */ >>> >>> static void >>> elf_symfile_init (struct objfile *objfile) >>> diff --git a/gdb/symfile.h b/gdb/symfile.h >>> index 1e8c230..b2cb089 100644 >>> --- a/gdb/symfile.h >>> +++ b/gdb/symfile.h >>> @@ -354,11 +354,7 @@ struct sym_fns >>> void (*sym_finish) (struct objfile *); >>> >>> /* This function produces a file-dependent section_offsets >>> - structure, allocated in the objfile's storage, and based on the >>> - parameter. The parameter is currently a CORE_ADDR (FIXME!) for >>> - backward compatibility with the higher levels of GDB. It should >>> - probably be changed to a string, where NULL means the default, >>> - and others are parsed in a file dependent way. */ >>> + structure, allocated in the objfile's storage. */ >>> >>> void (*sym_offsets) (struct objfile *, const struct section_addr_info *); >> >> Can I ask you to document what the struct section_addr_info * argument is for? >> > > Hmm I am not sure my knowledge allows me to produce a useful comment. Don't hesitate to > correct/enhance. Here is my first shot, after a bit of code reading: > > /* This function produces a file-dependent section_offsets > structure, allocated in the objfile's storage. > > The section_addr_info structure contains the offset of loadable and > allocated sections, relative to the absolute offsets found in the BFD. */ > > void (*sym_offsets) (struct objfile *, const struct section_addr_info *); "works for me" Thanks!