From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4702 invoked by alias); 12 Nov 2013 21:17:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4674 invoked by uid 89); 12 Nov 2013 21:17:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-vb0-f42.google.com Received: from Unknown (HELO mail-vb0-f42.google.com) (209.85.212.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 12 Nov 2013 21:16:41 +0000 Received: by mail-vb0-f42.google.com with SMTP id p14so4820985vbm.1 for ; Tue, 12 Nov 2013 13:16:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ESnTmoZWue3QuB6cUr3f2mqSOgn9mBQf3VlFF4U9fgE=; b=IZavAOgiFcjfGE+pE1osQrmoKq6tIVRoCqT8FikrfUkAdNvAWOvEJUmTppmCZK+ize bm2Ila2pktHasNTmZaiGo1EOKdyeaBXcgMdzMmsg9BHwk50VZCz2d0kwRjmkARL0hqLl Musa/weARTGCXR/wGCx6MtNEnX8NSZlD+eGjHoa9g8/QpWZkHNDW3UoUxUm+EpoXPOHq t47CQtKjfEiyuoEbDfzmAjZIlOWha9fLN9h60MNyloyeOLxHrXU2jpG+meIMIn2JGMh2 0X8RFAJNByTucW/agFwESHOODJFaaK55hpndT0Xh1QmMiSyXh8zk1vLX7nYToyyMh212 0b+g== X-Gm-Message-State: ALoCoQnuekRHlMjWS04vDuIPmH4QNyYy8je0EPQTxNtNAg7U/nbmvFfnLHwgdV0xQ9X1U0QuX6VCmfXnP2CRaMPEitI5WYC09sFE2rYlQl8h0/3V2Ub9upBgWVDYtIj+jv/GF08+9iRL2GhKPYasbShQT9VzuNJXzMW2mlssqLV/zEtrj25NaH+9CQxQ94i2/8BZ+2wATiURpsGt3UpDxL+40R1OPcNTcQ== MIME-Version: 1.0 X-Received: by 10.221.64.17 with SMTP id xg17mr30782114vcb.5.1384290993129; Tue, 12 Nov 2013 13:16:33 -0800 (PST) Received: by 10.52.237.232 with HTTP; Tue, 12 Nov 2013 13:16:32 -0800 (PST) In-Reply-To: <20131112184556.GA20259@host2.jankratochvil.net> References: <20131105172219.GA21529@host2.jankratochvil.net> <20131105180547.GA24004@host2.jankratochvil.net> <20131106212434.GA4193@host2.jankratochvil.net> <20131107190059.GA24230@host2.jankratochvil.net> <21117.8566.225807.905608@ruffy.mtv.corp.google.com> <20131108175033.GA11849@host2.jankratochvil.net> <20131112184556.GA20259@host2.jankratochvil.net> Date: Tue, 12 Nov 2013 22:05:00 -0000 Message-ID: Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786 From: Doug Evans To: Jan Kratochvil Cc: Tom Tromey , gdb-patches , Pedro Alves , Stan Shebs Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00328.txt.bz2 On Tue, Nov 12, 2013 at 10:45 AM, Jan Kratochvil wrote: > On Tue, 12 Nov 2013 19:33:33 +0100, Doug Evans wrote: >> https://sourceware.org/gdb/wiki/Internals%20GDB-Testsuite-Coding-Standards >> >> Feel free to tweak or add whatever community rules there are. >> I'll add more as it occurs to me. > > FYI I find > In C code, don't use K&R function definitions > > redundant against the part above > The best guidance one can give is that unless a test requires > a particular style (which is rare) you can't go wrong following the > GDB coding standards. > > but it is OK even as a redundant text. Eh? It is not redundant, that was the whole point of this thread. Following the GDB coding standards is not a rule.