From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16530 invoked by alias); 20 Sep 2012 14:55:17 -0000 Received: (qmail 16508 invoked by uid 22791); 20 Sep 2012 14:55:15 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,TW_EG X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Sep 2012 14:55:01 +0000 Received: by vcbfl17 with SMTP id fl17so2948721vcb.0 for ; Thu, 20 Sep 2012 07:55:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=9eZDk/HhFfpdMhXycBOUNrTBBTb8ez1vwoqTlzQ+0pM=; b=b41lkPxIkYCIqwdqO34OUYNUlyIJiX3y08iBkAWeid6lHcE503lBXvLahprlBd4ny3 eJ9yjkTXg3JnKw4kok+I/sJLyyBeNViiZq9vnOLZsiBMvTbs6xSEHrKPke+vD6BBtQrO 3FS3PVHLH3ITVxPvIGD83/BHyFdsGntOKISsR4S5p9VpQWWwBv2ZgnINeVZ33dfkLGGN OEefmnT2yDnTyiLL7EyV8G8kZYpxCnwcwiHwrydrkMDoAek5UgodO/e8albVS5JxZMEk t6Hf4rjf66iq11EhHHgsRAf6/nEEh7KWchzhAHJz8TEMcyMKVJZf3lV30YPQfGlFcJd1 0pHA== Received: by 10.220.16.9 with SMTP id m9mr1144865vca.72.1348152901106; Thu, 20 Sep 2012 07:55:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.16.9 with SMTP id m9mr1144855vca.72.1348152900935; Thu, 20 Sep 2012 07:55:00 -0700 (PDT) Received: by 10.52.24.239 with HTTP; Thu, 20 Sep 2012 07:55:00 -0700 (PDT) In-Reply-To: <505430A6.8060902@codesourcery.com> References: <505430A6.8060902@codesourcery.com> Date: Thu, 20 Sep 2012 14:55:00 -0000 Message-ID: Subject: Re: [patch] callfuncs.exp: set unwindonsignal on From: Doug Evans To: Yao Qi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQlPQBc+qGEPbe56hT4PiW3r75il1BFxG8DKpWUvY1ibDCwUKR9KgasX7t4jYHrtUqJpAYmNqbQjQ1i9GARLyx8S8Ea9b7hNOFXqbXhv1PapbxdJCtCdU6VRuVVorU2kioRsjV4cT5IAirkvOUpCWpyFr5HS0FPmxlIKBNO15ewKRjFKN0teagLjt9pe09lT6lSyHxUc2BiDBTFD2YQUrOqtCCQqCQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00402.txt.bz2 On Sat, Sep 15, 2012 at 12:39 AM, Yao Qi wrote: > On 09/15/2012 06:34 AM, dje@google.com wrote: >> >> Hi. >> >> Testing cvs head with i686 binaries and 64-bit gdb has this failure: >> FAIL: gdb.base/callfuncs.exp: gdb function calls preserve register >> contents >> [I'm guessing the same failure will be seen with 32-bit native.] >> > > This fail was introduced by my patch (sorry), > > [_Complex test 4/4] _Complex tests in callfuncs.exp > http://sourceware.org/ml/gdb-patches/2011-05/msg00421.html > > and it exists on 32-bit native. No worries. >> >> Index: callfuncs.exp >> =================================================================== >> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/callfuncs.exp,v >> retrieving revision 1.52 >> diff -u -p -r1.52 callfuncs.exp >> --- callfuncs.exp 9 Jul 2012 14:20:52 -0000 1.52 >> +++ callfuncs.exp 14 Sep 2012 22:29:09 -0000 >> @@ -65,6 +65,10 @@ proc do_function_calls {} { >> # We need to up this because this can be really slow on some boards. >> set timeout 60; >> >> + # If any of these calls segv we don't want to affect subsequent >> tests. >> + # E.g., we want to ensure register values are restored. >> + gdb_test_no_output "set unwindonsignal on" >> + >> gdb_test "p t_char_values(0,0)" " = 0" >> gdb_test "p t_char_values('a','b')" " = 1" >> gdb_test "p t_char_values(char_val1,char_val2)" " = 1" >> @@ -259,6 +263,9 @@ proc do_function_calls {} { >> >> gdb_test "p t_structs_a(struct_val1)" "= (.unsigned char .. >> )? \"foo\"" \ >> "call inferior func with struct - returns char *" >> + >> + # Restore default value. >> + gdb_test_no_output "set unwindonsignal off" > > > The patch looks right to me. Nitpicking, do we store the original value of > 'unwindonsignal', and restore it here? I am wondering people may run > testsuite with 'unwindonsignal' on in default? Thanks, committed. Changing of settings only applies for the duration of each .exp file as gdb is restarted for each one. Here I think it's ok, at least for the test as is - if someone extends the test and it starts to matter then saving/restoring can be addressed then. Plus I think the test is expecting the initial value of unwindonsignal to be off - we could add more code to the test to enforce that.