[PATCH 4/7] PR gdb/15224 should "set history save on" by default

mbilal
2013-05-06T09:47:27Z

On Wednesday, April 03, 2013 7:30 PM Jan Kratochvil wrote:

> (4) Modify GDB testsuite to always disable history saving.

patch for this.

Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.230
diff -u -p -r1.230 gdb.exp
--- lib/gdb.exp 15 Apr 2013 20:37:37 -0000 1.230
+++ lib/gdb.exp 6 May 2013 07:01:55 -0000
@@ -58,7 +58,7 @@ set BUILD_DATA_DIRECTORY "[pwd]/../data-
# INTERNAL_GDBFLAGS contains flags that the testsuite requires.
global INTERNAL_GDBFLAGS
if ![info exists INTERNAL_GDBFLAGS] {
- set INTERNAL_GDBFLAGS "-nw -nx -data-directory $BUILD_DATA_DIRECTORY"
+ set INTERNAL_GDBFLAGS "-nw -nx -ex set\\ history\\ save\\ off
-data-directory $BUILD_DATA_DIRECTORY"
}

# The variable gdb_prompt is a regexp which matches the gdb prompt.
Index: gdb.base/default.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
retrieving revision 1.64
diff -u -p -r1.64 default.exp
--- gdb.base/default.exp 15 Apr 2013 18:09:02 -0000 1.64
+++ gdb.base/default.exp 6 May 2013 07:02:53 -0000
@@ -521,8 +521,9 @@ gdb_test "set height" "Argument required
gdb_test_no_output "set history expansion" "set history expansion"
#test set history filename
gdb_test "set history filename" "Argument required .filename to set it
to.*" "set history filename"
+#We are always disable history saving on testsuite
#test set history save
-gdb_test_no_output "set history save" "set history save"
+#gdb_test_no_output "set history save" "set history save"
#test set history size
gdb_test "set history size" "Argument required .integer to set it
to.*" "set history size"
#test set history
@@ -644,7 +645,7 @@ gdb_test "show history expansion" "Histo
#test show history filename
gdb_test "show history filename" "The filename in which to record the
command history is.*.gdb_history.*" "show history filename"
#test show history save
-gdb_test "show history save" "Saving of the history record on exit is
on." "show history save"
+gdb_test "show history save" "Saving of the history record on exit is
off." "show history save"
#test show history size
gdb_test "show history size" "The size of the command history is.*"
"show history size"
#test show history
Index: gdb.base/setshow.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setshow.exp,v
retrieving revision 1.30
diff -u -p -r1.30 setshow.exp
--- gdb.base/setshow.exp 24 Apr 2013 14:29:17 -0000 1.30
+++ gdb.base/setshow.exp 6 May 2013 07:08:29 -0000
@@ -174,10 +174,11 @@ gdb_test_no_output "set history filename
"set history filename foobar.baz"
#test show history filename foobar.baz
gdb_test "show history filename" "The filename in which to record the
command history is \"foobar.baz\"..*" "show history filename (foobar.baz)"
+#We are always disable history saving on testsuite
#test set history save on
-gdb_test_no_output "set history save on" "set history save on"
+#gdb_test_no_output "set history save on" "set history save on"
#test show history save on
-gdb_test "show history save" "Saving of the history record on exit is
on..*" "show history save (on)"
+gdb_test "show history save" "Saving of the history record on exit is
off..*" "show history save (off)"
#test set history size 100
gdb_test_no_output "set history size 100" "set history size 100"
#test show history size 100

Thanks,
-Bilal