From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76808 invoked by alias); 3 Jun 2015 18:08:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76784 invoked by uid 89); 3 Jun 2015 18:08:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 03 Jun 2015 18:08:04 +0000 Received: by obew15 with SMTP id w15so14485837obe.1 for ; Wed, 03 Jun 2015 11:08:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=WorHBhnyROk7OrtVtAZOlipe1w4bS2aEnDWMxR8R8Kg=; b=eCsYM77TJ0mWIIzBpxpROGkRFc4+bLj6buSFieVm2XuBKMboaCTvzER3MvtJmy96dk SXPRhotW3SS5uT9p60ErNARe6biJyxXAwEvBMGYVfS/+CM+7hJxc6yCCG6Se97SshVKu ODZVe7cHUJMqe+/BAF3kCTbpGS02raQRWKqJNx20370mOTl72GKSd+9O1WgdvP1MK114 mu054WQ0yeCFZdO1gJCgYUsx6uQCvVGPazFFNX5b07rfCxYIqNSG8o0fKRbcVp7ah1na PHclk6rF9+oY7p5da54eDMfa81+LSTuKJEdUBQcbWIkpmxysbtW45u2+RpwXuW0KOdy8 AIpw== X-Gm-Message-State: ALoCoQl3ZpEfO+ln5ZIDkVXTI9dg8bUH2rslZWctensn8tOKv+yOjeQc3RVwZiiIrAYw2F2Nt2w4 MIME-Version: 1.0 X-Received: by 10.60.101.195 with SMTP id fi3mr25336469oeb.65.1433354882276; Wed, 03 Jun 2015 11:08:02 -0700 (PDT) Received: by 10.182.89.99 with HTTP; Wed, 3 Jun 2015 11:08:02 -0700 (PDT) In-Reply-To: <20150601213709.GC2631@adacore.com> References: <20150601213709.GC2631@adacore.com> Date: Wed, 03 Jun 2015 18:08:00 -0000 Message-ID: Subject: Re: 2 weeks to GDB 7.10 tentative branching date! From: Doug Evans To: Joel Brobecker , Keith Seitz Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00055.txt.bz2 On Mon, Jun 1, 2015 at 2:37 PM, Joel Brobecker wrote: > Hello, > > Just a quick reminder that we've set the tentative branching > date for the GDB 7.10 release to June 15th, which is only > a couple of weeks away. > > As in previous releases, we have a wiki page where we track all > blocking issues before we can cut the branch: > > https://sourceware.org/gdb/wiki/GDB_7.10_Release > > If you know of anything that we should hold the branch for, please > let us know. There are typically regressions, important features > that need a little extra time to be completely integrated in master, > etc. > > Thank you! > -- > Joel It would be great to resolve pr 16253 for 7.10. We reverted a fix in the lead up to 7.8, hoping to revisit it afterwards, but we never did. :-( [details in the pr] https://sourceware.org/bugzilla/show_bug.cgi?id=16253 Maybe a two step solution would be ok? For 7.10: 1) re-add keiths patch, with the following modifications: a) add a STRUCT vs VAR_DOMAIN indicator to .gdb_index b) bump .gdb_index version to 9 c) modify keith's patch so that it only is enabled when either .gdb_index is not in use or its version >= 9 (IOW we'd still have to keep symbol_matches_domain, in some form, but use it conditionally) For later: 2) when all producers we care about can produce v9 indices, remove hack 1c I'm aware of the u/i consequences of this approach (whether examples like in 16253 would work would be dependent upon whether the index is in use and its version). Another thought I had is that symbol lookup has changed a bit since 7.8. It may be possible to just reapply keith's patch and avoid the massive perf regression differently. Comments?