From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112867-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2649 invoked by alias); 28 May 2014 20:58:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 2636 invoked by uid 89); 28 May 2014 20:58:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vc0-f179.google.com
Received: from mail-vc0-f179.google.com (HELO mail-vc0-f179.google.com) (209.85.220.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 28 May 2014 20:58:31 +0000
Received: by mail-vc0-f179.google.com with SMTP id im17so12896528vcb.24        for <gdb-patches@sourceware.org>; Wed, 28 May 2014 13:58:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=S3h4e/pmqTQbil5SnosbuIqpK2pphYYjP3ziBABLHWM=;        b=Cp0LRGAx5M/CiXqhckJnid6+W06QYviPuv70zphGtPeDNQ8MByCvSeLOsJzKZ3J5a0         9kTrG7jLtqfX52eKoLlWpv9ZkUB/Hmpy+92vi6wp3PMxfRebl3IilSguNeAdz0oRTohI         smmo4MHyj+q7yEBqnHwZvKksrd7YRZ4Rm4OUMF2saN16kFrzkl9nCQAaDhzlSS/IEBKO         q48fAX+XWoitKGuVpbzXBdOOZg1QWYf0AmkZ3uyt3sexU31qTlrvnQ6eadv9bC63RmDG         OuNu8D5H8dcN0n+9I6qgtzSHItXDiTXaAFs64jvy/IINhn6BIZa2N7U4lfE5HPnS2AKo         AckA==
X-Gm-Message-State: ALoCoQkxqyWCFEujm4XA6DgHfBv8Ea1r3Aw1DeWnq/b4pAnOiUFGdvOagFQmHeD0y8YIPto1wu+h
MIME-Version: 1.0
X-Received: by 10.220.47.201 with SMTP id o9mr2288534vcf.65.1401310709615; Wed, 28 May 2014 13:58:29 -0700 (PDT)
Received: by 10.52.28.230 with HTTP; Wed, 28 May 2014 13:58:29 -0700 (PDT)
In-Reply-To: <CAGyQ6gx09MP8RPPr6bu9TfawKASX14d2j3+MkocKU_vtJhN7pA@mail.gmail.com>
References: <CAGyQ6gz5zh64AcfeHcqiXtYKpJf7GWpD+5FmKe38fg1bOMJc_w@mail.gmail.com>	<m3ha4dh1vq.fsf@sspiff.org>	<m3mwe2fqcp.fsf@sspiff.org>	<CAGyQ6gx09MP8RPPr6bu9TfawKASX14d2j3+MkocKU_vtJhN7pA@mail.gmail.com>
Date: Wed, 28 May 2014 20:58:00 -0000
Message-ID: <CADPb22QTkhbq3F11abh879yKfEsqjT+LvZ35xKYz5sX_8pBNeQ@mail.gmail.com>
Subject: Re: [Patch v18 4/4] Add xmethod support to the Python API
From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-05/txt/msg00705.txt.bz2

On Wed, May 28, 2014 at 1:44 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Tue, May 27, 2014 at 10:02 PM, Doug Evans <xdje42@gmail.com> wrote:
>> Ok, let's do this.
>>
>> extension.c:invoke_xmethod will throw an error if this function
>> returns EXT_LANG_RC_ERROR:
>>
>>   if (rc == EXT_LANG_RC_ERROR)
>>     {
>>       error (_("Error while invoking a xmethod defined in %s"),
>>              worker->extlang->capitalized_name);
>>     }
>
> I did not understand this part. Since you suggest below that
> gdbpy_invoke_xmethod return value * and throw GDB errors for Python
> errors as well, where would invoke_xmethod get RC from?

invoke_method would look like this:

struct value *
invoke_xmethod (struct xmethod_worker *worker, struct value *obj,
                struct value **args, int nargs)
{
  gdb_assert (worker->extlang->ops->invoke_xmethod != NULL);

  return worker->extlang->ops->invoke_xmethod (worker->extlang, worker,
                                               obj, args, nargs);
}

Sorry for the confusion.