From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17659 invoked by alias); 31 Oct 2014 19:02:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17649 invoked by uid 89); 31 Oct 2014 19:02:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f172.google.com Received: from mail-qc0-f172.google.com (HELO mail-qc0-f172.google.com) (209.85.216.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 31 Oct 2014 19:02:13 +0000 Received: by mail-qc0-f172.google.com with SMTP id i17so6534809qcy.3 for ; Fri, 31 Oct 2014 12:02:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Rf0Q8jc1Xt7JrEeheJSE1WmbrJr80ZXqj3T6r2lvaUw=; b=YWynD4K8jkxztOIjNNkbG64txnyF+tpsFX7PsO6OeaKwyId78UxgITCVLFAGHBl0Ji LjSrB290duYVMF7KKS7VMPfB2beW+M2I4R/tNr1Ffj1s3VnGdA0+eqPXrgnR8RHU+76r PMvgnFPxzTUSEooFBMiDX8TVm61NYMvrGdU2tI9s1YPh5g46htqqZrB7z6E4NPnq8dfk ra9MLOVLztPGb7NcSCsBm8WdvMiNBKOzyGu47xqppaxNzOhDeZ4N7VS1Eynw44NqQ0Mo whr+lBTzjji39Vy52nNWeB8n1At+hS0TkjOKD+Gr+4qAlAz4tdw9Je2UOiOl261SoWIK KxxQ== X-Gm-Message-State: ALoCoQnnPRmxFuPPAd1EJl3LMCLLkp5vfrxq5IAyeWO7lg+/hC9BrXx8d52f0aKWIqROxYNzBA+A MIME-Version: 1.0 X-Received: by 10.140.39.134 with SMTP id v6mr37789270qgv.19.1414782131153; Fri, 31 Oct 2014 12:02:11 -0700 (PDT) Received: by 10.229.250.4 with HTTP; Fri, 31 Oct 2014 12:02:11 -0700 (PDT) In-Reply-To: <87zjcd8r1r.fsf@br87z6lw.de.ibm.com> References: <544BD7E6.1050602@codesourcery.com> <201410251728.s9PHSg6v018247@glazunov.sibelius.xs4all.nl> <87zjcd8r1r.fsf@br87z6lw.de.ibm.com> Date: Fri, 31 Oct 2014 19:02:00 -0000 Message-ID: Subject: Re: GCC switch to C11 causes many testsuite compiler diagnostics From: Doug Evans To: Andreas Arnez Cc: Mark Kettenis , sandra@codesourcery.com, gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00858.txt.bz2 On Thu, Oct 30, 2014 at 9:23 AM, Andreas Arnez wrote: > On Sat, Oct 25 2014, Mark Kettenis wrote: > >>> Date: Sat, 25 Oct 2014 11:03:34 -0600 >>> From: Sandra Loosemore >>> >>> Comparing my latest nios2 test results (with Pedro's thread patch) with >>> those from a checkout a couple weeks old, I noticed I had some new >>> ERRORs due to apparent compilation failures. I tracked this down to the >>> recent change on GCC mainline (r216247) to make the default C dialect >>> GNU11, which enables -Wimplicit-int and -Wimplicit-function-declaration >>> by default. I started working on a patch to fix the offending >>> testcases, but realized that there are hundreds of them. :-( >>> >>> So, before I invest a lot more time on this, is updating the GDB >>> testsuite to use a more modern C dialect the Right Thing To Do? I'm >>> also wondering if it's really necessary to support compilers that can't >>> handle function prototypes in the testsuite (not defining PROTOTYPES >>> seems to be the default, in fact). >> >> We've quite deliberately kept around a variety of C dialects and >> coding styles to make sure GDB works with whatever style people use. >> Having the majority of the tests use K&R style function declarations >> is probably not so useful anymore. But there are some tests that >> deliberately use K&_R style code to test whether GDB handles them >> properly. So blind conversion is probably not a good idea. > > Do you know off hand which tests deliberately use K&R style code? Maybe > you'd like to verify that none of them is deleted by this patch series: > > https://sourceware.org/ml/gdb-patches/2014-10/msg00802.html fwiw, I think this is the way to proceed. Find/pick a few tests that are explicitly for K&R, mark them as such, and move on. Life's short and there are so many vastly more important things to do than worry about losing some K&R coverage. If an issue turns up, we'll have real data to support a real K&R test.