From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128891 invoked by alias); 22 Jul 2016 19:16:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128879 invoked by uid 89); 22 Jul 2016 19:16:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Field X-HELO: mail-vk0-f43.google.com Received: from mail-vk0-f43.google.com (HELO mail-vk0-f43.google.com) (209.85.213.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 22 Jul 2016 19:16:52 +0000 Received: by mail-vk0-f43.google.com with SMTP id s189so169766248vkh.1 for ; Fri, 22 Jul 2016 12:16:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GX904mtM5m8sWyv+yqK1c2lq2eFe+MlTIHkqOJowEpA=; b=i1qMKtktlQwy3H6h+QrjS/LlqJwR24wRMymLSrbGYD5OuNHJfaTzHYXJ/PjYCKslej hIwd6fG7FxUHRjgsZgnj3/HBMJrL9QCTekMraH8bUUt/x+5WQQN4oFNJE4Egkd0pvjtt lVP3hm5icbOEF/wZZ3sDZXl7rAjNvOmIyCstRfKTtrBseoQZUHGql3qIIT9lKEq5Rc6y lg3pFjrvgbbjzKRiJNmORwtuM4oAc+vDqP9wPaeySzUA4UukrSZ0QJHj1k1avD692zHb liV1eJJ4nJyytijuT1+UZM5SVbOT66aoEQcqBiuNR0NU8d111wUbOa84WoJAb4TKIZ/A 7Ddg== X-Gm-Message-State: AEkooutuHZDyBlOxvRdrLevxRIfLt4cSx7Mbl4tHvcTCkF3YuwqDEjirRS/qpeOleCj9V5W6BoELn0fygL/qa3CV X-Received: by 10.159.36.15 with SMTP id 15mr2238993uaq.79.1469215010152; Fri, 22 Jul 2016 12:16:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.141.8 with HTTP; Fri, 22 Jul 2016 12:16:09 -0700 (PDT) In-Reply-To: <2026a39c-0b53-9142-74ce-091bc73832d8@redhat.com> References: <047d7b5dbb865204bd052cf0bc2b@google.com> <2026a39c-0b53-9142-74ce-091bc73832d8@redhat.com> From: Doug Evans Date: Fri, 22 Jul 2016 19:16:00 -0000 Message-ID: Subject: Re: [PATCH 4/5]: Enhancements to "flags": i386 cleanup To: Pedro Alves Cc: gdb-patches , cole945@gmail.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00303.txt.bz2 On Wed, Jul 20, 2016 at 11:17 AM, Pedro Alves wrote: > Hi Doug, > > On 02/29/2016 11:09 PM, Doug Evans wrote: >> Hi. >> >> This patch just simplifies things by removing the "end" spec in >> i386 eflags definitions, and is otherwise a nop. >> >> I removed them because they're redundant. >> > > I noticed that this makes older gdbs reject the new target descriptions. > E.g., gdb 7.11.1 against master gdbserver: > > Remote debugging using :9999 > warning: while parsing target description (at line 24): Field "CF" has neither type nor bit position > warning: Could not load XML target description; ignoring > > Reverting the patch makes old gdb grok the tdesc again (git revert 49b7ae7bb8f2). > > Since it was meant as a cleanup, I think we should revert > it on grounds of avoiding a back compatibility break. WDYT? Fine by me.