From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18589 invoked by alias); 9 Oct 2014 14:47:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18503 invoked by uid 89); 9 Oct 2014 14:47:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f175.google.com Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 09 Oct 2014 14:47:23 +0000 Received: by mail-vc0-f175.google.com with SMTP id id10so1094183vcb.6 for ; Thu, 09 Oct 2014 07:47:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=XPngnQ+om0AwnX46M8Q7h0U6xQ12oF43UvJ/UGj0Urk=; b=IcV77pzzyNwWnSidEOOPQhP+y1YXbHojWf6kQJaWQerA5Vixkyd1NWJRJQG8IMPRWy SKtkBHA4eadOK/zpe2YPJfZjFemIz+gBVVSL7ggNdXHJOR+ZmT9Yh+AYE7LkN1zDFLyb qVMX09GQ+K8FNvgo1QiFejVB8QC6XBlMRyRXX/1uhCmfA1nY6aFe0ErZwe4AIKmalX6s v14dw+O0QnxY8pbqLQ4TYz901Bxbd2lo4R4KFlILsOlHrO/CDvJ/Wg/OAz2P6bByAZlk 9pNPvquVAZ6LKdKLKvILbUPmzqHqlTm6rJkiUbUEZFKnHyxGsBuMy3iwkN6Gnvq6PrDO hOxQ== X-Gm-Message-State: ALoCoQnYkwXW24oXIP3E+VbP4F0aJyWzi76YQ4/WJw19VvfCkgdGF40nekaeHrbf3242dWrCMqS1 MIME-Version: 1.0 X-Received: by 10.52.139.106 with SMTP id qx10mr16386833vdb.1.1412866041358; Thu, 09 Oct 2014 07:47:21 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Thu, 9 Oct 2014 07:47:21 -0700 (PDT) In-Reply-To: <20141009094531.GB6910@blade.nx> References: <1409586154-16196-1-git-send-email-gbenson@redhat.com> <1409586154-16196-2-git-send-email-gbenson@redhat.com> <20141009094531.GB6910@blade.nx> Date: Thu, 09 Oct 2014 14:47:00 -0000 Message-ID: Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions From: Doug Evans To: Gary Benson Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00204.txt.bz2 On Thu, Oct 9, 2014 at 5:45 AM, Gary Benson wrote: > Doug Evans wrote: >> On Mon, Sep 1, 2014 at 11:42 AM, Gary Benson wrote: >> > defs.h includes utils.h, and utils.h includes exceptions.h. All >> > GDB .c files include defs.h as their first line, so no file other >> > than utils.h needs to include exceptions.h. This commit removes >> > all such inclusions. >> > >> > Doug, I Cc'd you on this one as you asked me to avoid giant >> > mechanical ChangeLog entries but I couldn't figure out how I'd >> > rewrite this one. >> >> For reference sake, >> I said that for two reasons: >> 1) to save you some typing >> 2) to keep the S/N ratio of the ChangeLog file from dropping, and >> in this case from dropping significantly. Yikes! >> >> > gdb/ChangeLog: >> > >> > * ada-lang.c: Do not include exceptions.h. >> > * ada-valprint.c: Likewise. >> > * amd64-tdep.c: Likewise. >> > [...] >> >> I realize one of the guidelines for changelogs is to document every >> file that's changed, but if we can agree that "All callers updated." >> can apply to all callers in all files, then I don't see why we >> couldn't be ok with something like the following for this case: >> >> * All .c files: Do not include exceptions.h. >> >> Yeah, it's not pedantically correct, not all .c files were touched. >> But I can live with that given the alternative. > > I'll use this wording next time. fwiw, I think anything similarly short in any similar situation should be fine.