From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3916 invoked by alias); 3 Nov 2011 23:18:26 -0000 Received: (qmail 3905 invoked by uid 22791); 3 Nov 2011 23:18:25 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Nov 2011 23:18:08 +0000 Received: by qadc11 with SMTP id c11so2039119qad.0 for ; Thu, 03 Nov 2011 16:18:07 -0700 (PDT) Received: by 10.224.194.5 with SMTP id dw5mr5916039qab.16.1320362260285; Thu, 03 Nov 2011 16:17:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.194.5 with SMTP id dw5mr5915575qab.16.1320362228931; Thu, 03 Nov 2011 16:17:08 -0700 (PDT) Received: by 10.224.6.76 with HTTP; Thu, 3 Nov 2011 16:17:08 -0700 (PDT) In-Reply-To: References: <20110920041137.A67D02461A0@ruffy.mtv.corp.google.com> Date: Thu, 03 Nov 2011 23:18:00 -0000 Message-ID: Subject: Re: [RFA, doc RFA] Include wallclock time in "maint time" output. From: Doug Evans To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf3005deb4a15d6204b0dcc9f4 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00104.txt.bz2 --20cf3005deb4a15d6204b0dcc9f4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2761 On Tue, Sep 20, 2011 at 12:09 AM, Eli Zaretskii wrote: >> Date: Mon, 19 Sep 2011 23:08:52 -0700 >> From: Doug Evans >> Cc: gdb-patches@sourceware.org >> >> > Actually, it would be much more useful to display time it took the >> > inferior between two points where GDB gets control. =A0Are you trying = to >> > approximate that missing feature, or is there some other use case >> > where wallclock time would be useful? >> >> It's not always the case that the inferior is running when wanting to >> see wallclock time. =A0E.g., remote protocol operations, excessive nfs >> latency, etc. >> [For reference sake, MI already supports this feature for monitoring >> slow operations.] > > It sounds like it would be a good idea to mention these use cases in > the manual. > >> It's not possible to implement gettimeofday on windows with better >> accuracy? > > It is easy to do that with 10ms resolution, but not below that. =A0Below > that, AFAIK only interval measurements are "easy" on Windows. > >> gettimeofday is pretty simple and standard, >> inventing something new has its own disadvantages. > > I disagree, but I can live with that. > >> >> +If set to a nonzero value, @value{GDBN} will display how much time it >> >> =A0took to execute each command, following the command's own output. >> >> -The time is not printed for the commands that run the target, since >> >> -there's no mechanism currently to compute how much time was spend >> >> -by @value{GDBN} and how much time was spend by the program been debu= gged. >> >> -it's not possibly currently >> > >> > I'm not sure we should remove that remark, because what it says is >> > still true, even after your changes. >> >> The part about time not being printed for commands that run the target >> is not true. > > The CPU time still accounts for GDB only, right? =A0It sounds like we > interpret this sentence differently, so perhaps it should be reworded > rather than being deleted. You'll need to tell me how you interpret it. Note that my docs do say that the time printed does not include inferior time. >> Does the part about there being no mechanism to compute how much time >> was spent by the inferior really add anything of value? > > It explains the meaning of the times we print, IMO. =A0If someone saw > the need to tell that at some point, I tend to honor that. PTAL. 2011-11-03 Doug Evans * utils.c: #include "timeval-utils.h". (cmd_stats): Rename start_time to start_cpu_time. New member start_wall_time. (report_command_stats): Report wall time. (make_command_stats_cleanup): Record start wall time. doc/ * gdb.texinfo (Maintenance Commands): Update docs of "maint time". --20cf3005deb4a15d6204b0dcc9f4 Content-Type: text/plain; charset=US-ASCII; name="gdb-111103-wallclock-time-2.patch.txt" Content-Disposition: attachment; filename="gdb-111103-wallclock-time-2.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gukdk1c70 Content-length: 4966 MjAxMS0xMS0wMyAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog dXRpbHMuYzogI2luY2x1ZGUgInRpbWV2YWwtdXRpbHMuaCIuCgkoY21kX3N0 YXRzKTogUmVuYW1lIHN0YXJ0X3RpbWUgdG8gc3RhcnRfY3B1X3RpbWUuCglO ZXcgbWVtYmVyIHN0YXJ0X3dhbGxfdGltZS4KCShyZXBvcnRfY29tbWFuZF9z dGF0cyk6IFJlcG9ydCB3YWxsIHRpbWUuCgkobWFrZV9jb21tYW5kX3N0YXRz X2NsZWFudXApOiBSZWNvcmQgc3RhcnQgd2FsbCB0aW1lLgoKCWRvYy8KCSog Z2RiLnRleGluZm8gKE1haW50ZW5hbmNlIENvbW1hbmRzKTogVXBkYXRlIGRv Y3Mgb2YgIm1haW50IHRpbWUiLgoKSW5kZXg6IHV0aWxzLmMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi91dGls cy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjI2NApkaWZmIC11IC1wIC1y MS4yNjQgdXRpbHMuYwotLS0gdXRpbHMuYwkxNCBPY3QgMjAxMSAwNzo1NToy NiAtMDAwMAkxLjI2NAorKysgdXRpbHMuYwkzIE5vdiAyMDExIDIyOjQ2OjEz IC0wMDAwCkBAIC00NSw2ICs0NSw3IEBACiAjZW5kaWYKIAogI2luY2x1ZGUg PHNpZ25hbC5oPgorI2luY2x1ZGUgInRpbWV2YWwtdXRpbHMuaCIKICNpbmNs dWRlICJnZGJjbWQuaCIKICNpbmNsdWRlICJzZXJpYWwuaCIKICNpbmNsdWRl ICJiZmQuaCIKQEAgLTY5MSw3ICs2OTIsOCBAQCBzdGF0aWMgaW50IGRpc3Bs YXlfc3BhY2U7CiBzdHJ1Y3QgY21kX3N0YXRzIAogewogICBpbnQgbXNnX3R5 cGU7Ci0gIGxvbmcgc3RhcnRfdGltZTsKKyAgbG9uZyBzdGFydF9jcHVfdGlt ZTsKKyAgc3RydWN0IHRpbWV2YWwgc3RhcnRfd2FsbF90aW1lOwogICBsb25n IHN0YXJ0X3NwYWNlOwogfTsKIApAQCAtNzIzLDEyICs3MjUsMTggQEAgcmVw b3J0X2NvbW1hbmRfc3RhdHMgKHZvaWQgKmFyZykKIAogICBpZiAoZGlzcGxh eV90aW1lKQogICAgIHsKLSAgICAgIGxvbmcgY21kX3RpbWUgPSBnZXRfcnVu X3RpbWUgKCkgLSBzdGFydF9zdGF0cy0+c3RhcnRfdGltZTsKKyAgICAgIGxv bmcgY21kX3RpbWUgPSBnZXRfcnVuX3RpbWUgKCkgLSBzdGFydF9zdGF0cy0+ c3RhcnRfY3B1X3RpbWU7CisgICAgICBzdHJ1Y3QgdGltZXZhbCBub3dfd2Fs bF90aW1lLCBkZWx0YV93YWxsX3RpbWU7CisKKyAgICAgIGdldHRpbWVvZmRh eSAoJm5vd193YWxsX3RpbWUsIE5VTEwpOworICAgICAgdGltZXZhbF9zdWIg KCZkZWx0YV93YWxsX3RpbWUsCisJCSAgICZub3dfd2FsbF90aW1lLCAmc3Rh cnRfc3RhdHMtPnN0YXJ0X3dhbGxfdGltZSk7CiAKICAgICAgIHByaW50Zl91 bmZpbHRlcmVkIChtc2dfdHlwZSA9PSAwCi0JCQkgPyBfKCJTdGFydHVwIHRp bWU6ICVsZC4lMDZsZFxuIikKLQkJCSA6IF8oIkNvbW1hbmQgZXhlY3V0aW9u IHRpbWU6ICVsZC4lMDZsZFxuIiksCi0JCQkgY21kX3RpbWUgLyAxMDAwMDAw LCBjbWRfdGltZSAlIDEwMDAwMDApOworCQkJID8gXygiU3RhcnR1cCB0aW1l OiAlbGQuJTA2bGQgKGNwdSksICVsZC4lMDZsZCAod2FsbClcbiIpCisJCQkg OiBfKCJDb21tYW5kIGV4ZWN1dGlvbiB0aW1lOiAlbGQuJTA2bGQgKGNwdSks ICVsZC4lMDZsZCAod2FsbClcbiIpLAorCQkJIGNtZF90aW1lIC8gMTAwMDAw MCwgY21kX3RpbWUgJSAxMDAwMDAwLAorCQkJIGRlbHRhX3dhbGxfdGltZS50 dl9zZWMsIGRlbHRhX3dhbGxfdGltZS50dl91c2VjKTsKICAgICB9CiAKICAg aWYgKGRpc3BsYXlfc3BhY2UpCkBAIC03NjQsNyArNzcyLDggQEAgbWFrZV9j b21tYW5kX3N0YXRzX2NsZWFudXAgKGludCBtc2dfdHlwZQogI2VuZGlmCiAK ICAgbmV3X3N0YXQtPm1zZ190eXBlID0gbXNnX3R5cGU7Ci0gIG5ld19zdGF0 LT5zdGFydF90aW1lID0gZ2V0X3J1bl90aW1lICgpOworICBuZXdfc3RhdC0+ c3RhcnRfY3B1X3RpbWUgPSBnZXRfcnVuX3RpbWUgKCk7CisgIGdldHRpbWVv ZmRheSAoJm5ld19zdGF0LT5zdGFydF93YWxsX3RpbWUsIE5VTEwpOwogCiAg IHJldHVybiBtYWtlX2NsZWFudXBfZHRvciAocmVwb3J0X2NvbW1hbmRfc3Rh dHMsIG5ld19zdGF0LCB4ZnJlZSk7CiB9CkluZGV4OiBkb2MvZ2RiLnRleGlu Zm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMv c3JjL2dkYi9kb2MvZ2RiLnRleGluZm8sdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuODg4CmRpZmYgLXUgLXAgLXIxLjg4OCBnZGIudGV4aW5mbwotLS0gZG9j L2dkYi50ZXhpbmZvCTMgTm92IDIwMTEgMTQ6MzI6NDkgLTAwMDAJMS44ODgK KysrIGRvYy9nZGIudGV4aW5mbwkzIE5vdiAyMDExIDIzOjE2OjE2IC0wMDAw CkBAIC0zMjk5MSwxMyArMzI5OTEsMTYgQEAgc3dpdGNoIChAcHhyZWZ7TW9k ZSBPcHRpb25zfSkuCiBAa2luZGV4IG1haW50IHRpbWUKIEBjaW5kZXggdGlt ZSBvZiBjb21tYW5kIGV4ZWN1dGlvbgogQGl0ZW0gbWFpbnQgdGltZQotQ29u dHJvbCB3aGV0aGVyIHRvIGRpc3BsYXkgdGhlIGV4ZWN1dGlvbiB0aW1lIGZv ciBlYWNoIGNvbW1hbmQuICBJZgotc2V0IHRvIGEgbm9uemVybyB2YWx1ZSwg QHZhbHVle0dEQk59IHdpbGwgZGlzcGxheSBob3cgbXVjaCB0aW1lIGl0CitD b250cm9sIHdoZXRoZXIgdG8gZGlzcGxheSB0aGUgZXhlY3V0aW9uIHRpbWUg b2YgQHZhbHVle0dEQk59IGZvciBlYWNoIGNvbW1hbmQuCitJZiBzZXQgdG8g YSBub256ZXJvIHZhbHVlLCBAdmFsdWV7R0RCTn0gd2lsbCBkaXNwbGF5IGhv dyBtdWNoIHRpbWUgaXQKIHRvb2sgdG8gZXhlY3V0ZSBlYWNoIGNvbW1hbmQs IGZvbGxvd2luZyB0aGUgY29tbWFuZCdzIG93biBvdXRwdXQuCi1UaGUgdGlt ZSBpcyBub3QgcHJpbnRlZCBmb3IgdGhlIGNvbW1hbmRzIHRoYXQgcnVuIHRo ZSB0YXJnZXQsIHNpbmNlCi10aGVyZSdzIG5vIG1lY2hhbmlzbSBjdXJyZW50 bHkgdG8gY29tcHV0ZSBob3cgbXVjaCB0aW1lIHdhcyBzcGVuZAotYnkgQHZh bHVle0dEQk59IGFuZCBob3cgbXVjaCB0aW1lIHdhcyBzcGVuZCBieSB0aGUg cHJvZ3JhbSBiZWVuIGRlYnVnZ2VkLgotaXQncyBub3QgcG9zc2libHkgY3Vy cmVudGx5IAorQm90aCBjcHUgdGltZSBhbmQgd2FsbGNsb2NrIHRpbWUgYXJl IHByaW50ZWQuCitQcmludGluZyBib3RoIGlzIHVzZWZ1bCB3aGVuIHRyeWlu ZyB0byBkZXRlcm1pbmUgd2hldGhlciB0aGUgY29zdCBpcworY3B1IG9yLCBl LmcuLCBkaXNrL25ldHdvcmssIGxhdGVuY3kuCitOb3RlIHRoYXQgdGhlIGNw dSB0aW1lIHByaW50ZWQgaXMgZm9yIEB2YWx1ZXtHREJOfSBvbmx5LCBpdCBk b2VzIG5vdCBpbmNsdWRlCit0aGUgZXhlY3V0aW9uIHRpbWUgb2YgdGhlIGlu ZmVyaW9yIGJlY2F1c2UgdGhlcmUncyBubyBtZWNoYW5pc20gY3VycmVudGx5 Cit0byBjb21wdXRlIGhvdyBtdWNoIHRpbWUgd2FzIHNwZW50IGJ5IEB2YWx1 ZXtHREJOfSBhbmQgaG93IG11Y2ggdGltZSB3YXMKK3NwZW50IGJ5IHRoZSBw cm9ncmFtIGJlZW4gZGVidWdnZWQuCiBUaGlzIGNhbiBhbHNvIGJlIHJlcXVl c3RlZCBieSBpbnZva2luZyBAdmFsdWV7R0RCTn0gd2l0aCB0aGUKIEBvcHRp b257LS1zdGF0aXN0aWNzfSBjb21tYW5kLWxpbmUgc3dpdGNoIChAcHhyZWZ7 TW9kZSBPcHRpb25zfSkuCiAK --20cf3005deb4a15d6204b0dcc9f4--