From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-114386-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20002 invoked by alias); 18 Jul 2014 09:20:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 19989 invoked by uid 89); 18 Jul 2014 09:20:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vc0-f179.google.com
Received: from mail-vc0-f179.google.com (HELO mail-vc0-f179.google.com) (209.85.220.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 18 Jul 2014 09:20:06 +0000
Received: by mail-vc0-f179.google.com with SMTP id hq11so5316901vcb.24        for <gdb-patches@sourceware.org>; Fri, 18 Jul 2014 02:20:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=afkeTJEJVOt5kuYzS7KZjXqJGY+iPkvH3r0l4lvGvzg=;        b=W/SwhUaOIj7wPqZfMXB3OgBh4ysaIoWjBYSK4PSrt/qXsQR0Z1dMKjC/MnPQTEZDeZ         foJDzpWuJGIpY3047H/nsoL/kb4CKvXqf/XvEdtQvFmxgJwdTVET2NBtE2YT439b3dUJ         O8DWu+mc7Hr1MlQhxL21Gg/xmiyZ6KTcQiwHfIO1o8n6hEOlbY8s6I5pidd3yPeeeeXK         smPje2oTDdCuxyX1Xb8RJjqhHpZpIASncy/qPARV2IaRw6uKemAih6ZF8Kk+nqJkUFW7         42Y6S08G/oKbpr/tSIxXXD2aW9lBeHGNyuWGnacmnREWw2/11oCWQ7AK+unMbjiKi82N         rhYg==
X-Gm-Message-State: ALoCoQlYiWJQNFedadrPVZkojmbikGSEaW7bLy3jtfII/ORRDuIfemNEVQ/JvrElsuKrk0NFllHO
MIME-Version: 1.0
X-Received: by 10.221.56.132 with SMTP id wc4mr3647476vcb.38.1405675204665; Fri, 18 Jul 2014 02:20:04 -0700 (PDT)
Received: by 10.52.28.233 with HTTP; Fri, 18 Jul 2014 02:20:04 -0700 (PDT)
In-Reply-To: <20140718090630.GA17917@blade.nx>
References: <1405520243-17282-1-git-send-email-gbenson@redhat.com>	<1405520243-17282-2-git-send-email-gbenson@redhat.com>	<CADPb22TEuAHAsNg7L6h8We6hJKv0Wdj6vQL6yBbqGcUwRUYpkw@mail.gmail.com>	<20140717134728.GB31916@blade.nx>	<53C7E6AB.4080703@redhat.com>	<20140717153957.GA1921@blade.nx>	<53C7F5D6.6060102@redhat.com>	<20140718090630.GA17917@blade.nx>
Date: Fri, 18 Jul 2014 10:42:00 -0000
Message-ID: <CADPb22QMUz7XqD63_Xhr5qEXFqx+=H-2BqnfQGV_VFV==Ta3uA@mail.gmail.com>
Subject: Re: [PATCH 01/15 v3] Introduce common/errors.h
From: Doug Evans <dje@google.com>
To: Gary Benson <gbenson@redhat.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches <gdb-patches@sourceware.org>, 	Tom Tromey <tromey@redhat.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-07/txt/msg00491.txt.bz2

On Fri, Jul 18, 2014 at 10:06 AM, Gary Benson <gbenson@redhat.com> wrote:
> [...]
> /* Throw a fatal error, constructing the message using a printf-style
>    format string and a printf- or vprintf-style argument list.  This
>    function does not return.  The application will exit.  */
>
> extern void fatal (const char *fmt, ...)
>      ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
>
> extern void vfatal (const char *fmt, va_list args)
>      ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 0);
> [...]

Remember gdb doesn't exit on fatal().
fatal() in gdb is essentially ^c (quit() calls fatal()!).

Can I repeat my request to please document this in the function comment.