From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9767 invoked by alias); 8 Nov 2012 01:34:10 -0000 Received: (qmail 9563 invoked by uid 22791); 8 Nov 2012 01:34:09 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ob0-f169.google.com (HELO mail-ob0-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Nov 2012 01:34:04 +0000 Received: by mail-ob0-f169.google.com with SMTP id va7so2570647obc.0 for ; Wed, 07 Nov 2012 17:34:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=JRH/8XTlk2ZFxtWhDp2dhA1X96tYvWst3g3MMaFOmZ0=; b=IuX00QKjG8djfHu7lLmJ+giMva+Gr+TVJO98krHHfsV4hDMxqpizOvUvJSEJBZZ1c9 L9EDwF057mgnJBDAGaoa5u1lSc1D+hWKJLpfrOrm/StnftT2S3M0CeHmHAQ8awBRugVo eZpSgrvrcgXXsj151qmqyeb50DFbXaeDZ8lgWAPo5Z4uW/MelTJGZbtmFEpVRu1jQ+gB GdZgdOlls5PKgK9fayUIGiCkCqIU3zb3r8LA9LmEUmYuPIH4gbHHW8jH9H8XNwWg3UPP TEIScq2ZeK26y4RnjYRW22K6bGKB3BXGH7ALp31xCSjJRjU9CSBaSwV2aw01dmiLAYwn it8Q== MIME-Version: 1.0 Received: by 10.60.170.9 with SMTP id ai9mr3540266oec.36.1352338444310; Wed, 07 Nov 2012 17:34:04 -0800 (PST) Received: by 10.76.71.201 with HTTP; Wed, 7 Nov 2012 17:34:04 -0800 (PST) In-Reply-To: <20121107201107.25258.47267.stgit@brno.lan> References: <20121107201107.25258.47267.stgit@brno.lan> Date: Thu, 08 Nov 2012 01:34:00 -0000 Message-ID: Subject: Re: [PATCH] Always include defs.h first. From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnMqdrVTTbFgMm3C/9rogPAtQZF9QgcHaOE0VBvGxJmSNBQR7jK01Zlokvdm+JuvTW7nILDVNroPwJLZfuCQKntuBmxtUHWL15SXcuQWSPtTjpK6zPDCi9yzxUhGkzZAtRnjbJjcZfP5d6l4DLDBCS7sa+SMxgbCc7uxFmTKBsF+VUTFtqJSqP3ZtUlDMc2aYjvCLTbXYPdR1UiiAU4CDQivq+VnQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00169.txt.bz2 On Wed, Nov 7, 2012 at 12:11 PM, Pedro Alves wrote: > defs.h should always be the first included header in a .c file. In > turn, this means that a foo.h header should not need to include > defs.h, as the .c file always includes defs.h before including foo.h. fwiw, I like the idea of header files including what they themselves need, and not assuming the includer will do it for them, even for defs.h. It's something I'd like to see gdb move towards, but I'm not in a hurry. :-)