Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/2] New 'explore' command Python implementation (with docs)
Date: Tue, 10 Apr 2012 17:21:00 -0000	[thread overview]
Message-ID: <CADPb22QHL+=urer1c33dykhRmTiUyUmHpcH4n5vU179n23wLoA@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gw82wf+NwsSuyjaLUEVc9sL2jG2n2XP2MD3bywxBd2XTQ@mail.gmail.com>

Hi.
Thanks for persevering!

LGTM

I think all the doc issues are resolved, right Eli?

On Mon, Apr 9, 2012 at 11:37 AM, Siva Chandra <sivachandra@google.com> wrote:
> <ping>
>
> Is there sufficient interest in this?
>
> On Mon, Apr 2, 2012 at 11:28 AM, Siva Chandra <sivachandra@google.com> wrote:
>> Thanks Eli, I have fixed it. The complete patch is attached.
>>
>> Code ChangeLog:
>>
>> 2012-04-02  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>        New command 'explore' which helps explore values and types in
>>        scope.
>>        * NEWS: Add an entry about the new 'explore' command.
>>        * data-directory/Makefile.in: Add gdb/command/explore.py
>>        * python/lib/gdb/command/explore.py: Implemention of the 'explore'
>>        command using the GDB Python API.
>>
>> Docs ChangeLog:
>>
>> 2012-04-02  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>        * gdb.texinfo (Examining Data): Document the 'explore' command.
>>
>> Testsuite ChangeLog:
>>
>> 2012-04-02  Siva Chandra Reddy  <sivachandra@google.com>
>>
>>        * gdb.python/Makefile.in: Add py-explore to EXECUTABLES.
>>        * gdb.python/py-explore.c: C program used for testing the new
>>        'explore' command on C constructs.
>>        * gdb.python/py-explore.cc: C++ program used for testing the new
>>        'explore' command on C++ constructs.
>>        * gdb-python/py-explore.exp: Tests for the new 'explore'
>>        command on C constructs.
>>        * gdb-python/py-explore-cc.exp: Tests for the new 'explore'
>>        command on C++ constructs.
>>
>> Thanks,
>> Siva Chandra


  reply	other threads:[~2012-04-10 17:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 11:29 Siva Chandra
2012-03-09  8:57 ` Eli Zaretskii
2012-03-21 12:35   ` Siva Chandra
2012-03-24 14:02     ` Eli Zaretskii
2012-03-26  7:24       ` Siva Chandra
2012-03-31  9:58         ` Eli Zaretskii
2012-04-02  5:58           ` Siva Chandra
2012-04-09 18:37             ` Siva Chandra
2012-04-10 17:21               ` Doug Evans [this message]
2012-04-10 17:22                 ` Eli Zaretskii
2012-04-10 18:59                 ` Doug Evans
2012-04-11  6:29                   ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22QHL+=urer1c33dykhRmTiUyUmHpcH4n5vU179n23wLoA@mail.gmail.com' \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox