From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8027 invoked by alias); 9 Oct 2013 02:05:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8013 invoked by uid 89); 9 Oct 2013 02:05:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vb0-f42.google.com Received: from mail-vb0-f42.google.com (HELO mail-vb0-f42.google.com) (209.85.212.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 09 Oct 2013 02:05:06 +0000 Received: by mail-vb0-f42.google.com with SMTP id e12so87083vbg.15 for ; Tue, 08 Oct 2013 19:05:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=oPAZnE4UzuLk8aCEtwtztTcpA2EscREDfbWIaG20YSI=; b=FwTSqbvZD0sAE2cd3DJ44M06ZQZbnDNlKGGbCBoN3cfsBfH5fRCVGOvNyVrA0lQ1zu 5Koxul5HCM8NTyU5zDEuvceofPx8q4ilEw3Mam61PQYJFE0Vv/2cHh70W6jEhjBAnk04 rCXLJDn/qDNsmcd78S05LDQPoI3+eqe1RbdQ+jaKTun/+coT76gfpez99HzyerkoHtIR Q2e0ToLd9TI6eoZWnFYEyl1hqvAqG9GKY8RdXEmkm6qRxo1jm2T7KuSyPuddDGfBMeyk cODm6jKRQLMQsO6NidwmYoImQaurxY1kKHVK/HeVVRd7E/tvhHG3umCRxhylADXBs2IH a0Ww== X-Gm-Message-State: ALoCoQnQ/1qL7ZlOLOcDbIRuEGT2me7mdCOiAcD9ScdlZXRuBjI62nF4lq6Rfgj6CifCWaKZvlItyB8lVjqp15EYqLD46E4YGsuUeUPlTiHV7X2yoOREGjcmMnRH5BbPa/EjIgRDtO2lC+DvIkHu58SMgc6HQcaGk7Vqrl9Bqca8NlYRXanixB5vr08xrbX+lp+JgzS6Ig6NS8gfXaBbYdI6h96sqfqWsA== MIME-Version: 1.0 X-Received: by 10.52.74.100 with SMTP id s4mr39177vdv.35.1381284304114; Tue, 08 Oct 2013 19:05:04 -0700 (PDT) Received: by 10.52.37.138 with HTTP; Tue, 8 Oct 2013 19:05:03 -0700 (PDT) In-Reply-To: <20131008141639.GF3092@adacore.com> References: <87bo6affrh.fsf@fleche.redhat.com> <524ECCBB.5050307@gmail.com> <20131008035636.GC3092@adacore.com> <5253F497.6040709@redhat.com> <20131008141639.GF3092@adacore.com> Date: Wed, 09 Oct 2013 02:05:00 -0000 Message-ID: Subject: Re: [RFA/code+NEWS] new "set/show serial baud" command (was: "Re: Setting parity for remote serial") From: Doug Evans To: Joel Brobecker Cc: Pedro Alves , Yurij Grechishhev , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00246.txt.bz2 On Tue, Oct 8, 2013 at 7:16 AM, Joel Brobecker wrote: >> > I'd rather we do it right the first time. If we're a go with >> > the "set serial baud" command, I don't mind taking care of >> > that part. As Pedro hints, it's a fairly easy change to make. >> > >> > Pedro, should we go ahead? It's only been a day or two, but we haven't >> > had any objection so far. >> >> Yeah, I think so. > > Attached is a patch that implements that. > > gdb/ChangeLog: > > * cli/cli-cmds.c (show_baud_rate): Moved to serial.c as > serial_baud_show_cmd. > (_initialize_cli_cmds): Delete the code creating the > "set/show remotebaud" commands. > * serial.c (baud_rate): Move here from top.c. > (serial_baud_show_cmd): Move here from cli/cli-cmds.c. > (_initialize_serial): Create "set/show serial baud" commands. > Add "set/show remotebaud" command aliases. > * top.c (baud_rate): Moved to serial.c. > * NEWS: Document the new "set/show serial baud" commands, > replacing "set/show remotebaud". > > Tested on x86_64-linux, with no regression (I almost expected one, > as we used to test thhe output "help set", or soemthing like that). > > OK to commit? > > Thanks, > -- > Joel + /* The commands "set/show serial baud" used to have a different name. + Add aliases to those names to facilitate the transition. */ + add_alias_cmd ("remotebaud", "serial baud", no_class, 0, &setlist); + add_alias_cmd ("remotebaud", "serial baud", no_class, 0, &showlist); Does the mark-as-deprecated machinery work here?