From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16112 invoked by alias); 8 Oct 2014 17:12:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16100 invoked by uid 89); 8 Oct 2014 17:12:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 08 Oct 2014 17:12:39 +0000 Received: by mail-vc0-f174.google.com with SMTP id hq12so7017110vcb.5 for ; Wed, 08 Oct 2014 10:12:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=dI3IJkzpf/lnYOCdp2tBJKP4NSwzqnmJNnHCSbKiAaw=; b=aJZYtw/lG2Ziahanjs0H3zOxH6tYWuScAE4EV9Wh2/IenpjzKPqwtGBCJhQRhoNHbi ub0MoL6aa0ZFh9KzSzO12OsipFTrVaXfkClX9gvUhIX4jMW/2HwDn9X30aBcUdbx845x lj3Ky6AvrP4F9O4LXfOTa2+zJUGlPWNJmKWQybhVVDGID+KnlRwEMZPkpVHNUX9boYwx bYmHSaS/7o34HsFRYhaApWXQVIUYaUPI7UTOEsS5bnvGpAGQwA8rkqXqlCNk4GG/rYIu A8nqAIO56GsTfhOppoC4UkBxasXbg1P90jxawoxM5EUpAkAERGWM3cW0YpTKeMDouV5q znog== X-Gm-Message-State: ALoCoQl1UCkDWN/Vog7URDcCO3pZWkhMuHfsD42FtMsI9eIqRBO6pQBdy0U3TJu3eUVaiDdxH67n MIME-Version: 1.0 X-Received: by 10.52.240.135 with SMTP id wa7mr9054337vdc.82.1412788357459; Wed, 08 Oct 2014 10:12:37 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Wed, 8 Oct 2014 10:12:37 -0700 (PDT) In-Reply-To: References: <1409586154-16196-1-git-send-email-gbenson@redhat.com> <1409586154-16196-2-git-send-email-gbenson@redhat.com> Date: Wed, 08 Oct 2014 17:12:00 -0000 Message-ID: Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions From: Doug Evans To: Gary Benson Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00160.txt.bz2 On Wed, Oct 8, 2014 at 1:03 PM, Doug Evans wrote: > On Mon, Sep 1, 2014 at 11:42 AM, Gary Benson wrote: >> defs.h includes utils.h, and utils.h includes exceptions.h. All GDB >> .c files include defs.h as their first line, so no file other than >> utils.h needs to include exceptions.h. This commit removes all such >> inclusions. >> >> Doug, I Cc'd you on this one as you asked me to avoid giant mechanical >> ChangeLog entries but I couldn't figure out how I'd rewrite this one. > > For reference sake, > I said that for two reasons: > 1) to save you some typing > 2) to keep the S/N ratio of the ChangeLog file from dropping, and in > this case from dropping significantly. Yikes! > >> gdb/ChangeLog: >> >> * ada-lang.c: Do not include exceptions.h. >> * ada-valprint.c: Likewise. >> * amd64-tdep.c: Likewise. >> [...] > > I realize one of the guidelines for changelogs is to document every > file that's changed, but if we can agree that "All callers updated." > can apply to all callers in all files, then I don't see why we > couldn't be ok with something like the following for this case: > > * All .c files: Do not include exceptions.h. > > Yeah, it's not pedantically correct, not all .c files were touched. > But I can live with that given the alternative. Actually, exceptions.c still includes exceptions.h. I'd be ok with changing the above entry to "* Most .c files: Do not include exceptions.h." Plus, was not removing exceptions.h from exceptions.c an oversight? [I can't remember if this was discussed in the thread.]