From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8541 invoked by alias); 9 Oct 2013 23:56:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8529 invoked by uid 89); 9 Oct 2013 23:56:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vb0-f44.google.com Received: from mail-vb0-f44.google.com (HELO mail-vb0-f44.google.com) (209.85.212.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 09 Oct 2013 23:56:16 +0000 Received: by mail-vb0-f44.google.com with SMTP id e13so1093021vbg.3 for ; Wed, 09 Oct 2013 16:56:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=j2/FqROnMGT+FyAzj4x8dqJX7Ed0JvOVRD86pBewMfo=; b=WF86AxLRnZymF+TQZQUyQ6HQ/HGZ69uRQXD1yUeEwQhG2WTWxmHhDmsJXaPET+HPbt vAEAXXNCR+Bi5ROF8XWeCSLDVr5+GXgeQr2suC4KwUeSRGUCxQGcWVXdnd+Tc/4VHGsX tdhmu/eT8ORyOoCXv73WK6fZ2F26EXfqY1AYowqdrligunxQyG0jwO0H47U6MVtHW0h+ 1fz+InHb7lbacL3wTY5gsKRnFnRVGq5qiiuTmxzyjIsv19VlAzRoSj0VCvGo/YbH2Jnb RLLWbroml++mAR5YoUBVYfDuBD8Gf/IGjXa48Wdm1ofRkzm6K0woXzanpBtfN3K6Unp/ GPAw== X-Gm-Message-State: ALoCoQn3BB0eWmqTDLCSckciLOulexRlntYe9aM9VIjMUlMd/LQrw1J2rrIGJWazjFJM5VI0jT+YQgsvaeEUbUKmep4zCOOuAg3mYoX3vR1SRtr22iHDcDdV/umfnOmCC49BxrD+jJUC9hnNLzIrwylRrkfrzrkiObw7MHc0aV2Vcl9PSviuvojNaYWyB+aC7sbK/SAN5b2mfCs0gC9hnBkf26218Y9uYw== MIME-Version: 1.0 X-Received: by 10.220.98.212 with SMTP id r20mr2142406vcn.48.1381362973920; Wed, 09 Oct 2013 16:56:13 -0700 (PDT) Received: by 10.52.37.138 with HTTP; Wed, 9 Oct 2013 16:56:13 -0700 (PDT) In-Reply-To: <5255EBB3.1050700@codesourcery.com> References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> <1379512482-31773-6-git-send-email-yao@codesourcery.com> <21068.21875.734416.904684@ruffy.mtv.corp.google.com> <20131008045901.GE3092@adacore.com> <5255EBB3.1050700@codesourcery.com> Date: Wed, 09 Oct 2013 23:56:00 -0000 Message-ID: Subject: Re: [PATCH 5/7] New lang-varobj.h From: Doug Evans To: Yao Qi Cc: Joel Brobecker , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00325.txt.bz2 On Wed, Oct 9, 2013 at 4:50 PM, Yao Qi wrote: > On 10/08/2013 12:59 PM, Joel Brobecker wrote: >>> >>> >How about move lang-varobj.h into varobj.h? >> >> Not very important in the grand scheme of things, but I tend to agree >> with the suggestion. If we had a lang-varobj.c, things might be >> different. But for a simple definition of the language-specific ops >> directly related to varobj, I'd keep things simple, inside varobj.h. > > > We don't have lang-varobj.c, but we'll have c-varobj.c, jv-varobj.c and > ada-varobj.c [done by patch 6/7]. Is it strong enough to justify creating > new file lang-varobj.h? "Well ..." All it has is one struct, there's not much point to it right now.