From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21358 invoked by alias); 11 Jun 2012 21:08:20 -0000 Received: (qmail 21344 invoked by uid 22791); 11 Jun 2012 21:08:19 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 21:08:06 +0000 Received: by vcbfl10 with SMTP id fl10so2983524vcb.0 for ; Mon, 11 Jun 2012 14:08:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=PYBE4sLe/h8Ak4O2EnqVm1HPbugH/wb16erHwZgnfLI=; b=lA0gjiO9VH27amCpq+Dni5yymXm+/+TpObb85d90pEFzGWETy4TL4dYScwG0eSR4Tx dl9fEapn8tu8NcQjOLoZVpxN7gAn8crpw2gfmYkLAJH9moIRtz/R4m/1ztH8Ii+Iv1on DrrdTciD1/84eadfKQpUa/qWCRxHee5Er7f09/vGKTHbXDwHYEbiVNKT/qgk3sFSTKkT uq8iai79pXc8Al/PinupuDHsfE5M1t2dWECN3ymyvNTG0u4/n/kc6lcvMgDOnCHSwvFq paJfSMtAPggOaoFpT5uie9ymcLrNGt9KenINT4ONotfPmxPxuDb1r+Nil7R1+gUjxPYi RSzw== Received: by 10.52.33.35 with SMTP id o3mr11101589vdi.95.1339448886116; Mon, 11 Jun 2012 14:08:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.33.35 with SMTP id o3mr11101578vdi.95.1339448885867; Mon, 11 Jun 2012 14:08:05 -0700 (PDT) Received: by 10.52.161.199 with HTTP; Mon, 11 Jun 2012 14:08:05 -0700 (PDT) In-Reply-To: <87txyh7ejn.fsf@fleche.redhat.com> References: <87d3558zcz.fsf@fleche.redhat.com> <87txyh7ejn.fsf@fleche.redhat.com> Date: Mon, 11 Jun 2012 21:08:00 -0000 Message-ID: Subject: Re: FYI: fix latent bug in dw2_find_symbol_file From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQk3mKxzURlVLv+UMfw2hVj+2M5YWNI96ApVifR22tJuvH7b2mG56qVfsn79VjMMwtYDLmS3SoaNhHJNHJLJALdWlbUYlejQdXkqw8ttIk/Y3VmmP9HCx4b+JmCuJB/cejP6j+ejTYbDlft+1jOREAjr/OdNSA== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00316.txt.bz2 On Mon, Jun 11, 2012 at 1:57 PM, Tom Tromey wrote: >>>>>> "Doug" =3D=3D Doug Evans writes: > > Doug> You need to call init_cutu_and_read_dies in both debug-types and > Doug> non-debug-types cases. =A0When DWO files are in use DW_AT_name lives > Doug> in the DWO file. =A0OTOH TUs typically don't have DW_AT_name (you > Doug> need to look at DW_AT_decl_file). =A0OTOOH this function is only > Doug> called by find_main_filename. > > What gcc branch should I use to test this? > And do I need gold? > > Doug> I'm tempted to rename the routine {,*_}find_function_file (or some > Doug> such) and have dw2_find_symbol_file ignore TUs. > > Fine by me, but I don't plan to do it. Well, there's only 5 or so places you need to change for the renaming. :-) What I'm saying is the patch is wrong for TUs but TUs are irrelevant here anyway. What did you want to test?