From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27930 invoked by alias); 27 Jul 2013 17:10:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27909 invoked by uid 89); 27 Jul 2013 17:10:55 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-oa0-f54.google.com) (209.85.219.54) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 27 Jul 2013 17:10:54 +0000 Received: by mail-oa0-f54.google.com with SMTP id o17so805020oag.13 for ; Sat, 27 Jul 2013 10:10:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=SQpSk8QYid/yJX/kyVt4Uuu1UOdmUNWm1NXg0TDkuCs=; b=NHuOeWRdtJocwAxkzjV2NM/ZsSuRes8I+/r2nOADOlQxRXRZDVD0mi/NjEslkL2p47 Qj50/X/+IK8PrwhEncrbZnYZf+CoIAjzdTHNfjFVDsYgj7Pl7m5UGv76Ux7OqOWZu0Ww ASMExgcU6ZLwT0/1H6Fi+vpJA4/XfZDg6ULx9QUADwBfRQWJOOblmm7utj3K1bNvNyYH tHW5+StU9iwl1opG/1ksmhE82bq6T7fk/47k0CCzFUlKsxs0KTktMls9+Xh09H4oSHOH mbp96qDzwI/J0LoBezOxDewfITxlGyM0bIRW1q5VIhn08lV9Yme+lpVezrn4Hx3nOsft sAJQ== MIME-Version: 1.0 X-Received: by 10.50.7.1 with SMTP id f1mr332628iga.48.1374945047305; Sat, 27 Jul 2013 10:10:47 -0700 (PDT) Received: by 10.64.239.148 with HTTP; Sat, 27 Jul 2013 10:10:47 -0700 (PDT) In-Reply-To: <1374869594-16965-5-git-send-email-sergiodj@redhat.com> References: <1374869594-16965-1-git-send-email-sergiodj@redhat.com> <1374869594-16965-5-git-send-email-sergiodj@redhat.com> Date: Sat, 27 Jul 2013 17:10:00 -0000 Message-ID: Subject: Re: [PATCH 4/7] AVR support From: Doug Evans To: Sergio Durigan Junior Cc: GDB Patches , Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnMTANVgSwnQkr/YzYN0w1ItkjUlY1gzqV7lc/VWEGMuTBbfvqhxSWJPrxIBI/se0wNf7PRyfiRNbsN8/UWeOOky4vktT/3/gg7o0tk1Vyg2qd4+Pj52xLEbi7K0kFGdBYj6nfzK20sngnXt62C9hA5/Kz3CY+uyc4zYP7Ek+rIKlu1DrvW6LWhsoSTjBOsmEGBrlfUgBCgipgldZ7w60N9r2mbag== X-SW-Source: 2013-07/txt/msg00661.txt.bz2 Hi. Just a nit. On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior wrote: > Support for the AVR architecture. More of the same. Defining an enum > containing the differences between Linux kernel generic and AVR signals, > and treat them on avr_linux_gdb_signal_{to,from}_target. In this case, > the only difference is the SIGRTMAX. > > 2013-07-26 Sergio Durigan Junior > > * avr-tdep.c: Define enum with differences between Linux kernel > and AVR signals. > (avr_linux_gdb_signal_from_target): New function. > (avr_linux_gdb_signal_to_target): Likewise. > (avr_gdbarch_init): Set gdbarch_gdb_signal_{to,from}_target to > the functions mentioned above. > [...] > + /* GDB_SIGNAL_REALTIME_33 to _63 are continuous. > + Nit: Either delete this blank line or move it to after the comment. > + AVR does not have _64. */ > + if (signal >= GDB_SIGNAL_REALTIME_33 > + && signal <= GDB_SIGNAL_REALTIME_63) > + { > + int offset = signal - GDB_SIGNAL_REALTIME_33; > + > + return AVR_LINUX_SIGRTMIN + 1 + offset; > + } > [...]