From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62829 invoked by alias); 12 May 2015 21:47:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62802 invoked by uid 89); 12 May 2015 21:47:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 12 May 2015 21:47:20 +0000 Received: by obbkp3 with SMTP id kp3so15986805obb.3 for ; Tue, 12 May 2015 14:47:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=O5kIPROMurOLe0bNJtAGUHs9XbIDajGnNgnATBvSu/E=; b=Uhpx+l7VTIQwu6icyGwcio50Vc4ECMC/RNg0BPPLLeuPppn2KxHQltS+tc8g+0pvn2 i8F+42LvWwJ6sZTL3BIn8dKoGf6Gbi0kPXU3/EuZ0XuQG4AqXDCa5wE3IMnOu7jfui9O yx6ZzJrypWxawL5nvu0MhVV+Q+HMgTUR3I2j0CT1K1cczcMa0CM6n6EIJFcFzdbC5chA MFijj7oChb+gTRJ0hkrI/lZsnZs0Q5bdO9tiZHJSPkU34wvvEBPGXPAha7ofbwtfhcT3 9IvSleL21AsrJEV/G6F3x6/4a7RPGkj9vzVSghcjT2iJIVBnSfIhbzY2+o3siFokXNWS 5wqA== X-Gm-Message-State: ALoCoQnj3vza3M01lKfBuHFnNv6yWH+w6S51hBJYEOaNFzB4J9SqlM1t1D6CLDg/vr3d8YdysENX MIME-Version: 1.0 X-Received: by 10.182.70.100 with SMTP id l4mr13472904obu.77.1431467238678; Tue, 12 May 2015 14:47:18 -0700 (PDT) Received: by 10.182.89.99 with HTTP; Tue, 12 May 2015 14:47:18 -0700 (PDT) In-Reply-To: <001a11c3b928756ec20515e95aba@google.com> References: <001a11c3b928756ec20515e95aba@google.com> Date: Tue, 12 May 2015 21:47:00 -0000 Message-ID: Subject: Fwd: [PATCH v4 0/4] catch syscall group From: Doug Evans To: Gabriel Krisman Bertazi , gdb-patches Cc: Sergio Durigan Junior , Pedro Alves Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00288.txt.bz2 Hi. The message to the list bounced, but I'm not sure why (this is text/plain not html). Apologies for the resend. ---------- Forwarded message ---------- From: Doug Evans Date: Tue, May 12, 2015 at 2:41 PM Subject: Re: [PATCH v4 0/4] catch syscall group To: Gabriel Krisman Bertazi Cc: sergiodj@redhat.com, palves@redhat.com, gdb-patches@sourceware.org Gabriel Krisman Bertazi writes: > Thank you both for your review. > > This version has the following improvements: > > * Apply fixes suggested by Sergio in the testsuite. > * Use xsltproc to generate the xml files. > > Regarding the last change, it allowed me to identify inconsistencies in > groups for some architectures. The current design makes sure these > inconsistencies are fixed by centralizing the group information in a > single file. > > Also, this patch series *does not* include the generated files because > they are too big and can get in the way of code review. Reviewers must > generate those files by hand by entering the gdb/syscalls directory and > running the makefile there. Build will fail if reviewer don't do this! > Once we get this approved, I'll make sure to include the generated files > in the commit before pushing. Hopefully this will make code review > easier. This sounds like something we should key off of --enable-maintainer-mode. [we *could* use a different option if people are wedded to --enable-maintainer-mode affecting only autogen files, but that seems like overkill] IIRC we don't do that for, e.g., gdbarch.sh -> gdbarch.[ch], but that's a mistake IMO. Let's get it right here. It will mean that configuring with --enable-maintainer-mode will now require xsltproc, but that's the price of going down this path, let's not hide it. [maybe that's a good reason to use something other than --enable-maintainer-mode, but 1) how often do people configure with --enable-maintainer-mode, and 2) maintainers are expected to know and accept these dependencies]