From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18453 invoked by alias); 10 Apr 2012 17:22:42 -0000 Received: (qmail 18441 invoked by uid 22791); 10 Apr 2012 17:22:41 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Apr 2012 17:22:27 +0000 Received: by vcbfk14 with SMTP id fk14so38729vcb.0 for ; Tue, 10 Apr 2012 10:22:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=E4tkU6OK6ClxV3WTkhhWYC04vOKPdKsNSCtE/K5rfOw=; b=O4ye6lK1M6IQO6mxYYK4/R8IpGRH0FoPN6Q2P9oiU4uiHo8Tag4gGBkkrtXjxnXXlB VSbog5QKGfK5TrqQO0Atrp2pCNO7mmY43BSm9uetxCiDARDtbgz/pXawvrfXm2Hcrvji mkiSBEwApJUwbRC8JzyA4NbFyGGBuHAuLtFibY/dYVLm28w8o/tA0Znpx47Lx1aby9CB xWr/PN1K36iWMmxKR9ARRzhGISGwFM0nxk7u5S5bVyr5r+ILOHKolwYdx7KSqvpqVDdv 8CR89rvzS+00liPePM08hi/vcWEwL+l2qDv5AxrKoADGlN1vQBEu1A77EUD/cW2jUaGu RaTQ== Received: by 10.52.98.200 with SMTP id ek8mr5045059vdb.36.1334078547005; Tue, 10 Apr 2012 10:22:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.98.200 with SMTP id ek8mr5045053vdb.36.1334078546809; Tue, 10 Apr 2012 10:22:26 -0700 (PDT) Received: by 10.220.73.14 with HTTP; Tue, 10 Apr 2012 10:22:26 -0700 (PDT) In-Reply-To: References: <837gyu17am.fsf@gnu.org> <83haxet7vh.fsf@gnu.org> <83sjgpjdnm.fsf@gnu.org> Date: Tue, 10 Apr 2012 18:59:00 -0000 Message-ID: Subject: Re: [patch 2/2] New 'explore' command Python implementation (with docs) From: Doug Evans To: Siva Chandra Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQkjnVu3ZV9aqqYUR/crQ5i034zbk482x7wd1N4J9dXuUqYZqgWe5Gcm1/tLxDLBWs0xpz8syXSRmlf26QFYkk9TCWqiLhZhJbSf0/b2ri4yY+7gjRnogfOdDdyzaKamzbYA7DRwKfqQIbSrp9DuEIBRNo64fg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00188.txt.bz2 Playing with it a bit, I think we might want to tweak the output a bit (remove the repetitive "... to explore this field ..."), but I don't want to hold this patch up any longer, so I'm happy to leave that for a later pass. 'struct dwarf2_cu' is a struct/class with the following fields: objfile =3D header =3D base_address =3D base_known =3D language =3D language_defn =3D producer =3D list_in_scope =3D dwarf2_abbrevs =3D abbrev_obstack =3D partial_dies =3D comp_unit_obstack =3D read_in_chain =3D per_cu =3D last_used =3D die_hash =3D dies =3D dependencies =3D line_header =3D method_list =3D call_site_htab =3D mark =3D has_loclist =3D checked_producer =3D producer_is_gxx_lt_4_6 =3D On Tue, Apr 10, 2012 at 10:16 AM, Doug Evans wrote: > Hi. > Thanks for persevering! > > LGTM > > I think all the doc issues are resolved, right Eli? > > On Mon, Apr 9, 2012 at 11:37 AM, Siva Chandra wr= ote: >> >> >> Is there sufficient interest in this? >> >> On Mon, Apr 2, 2012 at 11:28 AM, Siva Chandra w= rote: >>> Thanks Eli, I have fixed it. The complete patch is attached. >>> >>> Code ChangeLog: >>> >>> 2012-04-02 =A0Siva Chandra Reddy =A0 >>> >>> =A0 =A0 =A0 =A0New command 'explore' which helps explore values and typ= es in >>> =A0 =A0 =A0 =A0scope. >>> =A0 =A0 =A0 =A0* NEWS: Add an entry about the new 'explore' command. >>> =A0 =A0 =A0 =A0* data-directory/Makefile.in: Add gdb/command/explore.py >>> =A0 =A0 =A0 =A0* python/lib/gdb/command/explore.py: Implemention of the= 'explore' >>> =A0 =A0 =A0 =A0command using the GDB Python API. >>> >>> Docs ChangeLog: >>> >>> 2012-04-02 =A0Siva Chandra Reddy =A0 >>> >>> =A0 =A0 =A0 =A0* gdb.texinfo (Examining Data): Document the 'explore' c= ommand. >>> >>> Testsuite ChangeLog: >>> >>> 2012-04-02 =A0Siva Chandra Reddy =A0 >>> >>> =A0 =A0 =A0 =A0* gdb.python/Makefile.in: Add py-explore to EXECUTABLES. >>> =A0 =A0 =A0 =A0* gdb.python/py-explore.c: C program used for testing th= e new >>> =A0 =A0 =A0 =A0'explore' command on C constructs. >>> =A0 =A0 =A0 =A0* gdb.python/py-explore.cc: C++ program used for testing= the new >>> =A0 =A0 =A0 =A0'explore' command on C++ constructs. >>> =A0 =A0 =A0 =A0* gdb-python/py-explore.exp: Tests for the new 'explore' >>> =A0 =A0 =A0 =A0command on C constructs. >>> =A0 =A0 =A0 =A0* gdb-python/py-explore-cc.exp: Tests for the new 'explo= re' >>> =A0 =A0 =A0 =A0command on C++ constructs. >>> >>> Thanks, >>> Siva Chandra