From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11083 invoked by alias); 14 Mar 2013 16:57:33 -0000 Received: (qmail 11073 invoked by uid 22791); 14 Mar 2013 16:57:31 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f173.google.com (HELO mail-vc0-f173.google.com) (209.85.220.173) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 16:57:26 +0000 Received: by mail-vc0-f173.google.com with SMTP id gd11so551123vcb.18 for ; Thu, 14 Mar 2013 09:57:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=8oybfUkBZgqflqSUD2cGvOw8thiLftv9/JnQRYfuoJI=; b=Ibko+olJ/LdBYWFoSaFHofG27Pb1YIzRKKYigoiAyp6lcPPSMyEF8Ceq9Qp3Ma1NEB sZXvMVKW7HCjVi93mm3uk9yYbS4yGcBkok5b5m/ZB35fJd47yhbkfTDpukGl3KILFz4A QnhvIK+W3R7AYXRhTVMjWYP6Nmmqucrt0IDe7jMhsRV0w5KaRMsETkOF6DgGkYp7nvyR qOvpDWytwNKdggAHjLl4MoLLrtdrYMOAAKn0DhcR2vgSoCGb8qx0CkKYEi2MbkWC5m8m b9yOd6mgucZu8NkYW8sd4mRRFf5xGUSs71LY+5fiEGBeMk4rjdcY0LPL1hjlbFj2j6cZ EHxA== MIME-Version: 1.0 X-Received: by 10.52.16.230 with SMTP id j6mr2342343vdd.127.1363280245640; Thu, 14 Mar 2013 09:57:25 -0700 (PDT) Received: by 10.221.1.71 with HTTP; Thu, 14 Mar 2013 09:57:25 -0700 (PDT) In-Reply-To: <871ubjawq8.fsf@fleche.redhat.com> References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-4-git-send-email-yao@codesourcery.com> <871ubjawq8.fsf@fleche.redhat.com> Date: Thu, 14 Mar 2013 16:57:00 -0000 Message-ID: Subject: Re: [PATCH v3 03/15] Read CTF by the ctf target From: Doug Evans To: Tom Tromey Cc: Yao Qi , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQloGKiKxgMIcwTPUvmsGIPxJid8Qb0ccTcRoHsss+fMexg7rz/KWjqMC4Kiqozzf19sVsCpmYnHyTC6Yg3aOZCtdkwN+nBCMUyo6QtWA9fSlLoLKndsfuZmmZsLwhzQzKSucfxr2UwB/eIvKVp3CZxQZHAacdyPKhZ33XqiAkatV0Sp/t+cq6TNVgNDq0aG2hgLYYAmeZl8JTNoLZTPjBdRMKZGVQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00639.txt.bz2 On Wed, Mar 13, 2013 at 1:08 PM, Tom Tromey wrote: >>>>>> "Yao" == Yao Qi writes: > > Yao> +AC_ARG_WITH(babeltrace, > Yao> + AC_HELP_STRING([--with-babeltrace], > Yao> + [Specify prefix directory for the installed > Yao> + BABELTRACE package Equivalent to > Yao> + --with-babeltrace-include=PATH/include > Yao> + plus --with-babeltrace-lib=PATH/lib])) > > I think this is missing a period and a space between "package" and > "Equivalent", but see below. > > Yao> +if test "x$with_bt_include" != x; then > Yao> + LIBBABELTRACE_CFLAGS="-I$with_bt_include " > Yao> +fi > Yao> +if test "x$with_bt_lib" != x; then > Yao> + LIBBABELTRACE="-L$with_bt_lib -lbabeltrace -lbabeltrace-ctf" > Yao> +fi > Yao> + > Yao> +if test "x$with_babeltrace" != "xno"; then > > This only checks for libbabeltrace if --with-babeltrace is specified. > So, the text above about equivalency isn't really correct, at least the > way I read it; if you want to give --with-babeltrace-include, you have > to also give --with-babeltrace. > > I'm not sure how to reword the above to make it more clear. > Perhaps spelling out the options. Is there a compelling need for with-babeltrace-{include,lib}? We don't have with-expat-{include,lib} for example. I think we should punt on them for now if there's no real need for them. > Unfortunately for you there is plenty of this patch I don't feel > competent to review. I don't know much about the target API. > > If nobody else looks after a decent interval, ping me and I will ok it. > I suppose if these methods parallel the existing tfile target, then that > is pretty good evidence for it being ok. The nice thing here is that I don't mind of the implementation isn't 100% perfect. [We're not adding something to an API for example.] It looks good enough to me (and in such areas I like giving people some freedom).