From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92680-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3636 invoked by alias); 10 Jul 2012 17:26:00 -0000
Received: (qmail 3622 invoked by uid 22791); 10 Jul 2012 17:25:59 -0000
X-SWARE-Spam-Status: No, hits=-5.5 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jul 2012 17:25:46 +0000
Received: by vbkv13 with SMTP id v13so212189vbk.0        for <gdb-patches@sourceware.org>; Tue, 10 Jul 2012 10:25:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:in-reply-to:references:date:message-id:subject:from:to         :cc:content-type:x-system-of-record:x-gm-message-state;        bh=7dACuSXGdLmbLCBfql2hqrSbaXH4mhg47CZvcl9dRdw=;        b=pSLnzu68384/DwthR5cwyKCE8zzePQ2oiaF1ZqDLIYtI6LBVwEU4S86MJXw2Fd1TIK         5eRSF37+JzXQKMLJt/YIHSHFJvXZ1lTMM0hppdt5mCxIrC7DB3Y7hxYnsajunPfjX9f5         Dqz2Q+ALdZctozffPL7WdlBsjMz075/rhkd4KPCFxtRIDIwhN9kZk4caGqbyYZqx/uJ2         qVyX40gPKpT5pMi2ZbvEwDpKr6slQIXfRlMUhxrslpYvZ+21rakhEDckLwJQMo2suFzO         Rr7b0kXNgS/M85jJDjOdzdf6A3tY7pUVGbKWvf7Ba52++HWfYoPR2UkeW2EVy+8dHHbd         uBxg==
Received: by 10.52.33.47 with SMTP id o15mr18411285vdi.73.1341941145720;        Tue, 10 Jul 2012 10:25:45 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.52.33.47 with SMTP id o15mr18411279vdi.73.1341941145647; Tue, 10 Jul 2012 10:25:45 -0700 (PDT)
Received: by 10.52.34.45 with HTTP; Tue, 10 Jul 2012 10:25:45 -0700 (PDT)
In-Reply-To: <87629vip17.fsf@fleche.redhat.com>
References: <20120710003324.100001E13A1@ruffy2.mtv.corp.google.com>	<87629vip17.fsf@fleche.redhat.com>
Date: Tue, 10 Jul 2012 17:26:00 -0000
Message-ID: <CADPb22Q3zaL7WbNFSjMsmQw4rsVvadmsaLoPuZ3NbOtfUnigyQ@mail.gmail.com>
Subject: Re: [RFA] symtab.c: Set "first" to zero.
From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-System-Of-Record: true
X-Gm-Message-State: ALoCoQktCLECR+k8y/0TrKTMGwgUo5QIs3xVuP77HeZq/ooNrmjCXoLONpM8QH5m2Pb06oIoUTMVFhiK0upVUjenwCkjEWjMEXR0NycS2+52jB8Mhem/cKDznIEqOapVSEnxbjHF96S4ff+eAvHrN6eCYVJNLWm0ENs8rtoLS1095xeJnrsMCFA9r9FcWKWnkDbgev5aLvSN
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00136.txt.bz2

On Tue, Jul 10, 2012 at 9:01 AM, Tom Tromey <tromey@redhat.com> wrote:
>
> >>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> 2012-07-09  Doug Evans  <dje@google.com>
> Doug>   * symtab.c (maybe_add_partial_symtab_filename): Set "first" to zero
> Doug>   after calling filename_seen.
> Doug>   (make_source_files_completion_list): Ditto.
>
> I wonder whether filename_seen should clear *first.
>
> Tom

[Blech.  Sorry for the repeat.  Original got sent as rich html.]

Heh. :-)

I couldn't understand why it wasn't originally done that way so I left
it at that.
"works for me".