From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: Andrew Burgess <aburgess@broadcom.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: PATCH [0/2] Convert unavailable vector to be bit, not byte, based.
Date: Thu, 05 Dec 2013 18:14:00 -0000 [thread overview]
Message-ID: <CADPb22Q0Yuy4SYPXsXf3Cnh6+ZF9BBomEW2MG4_hT=UiWrYmYg@mail.gmail.com> (raw)
In-Reply-To: <52A0A733.3050001@redhat.com>
On Thu, Dec 5, 2013 at 8:17 AM, Pedro Alves <palves@redhat.com> wrote:
> On 12/04/2013 03:22 PM, Andrew Burgess wrote:
>> This patch set is inspired by two previous patches I've posted:
>>
>> https://sourceware.org/ml/gdb-patches/2013-08/msg00305.html
>> https://sourceware.org/ml/gdb-patches/2013-08/msg00309.html
>>
>> but I think can exist as a separate piece of work.
>
> Excellent! The new test is quite nice work.
>
>> The vector of unavailable parts of a value is currently byte based.
>> Given that we can model a value down to the bit level, we can
>> potentially loose information with the current implementation. After
>> the patch we model the unavailable information in bits.
>
> It'd be good if this paragraph ended up in the commit log of patch 2.
I'd prefer a comment in the code too fwiw.
[and then if one still wants to add a comment to the commit log, go for it]
A simple one-liner explaining why things are the way they are would be
sufficient.
prev parent reply other threads:[~2013-12-05 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 15:22 Andrew Burgess
2013-12-04 15:25 ` [PATCH [1/2] Add support for DW_OP_bit_piece and DW_OP_plus_uconst to DWARF assembler Andrew Burgess
2013-12-05 16:23 ` Pedro Alves
2013-12-05 18:53 ` Tom Tromey
2013-12-06 13:30 ` Andrew Burgess
2013-12-04 15:26 ` [PATCH [0/2] Convert the unavailable vector to be bit, not byte, based Andrew Burgess
2013-12-05 16:18 ` [PATCH [2/2] " Pedro Alves
2013-12-09 21:04 ` Andrew Burgess
2013-12-10 11:32 ` Pedro Alves
2013-12-11 16:28 ` Andrew Burgess
2013-12-11 18:45 ` Pedro Alves
2013-12-17 17:30 ` Andrew Burgess
2013-12-05 16:18 ` PATCH [0/2] Convert " Pedro Alves
2013-12-05 18:14 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Q0Yuy4SYPXsXf3Cnh6+ZF9BBomEW2MG4_hT=UiWrYmYg@mail.gmail.com' \
--to=dje@google.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox