From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25546 invoked by alias); 8 Oct 2014 17:24:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25537 invoked by uid 89); 8 Oct 2014 17:24:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f181.google.com Received: from mail-vc0-f181.google.com (HELO mail-vc0-f181.google.com) (209.85.220.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 08 Oct 2014 17:24:18 +0000 Received: by mail-vc0-f181.google.com with SMTP id le20so7238377vcb.12 for ; Wed, 08 Oct 2014 10:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=72/ICJSuNVVDEijMKLuwmXiwDk3zGhM7v3uy/E4Jtqg=; b=iahR/sHFsR+6dJYE3esZ9GOH2hpV5PzvqgF0cjIE/XRx3r9j7B570oyS3gw5qjcIxG uKcB6339k/BwBp5A0DFckZJyUlzk1W1td58TUxeBBqR2Hw2TGBTnjfpBxWn9jSMMfARI 8/6CgPjxuC38NE32oNyy0vm0AvBwu0RzA8EHwXZebglqRFFQtfeMGTbkWrQC/K1SO37f OtXCTgOmxv3KQnu4JPREibQ9IS7lPXV3mOTs2wMfq1ve543bHjaNAqZ/aNswsJuRmUgX 38K94gxdye45zLAkQ7jTDJAVl0A2KKCqkhZ2rdpwuaOqeCQSaAtF6nNIoBxpq/5i3M/W XEpA== X-Gm-Message-State: ALoCoQmO45CaoytLmX4B3pFahe0ceH52EBSgvzYgSXqOmdc0QUaPMOR7Tp8Pr7lrIxpHze6u2bWE MIME-Version: 1.0 X-Received: by 10.220.174.20 with SMTP id r20mr12204266vcz.11.1412789056277; Wed, 08 Oct 2014 10:24:16 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Wed, 8 Oct 2014 10:24:16 -0700 (PDT) In-Reply-To: References: <1409586154-16196-1-git-send-email-gbenson@redhat.com> <1409586154-16196-2-git-send-email-gbenson@redhat.com> Date: Wed, 08 Oct 2014 17:24:00 -0000 Message-ID: Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions From: Doug Evans To: Gary Benson Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00163.txt.bz2 On Wed, Oct 8, 2014 at 1:12 PM, Doug Evans wrote: > On Wed, Oct 8, 2014 at 1:03 PM, Doug Evans wrote: >> On Mon, Sep 1, 2014 at 11:42 AM, Gary Benson wrote: >>> defs.h includes utils.h, and utils.h includes exceptions.h. All GDB >>> .c files include defs.h as their first line, so no file other than >>> utils.h needs to include exceptions.h. This commit removes all such >>> inclusions. >>> >>> Doug, I Cc'd you on this one as you asked me to avoid giant mechanical >>> ChangeLog entries but I couldn't figure out how I'd rewrite this one. >> >> For reference sake, >> I said that for two reasons: >> 1) to save you some typing >> 2) to keep the S/N ratio of the ChangeLog file from dropping, and in >> this case from dropping significantly. Yikes! >> >>> gdb/ChangeLog: >>> >>> * ada-lang.c: Do not include exceptions.h. >>> * ada-valprint.c: Likewise. >>> * amd64-tdep.c: Likewise. >>> [...] >> >> I realize one of the guidelines for changelogs is to document every >> file that's changed, but if we can agree that "All callers updated." >> can apply to all callers in all files, then I don't see why we >> couldn't be ok with something like the following for this case: >> >> * All .c files: Do not include exceptions.h. >> >> Yeah, it's not pedantically correct, not all .c files were touched. >> But I can live with that given the alternative. > > Actually, exceptions.c still includes exceptions.h. > > I'd be ok with changing the above entry to "* Most .c files: Do not > include exceptions.h." > > Plus, was not removing exceptions.h from exceptions.c an oversight? > [I can't remember if this was discussed in the thread.] Ah. https://sourceware.org/ml/gdb-patches/2014-07/msg00745.html Sorry for the barrage of email. These things often seem to occur to me after I send the previous one. Can you also update the Include files section of the coding standards? https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards This section needs to list exceptions.h and others that .c and .h files are no longer supposed to directly include.