From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-111740-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25235 invoked by alias); 12 Apr 2014 00:18:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 25223 invoked by uid 89); 12 Apr 2014 00:18:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-ve0-f174.google.com
Received: from mail-ve0-f174.google.com (HELO mail-ve0-f174.google.com) (209.85.128.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Apr 2014 00:18:44 +0000
Received: by mail-ve0-f174.google.com with SMTP id oz11so5327258veb.19        for <gdb-patches@sourceware.org>; Fri, 11 Apr 2014 17:18:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=RaygchrYDMFqDj+jcJB397/panFbOzidilS8MPxZxQI=;        b=B/5xHoNPBBhs03hDhIQi81kngIn58sLrxz9yLxq1nbwgFmKRaxiwSJsJ+YLaGRzUA3         Jmmvq749sHmTs2w0k3kuuq0Tq1Qiut+bPwmgbsmJIFthbWGkCUuAJXyRpUyg8V1Hox0J         P/y1pO+I5A72DEEv37T4q9Ej3jaKKnK9v0mrZjNaSZPL8wloJ2EV3KjfLCIMh/jSNpQA         S94FQaz+2TV+UwxMjySFBk9uFTHE+2cWLxmJK87fNoDkJ6zOzUHARHG63rLPz5w0v+ws         SbTKsEgDp87WepvciBn6Y73UhSjbjlsAtpc0iPZNpFV5d55oFVAWWa8FVKrbRmdNLCUX         K46g==
X-Gm-Message-State: ALoCoQnOitkPL37d48pI5gGKT+FiulTifKHDkmGCMrd4d6sYbzrcwWheaqkyzxOB7rnHrTqfMKEkF92Il2+8q7SiOZ/VqdnGX3uYUzjlJqUNEPf1+iLiMAFQ/dWlfWdlCOa9cmhll7mF01lNxsmRDrsn0aLXbNm6gA4A//wqr2oUIRWDNwX2hGbUjDVy6nhA31fgbt9FHg2TRfje9Rqs9oehtb7lpYZm2Q==
MIME-Version: 1.0
X-Received: by 10.52.78.231 with SMTP id e7mr7880515vdx.28.1397261922001; Fri, 11 Apr 2014 17:18:42 -0700 (PDT)
Received: by 10.52.13.101 with HTTP; Fri, 11 Apr 2014 17:18:41 -0700 (PDT)
In-Reply-To: <CAENS6EsUSQTajixKzmStvX9KrG-8SaTA=YVO=6MFMpY35Um9FQ@mail.gmail.com>
References: <CAENS6EsUSQTajixKzmStvX9KrG-8SaTA=YVO=6MFMpY35Um9FQ@mail.gmail.com>
Date: Sat, 12 Apr 2014 00:18:00 -0000
Message-ID: <CADPb22Q02WZGHif_tLv1vZRA48MhXjGY+ZUdhvNUryODf=5qxw@mail.gmail.com>
Subject: Re: [patch] explicitly specify -std=gnu89 for gdb.cp/inline-break.exp
From: Doug Evans <dje@google.com>
To: David Blaikie <dblaikie@gmail.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, Eric Christopher <echristo@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-04/txt/msg00230.txt.bz2

On Fri, Apr 11, 2014 at 4:58 PM, David Blaikie <dblaikie@gmail.com> wrote:
> This test is intending to use gnu style inline rather than the
> standard c99 inline semantics. Clang defaults to c99 and the test
> breaks for this (and other - there's an inlining debug info quality
> bug here too - I'll file a bug and kfail the remaining failures in a
> separate patch) reason.

LGTM, but add a comment in the code explaining why the gnu89 is there.