From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11411 invoked by alias); 13 Jul 2012 19:37:01 -0000 Received: (qmail 11392 invoked by uid 22791); 13 Jul 2012 19:37:01 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jul 2012 19:36:45 +0000 Received: by vcbfl10 with SMTP id fl10so3111461vcb.0 for ; Fri, 13 Jul 2012 12:36:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=E0Hwp6wc3hR8ke173ZnUwag9Cuf0SiIuV8c7KGWgPs8=; b=apQwCPPZl273ptfMQVDYl4c7zAPmsaKkFksqKACLtRhdded/xYX/Aaxqo0gvcI3d/5 IIX7v7zQhzX7QECGhe4PR7P2t/kMseYhH62Oo1TkRt5Y6AJX6304Lvko6RtSYUQFon7Y l1w/3sFIFjWSHjf0oBoyEdaFEwA+18HY+vfBlnVwlU14S8p55yiRri+JAinKfR1KMLJY gAL2rr8UvuYSS4vF5AJxELtC+tV3MCIjwkq9WwUQgcBVwWJjsO/qaKEhAuEgNUWxUlX+ 44P1d8Q45/gnDKhOxS7SZLlAV+FOCSD3sYV3G5hQnsYmvtUY9x1romCi0CK2GXS3NsHF Zv/A== Received: by 10.220.107.136 with SMTP id b8mr1191766vcp.17.1342208204836; Fri, 13 Jul 2012 12:36:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.107.136 with SMTP id b8mr1191753vcp.17.1342208204627; Fri, 13 Jul 2012 12:36:44 -0700 (PDT) Received: by 10.52.157.4 with HTTP; Fri, 13 Jul 2012 12:36:44 -0700 (PDT) In-Reply-To: <201207131921.q6DJLf5t002291@greed.delorie.com> References: <20120709181015.2FCA41E13A1@ruffy2.mtv.corp.google.com> <201207131921.q6DJLf5t002291@greed.delorie.com> Date: Fri, 13 Jul 2012 19:37:00 -0000 Message-ID: Subject: Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb. From: Doug Evans To: DJ Delorie Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQmaM867W+tzyOsYAlj/xiqKJPDBZ6gMQO2iiePXwFCiHz2wdMe/rmcKMpywXjhMlnAOBOIzHkObaIxx4rvU7Ysp4jz4umW0nO2rZWZpWrIDS5TfD/MsKmyDZBAtdfz0FAHrNus5rCd0T4T2LyA9PwLs1DCCc1Fp9lbjVLN9dOl2XTVSwDDyHKSh1xpyCjhYE/N/pnh+ X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00184.txt.bz2 On Fri, Jul 13, 2012 at 12:21 PM, DJ Delorie wrote: > > I think it's confusing to have filename_cmp and filename_eq that do > basically the same thing. Perhaps filename_eq should be > filename_cmp_v or filename_cmp_hash or something, to indicate that > it's *supposed* to be the same functionality as filename_cmp but with > a different signature? To be clear, filename_cmp is to strcmp as filename_eq is to streq. ref: STREQ in libiberty/regex.c: # define STREQ(s1, s2) ((strcmp (s1, s2) == 0)) Given that, I think the names are fine as is, but I'm happy to change them. I like "eq", it's what hashtab uses (e.g. htab_eq_pointer). How about filename_eq_hash?